This repository was archived by the owner on Mar 12, 2020. It is now read-only.
Set up Android for emission#730
Closed
yuki24 wants to merge 1 commit into
Closed
Conversation
Contributor
|
New dependencies added: . Generated by 🚫 dangerJS |
1 similar comment
Contributor
|
New dependencies added: . Generated by 🚫 dangerJS |
Contributor
|
Cool, looks fairly straightforward! Looking forward to the blog post :) |
ashkan18
approved these changes
Aug 28, 2017
ashkan18
left a comment
ashkan18
left a comment
Contributor
There was a problem hiding this comment.
Nice!!! 💯 exciting stuff!!!
Contributor
Author
|
looks like the build is broken now. I'll look into it. |
Contributor
|
@yuki24 Emission works off local branches, not forks |
Contributor
Author
|
It seems like I shouldn't have forked emission. I'll re-send this PR so the build will get proper ENV variables. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a complete redo of #225 and my hackathon project. In orders to minimize the initial diff (although this is still really big) and make it easier for other to understand the entire change, I focused on just setting up the project rather than going all the way to implement integration with existing stuff. In summary, I have made these changes:
react-native init androidand moved the entire project up to the root directorycompileSdkVersion,buildToolsVersion,targetSdkVersion, and the support libraries to25, which is compatible with the latest React Native versionRight now, it still uses the default component generated by the
react-native initcommand. Naturally, the next step will be to have it integrate with Emission's existing components.