This repository was archived by the owner on Mar 12, 2020. It is now read-only.
Conversation
Contributor
Author
|
Wasn't planning on merging, would slow down ios dev for little reason ATM, but it's nice to see what this looks like. |
Contributor
|
Yes, totally! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a dropdown to VS Code to launch the app in Android.
Which currently renders our home component as the root component, there would need to be work around replicating/replacing the ARSwitchView and ARSpinner for the other views.
This doesn't render the artwork images, I don't think
onLayoutis being called for them. Figure it'll take a tiny amount of time once alloy is in town to fix with him - rather than me poring through source.Setup docs: https://github.com/artsy/emission/blob/android/docs/android.md
As we don't have pods for fonts etc, I'm copying them from the Pods, which will be consistently named.