Failing jobs when they are rejected by an admission webhook #267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a job is rejected by adn admission webhook, this means it'll keep getting rejected so we should fail it so the user fix it. The "best" way to determine if it was a admission webhook that rejected it, is by looking for "admission webhook" in the message This is because: - Users can define their own return codes from webhooks (Although we could just fail all in the 4xx range - By default Kubernetes returns a 500 on validating webhook rejection. So this can't be differentiated from a genuine kubernetes failure (which we would want to retry on) Ideally Kubernetes changes the default to 4xx and we can just fail any pods when a 4xx response happens
jankaspar
approved these changes
Nov 29, 2019
|
Fixes #261 |
svc-gh-ghzonetrans-p
pushed a commit
that referenced
this pull request
Oct 31, 2024
* wip * wip * wip
d80tb7
added a commit
that referenced
this pull request
Oct 31, 2024
* [Simulator] Allow JobTemplates To Be Repeated (#267) * wip * wip * wip * F/chrisma/simulator repeated submission (#269) * wip * wip * wip * lint * Update simulator.go --------- Co-authored-by: Christopher Martin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a job is rejected by an admission webhook, this means it'll keep getting rejected so we should fail it so the user fix it.
The "best" way to determine if it was a admission webhook that rejected it, is by looking for "admission webhook" in the message
This is because:
Ideally Kubernetes changes the default to 4xx and we can just fail any pods when a 4xx response happens