Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fail jobs when they are rejected by an admission webhook #261

Closed
JamesMurkin opened this issue Nov 28, 2019 · 0 comments
Closed

Fail jobs when they are rejected by an admission webhook #261

JamesMurkin opened this issue Nov 28, 2019 · 0 comments

Comments

@JamesMurkin
Copy link
Contributor

Problem

When jobs are submitted. If they are rejected as they don't meet the requirements of an admission webhook they have their lease returned.

This causes them to constantly bounce between being submitted and being returned.

If they are rejected by an admission webhook, likely they'll always be rejected by it.

Solution
When they are rejected due to admission webhook, the job should be failed rather than having lease returned.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant