CMake: Create a library target for intel_gpu_top code#1173
Merged
deckstose merged 2 commits intoaristocratos:mainfrom Jun 3, 2025
Merged
CMake: Create a library target for intel_gpu_top code#1173deckstose merged 2 commits intoaristocratos:mainfrom
deckstose merged 2 commits intoaristocratos:mainfrom
Conversation
This will ensure that the configure step fails if LTO is requested but unsupported by the compiler.
This allows the suppression of warnings specifically for the C code, which throws lots of warnings with current compilers.
aristocratos
approved these changes
Jun 2, 2025
khaneliman
reviewed
Jul 5, 2025
Comment on lines
+66
to
+70
| if(BTOP_LTO) | ||
| check_ipo_supported() | ||
| set_target_properties(btop PROPERTIES INTERPROCEDURAL_OPTIMIZATION ON) | ||
| endif() | ||
|
|
There was a problem hiding this comment.
Is this not a bug? You went from checking if it was supported before enabling to just enabling regardless. We are seeing a build failure NixOS/nixpkgs#422218 and wanted to double check before I pass a flag to explicitly disable BTOP_LTO
Collaborator
Author
There was a problem hiding this comment.
It's not enabled regardless since check_ipo_supported terminates CMake if LTO is unsupported.
Yes, on platforms with no LTO you now must explicitly disable LTO via BTOP_LTO.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.