Skip to content

btop: 1.4.3 -> 1.4.4#422218

Merged
khaneliman merged 1 commit intoNixOS:masterfrom
ddogfoodd:update-btop
Jul 6, 2025
Merged

btop: 1.4.3 -> 1.4.4#422218
khaneliman merged 1 commit intoNixOS:masterfrom
ddogfoodd:update-btop

Conversation

@ddogfoodd
Copy link
Contributor

@ddogfoodd ddogfoodd commented Jul 3, 2025

Changelog: https://github.com/aristocratos/btop/releases/tag/v1.4.4
Diff: aristocratos/btop@v1.4.3...v1.4.4

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • Nixpkgs 25.11 Release Notes (or backporting 25.05 Nixpkgs Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
  • NixOS 25.11 Release Notes (or backporting 25.05 NixOS Release notes)
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other contributing documentation in corresponding paths.

Add a 👍 reaction to pull requests you find important.

@nix-owners nix-owners bot requested review from khaneliman, rmcgibbo and ryan4yin July 3, 2025 21:21
@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. labels Jul 3, 2025
@nadir-ishiguro
Copy link
Contributor

nadir-ishiguro commented Jul 3, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 422218
Commit: 935dc291c63252a3d8d8b6cd554fd93c711230d1

x86_64-linux

✅ 4 packages built:
  • btop
  • btop-cuda
  • btop-rocm
  • hyprpanel

@nixpkgs-ci nixpkgs-ci bot added the 12.approvals: 1 This PR was reviewed and approved by one person. label Jul 3, 2025
@khaneliman
Copy link
Contributor

khaneliman commented Jul 4, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 422218
Commit: 935dc291c63252a3d8d8b6cd554fd93c711230d1

x86_64-linux

✅ 4 packages built:
  • btop
  • btop-cuda
  • btop-rocm
  • hyprpanel

aarch64-linux

✅ 3 packages built:
  • btop
  • btop-cuda
  • hyprpanel

x86_64-darwin

❌ 2 packages failed to build:
  • btop
  • btop-cuda

aarch64-darwin

❌ 2 packages failed to build:
  • btop
  • btop-cuda
Error logs: `x86_64-darwin`
btop 
source root is source
Running phase: patchPhase
Running phase: configurePhase
fixing cmake files...
cmake flags: -DCMAKE_FIND_USE_SYSTEM_PACKAGE_REGISTRY=OFF -DCMAKE_FIND_USE_PACKAGE_REGISTRY=OFF -DCMAKE_EXPORT_NO_PACKAGE_REGISTRY=ON -DCMAKE_BUILD_TYPE=Release -DBUILD_TESTING=OFF -DCMAKE_INSTALL_LOCALEDIR=/nix/store/9ldh0hlvh4gi4m62cz1dfjk6q9fimb63-btop-1.4.4/share/locale -DCMAKE_INSTALL_LIBEXECDIR=/nix/store/9ldh0hlvh4gi4m62cz1dfjk6q9fimb63-btop-1.4.4/libexec -DCMAKE_INSTALL_LIBDIR=/nix/store/9ldh0hlvh4gi4m62cz1dfjk6q9fimb63-btop-1.4.4/lib -DCMAKE_INSTALL_DOCDIR=/nix/store/9ldh0hlvh4gi4m62cz1dfjk6q9fimb63-btop-1.4.4/share/doc/btop -DCMAKE_INSTALL_INFODIR=/nix/store/9ldh0hlvh4gi4m62cz1dfjk6q9fimb63-btop-1.4.4/share/info -DCMAKE_INSTALL_MANDIR=/nix/store/9ldh0hlvh4gi4m62cz1dfjk6q9fimb63-btop-1.4.4/share/man -DCMAKE_INSTALL_INCLUDEDIR=/nix/store/9ldh0hlvh4gi4m62cz1dfjk6q9fimb63-btop-1.4.4/include -DCMAKE_INSTALL_SBINDIR=/nix/store/9ldh0hlvh4gi4m62cz1dfjk6q9fimb63-btop-1.4.4/sbin -DCMAKE_INSTALL_BINDIR=/nix/store/9ldh0hlvh4gi4m62cz1dfjk6q9fimb63-btop-1.4.4/bin -DCMAKE_INSTALL_NAME_DIR=/nix/store/9ldh0hlvh4gi4m62cz1dfjk6q9fimb63-btop-1.4.4/lib -DCMAKE_POLICY_DEFAULT_CMP0025=NEW -DCMAKE_FIND_FRAMEWORK=LAST -DCMAKE_STRIP=/nix/store/cpjrfk28hkjl7qxxamsc0v9sndj41wc1-clang-wrapper-19.1.7/bin/strip -DCMAKE_RANLIB=/nix/store/cpjrfk28hkjl7qxxamsc0v9sndj41wc1-clang-wrapper-19.1.7/bin/ranlib -DCMAKE_AR=/nix/store/cpjrfk28hkjl7qxxamsc0v9sndj41wc1-clang-wrapper-19.1.7/bin/ar -DCMAKE_C_COMPILER=clang -DCMAKE_CXX_COMPILER=clang++ -DCMAKE_INSTALL_PREFIX=/nix/store/9ldh0hlvh4gi4m62cz1dfjk6q9fimb63-btop-1.4.4
-- The CXX compiler identification is Clang 19.1.7
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Check for working CXX compiler: /nix/store/cpjrfk28hkjl7qxxamsc0v9sndj41wc1-clang-wrapper-19.1.7/bin/clang++ - skipped
-- Detecting CXX compile features
-- Detecting CXX compile features - done
CMake Error at /nix/store/0ywb0vafxr8glh4baja4b44cz8ag8zkr-cmake-3.31.7/share/cmake-3.31/Modules/CheckIPOSupported.cmake:68 (message):
  IPO is not supported (check failed to compile).
Call Stack (most recent call first):
  /nix/store/0ywb0vafxr8glh4baja4b44cz8ag8zkr-cmake-3.31.7/share/cmake-3.31/Modules/CheckIPOSupported.cmake:153 (_ipo_not_supported)
  /nix/store/0ywb0vafxr8glh4baja4b44cz8ag8zkr-cmake-3.31.7/share/cmake-3.31/Modules/CheckIPOSupported.cmake:261 (_ipo_run_language_check)
  CMakeLists.txt:67 (check_ipo_supported)

-- Configuring incomplete, errors occurred!

btop-cuda 
source root is source
Running phase: patchPhase
Running phase: configurePhase
fixing cmake files...
cmake flags: -DCMAKE_FIND_USE_SYSTEM_PACKAGE_REGISTRY=OFF -DCMAKE_FIND_USE_PACKAGE_REGISTRY=OFF -DCMAKE_EXPORT_NO_PACKAGE_REGISTRY=ON -DCMAKE_BUILD_TYPE=Release -DBUILD_TESTING=OFF -DCMAKE_INSTALL_LOCALEDIR=/nix/store/mvwv64cyj38y98m7n6plhf9cd5l65adr-btop-1.4.4/share/locale -DCMAKE_INSTALL_LIBEXECDIR=/nix/store/mvwv64cyj38y98m7n6plhf9cd5l65adr-btop-1.4.4/libexec -DCMAKE_INSTALL_LIBDIR=/nix/store/mvwv64cyj38y98m7n6plhf9cd5l65adr-btop-1.4.4/lib -DCMAKE_INSTALL_DOCDIR=/nix/store/mvwv64cyj38y98m7n6plhf9cd5l65adr-btop-1.4.4/share/doc/btop -DCMAKE_INSTALL_INFODIR=/nix/store/mvwv64cyj38y98m7n6plhf9cd5l65adr-btop-1.4.4/share/info -DCMAKE_INSTALL_MANDIR=/nix/store/mvwv64cyj38y98m7n6plhf9cd5l65adr-btop-1.4.4/share/man -DCMAKE_INSTALL_INCLUDEDIR=/nix/store/mvwv64cyj38y98m7n6plhf9cd5l65adr-btop-1.4.4/include -DCMAKE_INSTALL_SBINDIR=/nix/store/mvwv64cyj38y98m7n6plhf9cd5l65adr-btop-1.4.4/sbin -DCMAKE_INSTALL_BINDIR=/nix/store/mvwv64cyj38y98m7n6plhf9cd5l65adr-btop-1.4.4/bin -DCMAKE_INSTALL_NAME_DIR=/nix/store/mvwv64cyj38y98m7n6plhf9cd5l65adr-btop-1.4.4/lib -DCMAKE_POLICY_DEFAULT_CMP0025=NEW -DCMAKE_FIND_FRAMEWORK=LAST -DCMAKE_STRIP=/nix/store/cpjrfk28hkjl7qxxamsc0v9sndj41wc1-clang-wrapper-19.1.7/bin/strip -DCMAKE_RANLIB=/nix/store/cpjrfk28hkjl7qxxamsc0v9sndj41wc1-clang-wrapper-19.1.7/bin/ranlib -DCMAKE_AR=/nix/store/cpjrfk28hkjl7qxxamsc0v9sndj41wc1-clang-wrapper-19.1.7/bin/ar -DCMAKE_C_COMPILER=clang -DCMAKE_CXX_COMPILER=clang++ -DCMAKE_INSTALL_PREFIX=/nix/store/mvwv64cyj38y98m7n6plhf9cd5l65adr-btop-1.4.4
-- The CXX compiler identification is Clang 19.1.7
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Check for working CXX compiler: /nix/store/cpjrfk28hkjl7qxxamsc0v9sndj41wc1-clang-wrapper-19.1.7/bin/clang++ - skipped
-- Detecting CXX compile features
-- Detecting CXX compile features - done
CMake Error at /nix/store/0ywb0vafxr8glh4baja4b44cz8ag8zkr-cmake-3.31.7/share/cmake-3.31/Modules/CheckIPOSupported.cmake:68 (message):
  IPO is not supported (check failed to compile).
Call Stack (most recent call first):
  /nix/store/0ywb0vafxr8glh4baja4b44cz8ag8zkr-cmake-3.31.7/share/cmake-3.31/Modules/CheckIPOSupported.cmake:153 (_ipo_not_supported)
  /nix/store/0ywb0vafxr8glh4baja4b44cz8ag8zkr-cmake-3.31.7/share/cmake-3.31/Modules/CheckIPOSupported.cmake:261 (_ipo_run_language_check)
  CMakeLists.txt:67 (check_ipo_supported)

-- Configuring incomplete, errors occurred!

Error logs: `aarch64-darwin`
btop 
@nix { "action": "setPhase", "phase": "updateAutotoolsGnuConfigScriptsPhase" }
Running phase: configurePhase
@nix { "action": "setPhase", "phase": "configurePhase" }
fixing cmake files...
cmake flags: -DCMAKE_FIND_USE_SYSTEM_PACKAGE_REGISTRY=OFF -DCMAKE_FIND_USE_PACKAGE_REGISTRY=OFF -DCMAKE_EXPORT_NO_PACKAGE_REGISTRY=ON -DCMAKE_BUILD_TYPE=Release -DBUILD_TESTING=OFF -DCMAKE_INSTALL_LOCALEDIR=/nix/store/hbl31b5lzkvwh3kh6k448af05ba7gmr0-btop-1.4.4/share/locale -DCMAKE_INSTALL_LIBEXECDIR=/nix/store/hbl31b5lzkvwh3kh6k448af05ba7gmr0-btop-1.4.4/libexec -DCMAKE_INSTALL_LIBDIR=/nix/store/hbl31b5lzkvwh3kh6k448af05ba7gmr0-btop-1.4.4/lib -DCMAKE_INSTALL_DOCDIR=/nix/store/hbl31b5lzkvwh3kh6k448af05ba7gmr0-btop-1.4.4/share/doc/btop -DCMAKE_INSTALL_INFODIR=/nix/store/hbl31b5lzkvwh3kh6k448af05ba7gmr0-btop-1.4.4/share/info -DCMAKE_INSTALL_MANDIR=/nix/store/hbl31b5lzkvwh3kh6k448af05ba7gmr0-btop-1.4.4/share/man -DCMAKE_INSTALL_INCLUDEDIR=/nix/store/hbl31b5lzkvwh3kh6k448af05ba7gmr0-btop-1.4.4/include -DCMAKE_INSTALL_SBINDIR=/nix/store/hbl31b5lzkvwh3kh6k448af05ba7gmr0-btop-1.4.4/sbin -DCMAKE_INSTALL_BINDIR=/nix/store/hbl31b5lzkvwh3kh6k448af05ba7gmr0-btop-1.4.4/bin -DCMAKE_INSTALL_NAME_DIR=/nix/store/hbl31b5lzkvwh3kh6k448af05ba7gmr0-btop-1.4.4/lib -DCMAKE_POLICY_DEFAULT_CMP0025=NEW -DCMAKE_FIND_FRAMEWORK=LAST -DCMAKE_STRIP=/nix/store/1g645wydyvns7dy8gy27dq0n3rbkd712-clang-wrapper-19.1.7/bin/strip -DCMAKE_RANLIB=/nix/store/1g645wydyvns7dy8gy27dq0n3rbkd712-clang-wrapper-19.1.7/bin/ranlib -DCMAKE_AR=/nix/store/1g645wydyvns7dy8gy27dq0n3rbkd712-clang-wrapper-19.1.7/bin/ar -DCMAKE_C_COMPILER=clang -DCMAKE_CXX_COMPILER=clang++ -DCMAKE_INSTALL_PREFIX=/nix/store/hbl31b5lzkvwh3kh6k448af05ba7gmr0-btop-1.4.4
-- The CXX compiler identification is Clang 19.1.7
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Check for working CXX compiler: /nix/store/1g645wydyvns7dy8gy27dq0n3rbkd712-clang-wrapper-19.1.7/bin/clang++ - skipped
-- Detecting CXX compile features
-- Detecting CXX compile features - done
CMake Error at /nix/store/6m8dh17b5ylql37wnkwjcag45i8nk2by-cmake-3.31.7/share/cmake-3.31/Modules/CheckIPOSupported.cmake:68 (message):
  IPO is not supported (check failed to compile).
Call Stack (most recent call first):
  /nix/store/6m8dh17b5ylql37wnkwjcag45i8nk2by-cmake-3.31.7/share/cmake-3.31/Modules/CheckIPOSupported.cmake:153 (_ipo_not_supported)
  /nix/store/6m8dh17b5ylql37wnkwjcag45i8nk2by-cmake-3.31.7/share/cmake-3.31/Modules/CheckIPOSupported.cmake:261 (_ipo_run_language_check)
  CMakeLists.txt:67 (check_ipo_supported)

-- Configuring incomplete, errors occurred!

btop-cuda 
@nix { "action": "setPhase", "phase": "updateAutotoolsGnuConfigScriptsPhase" }
Running phase: configurePhase
@nix { "action": "setPhase", "phase": "configurePhase" }
fixing cmake files...
cmake flags: -DCMAKE_FIND_USE_SYSTEM_PACKAGE_REGISTRY=OFF -DCMAKE_FIND_USE_PACKAGE_REGISTRY=OFF -DCMAKE_EXPORT_NO_PACKAGE_REGISTRY=ON -DCMAKE_BUILD_TYPE=Release -DBUILD_TESTING=OFF -DCMAKE_INSTALL_LOCALEDIR=/nix/store/a0hmlynfgxgshg13bwbvjvphh6x9cagp-btop-1.4.4/share/locale -DCMAKE_INSTALL_LIBEXECDIR=/nix/store/a0hmlynfgxgshg13bwbvjvphh6x9cagp-btop-1.4.4/libexec -DCMAKE_INSTALL_LIBDIR=/nix/store/a0hmlynfgxgshg13bwbvjvphh6x9cagp-btop-1.4.4/lib -DCMAKE_INSTALL_DOCDIR=/nix/store/a0hmlynfgxgshg13bwbvjvphh6x9cagp-btop-1.4.4/share/doc/btop -DCMAKE_INSTALL_INFODIR=/nix/store/a0hmlynfgxgshg13bwbvjvphh6x9cagp-btop-1.4.4/share/info -DCMAKE_INSTALL_MANDIR=/nix/store/a0hmlynfgxgshg13bwbvjvphh6x9cagp-btop-1.4.4/share/man -DCMAKE_INSTALL_INCLUDEDIR=/nix/store/a0hmlynfgxgshg13bwbvjvphh6x9cagp-btop-1.4.4/include -DCMAKE_INSTALL_SBINDIR=/nix/store/a0hmlynfgxgshg13bwbvjvphh6x9cagp-btop-1.4.4/sbin -DCMAKE_INSTALL_BINDIR=/nix/store/a0hmlynfgxgshg13bwbvjvphh6x9cagp-btop-1.4.4/bin -DCMAKE_INSTALL_NAME_DIR=/nix/store/a0hmlynfgxgshg13bwbvjvphh6x9cagp-btop-1.4.4/lib -DCMAKE_POLICY_DEFAULT_CMP0025=NEW -DCMAKE_FIND_FRAMEWORK=LAST -DCMAKE_STRIP=/nix/store/1g645wydyvns7dy8gy27dq0n3rbkd712-clang-wrapper-19.1.7/bin/strip -DCMAKE_RANLIB=/nix/store/1g645wydyvns7dy8gy27dq0n3rbkd712-clang-wrapper-19.1.7/bin/ranlib -DCMAKE_AR=/nix/store/1g645wydyvns7dy8gy27dq0n3rbkd712-clang-wrapper-19.1.7/bin/ar -DCMAKE_C_COMPILER=clang -DCMAKE_CXX_COMPILER=clang++ -DCMAKE_INSTALL_PREFIX=/nix/store/a0hmlynfgxgshg13bwbvjvphh6x9cagp-btop-1.4.4
-- The CXX compiler identification is Clang 19.1.7
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Check for working CXX compiler: /nix/store/1g645wydyvns7dy8gy27dq0n3rbkd712-clang-wrapper-19.1.7/bin/clang++ - skipped
-- Detecting CXX compile features
-- Detecting CXX compile features - done
CMake Error at /nix/store/6m8dh17b5ylql37wnkwjcag45i8nk2by-cmake-3.31.7/share/cmake-3.31/Modules/CheckIPOSupported.cmake:68 (message):
  IPO is not supported (check failed to compile).
Call Stack (most recent call first):
  /nix/store/6m8dh17b5ylql37wnkwjcag45i8nk2by-cmake-3.31.7/share/cmake-3.31/Modules/CheckIPOSupported.cmake:153 (_ipo_not_supported)
  /nix/store/6m8dh17b5ylql37wnkwjcag45i8nk2by-cmake-3.31.7/share/cmake-3.31/Modules/CheckIPOSupported.cmake:261 (_ipo_run_language_check)
  CMakeLists.txt:67 (check_ipo_supported)

-- Configuring incomplete, errors occurred!

khaneliman
khaneliman requested changes Jul 4, 2025
View reviewed changes
Copy link
Contributor

@khaneliman khaneliman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would like to hold off until we can fix darwin.

@matthiasbeyer
Copy link
Contributor

matthiasbeyer commented Jul 5, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 422218
Commit: 935dc291c63252a3d8d8b6cd554fd93c711230d1

x86_64-linux

✅ 4 packages built:
  • btop
  • btop-cuda
  • btop-rocm
  • hyprpanel

@nixpkgs-ci nixpkgs-ci bot added 12.approvals: 2 This PR was reviewed and approved by two persons. and removed 12.approvals: 1 This PR was reviewed and approved by one person. labels Jul 5, 2025
@khaneliman khaneliman mentioned this pull request Jul 5, 2025
Merged
@khaneliman
Copy link
Contributor

khaneliman commented Jul 5, 2025

Add this to get around the build failure, for now?

  cmakeFlags = lib.optionals stdenv.hostPlatform.isDarwin [
    "-DBTOP_LTO=OFF"
  ];

@ddogfoodd ddogfoodd requested a review from khaneliman July 6, 2025 08:37
Aleksanaa
Aleksanaa reviewed Jul 6, 2025
View reviewed changes
@ddogfoodd ddogfoodd requested a review from Aleksanaa July 6, 2025 13:09
@ddogfoodd
Copy link
Contributor Author

ddogfoodd commented Jul 6, 2025

Also added a comment with reference to the posts of @khaneliman

@khaneliman
Copy link
Contributor

khaneliman commented Jul 6, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 422218
Commit: 2729d95aa413862ee6a300268fd5d8a06bed1c15

x86_64-linux

✅ 4 packages built:
  • btop
  • btop-cuda
  • btop-rocm
  • hyprpanel

aarch64-linux

✅ 3 packages built:
  • btop
  • btop-cuda
  • hyprpanel

x86_64-darwin

✅ 2 packages built:
  • btop
  • btop-cuda

aarch64-darwin

✅ 2 packages built:
  • btop
  • btop-cuda

@khaneliman khaneliman merged commit 3f737c6 into NixOS:master Jul 6, 2025
23 of 27 checks passed
@ddogfoodd ddogfoodd deleted the update-btop branch July 6, 2025 16:58
@sokai
Copy link

sokai commented Aug 4, 2025 •
edited
Loading

@ddogfoodd / @khaneliman: may I ask you if a backport to 25.05 is possible for this?
(I searched the PRs, couldn't find one and wanted to ask before creating a new issue …)

FYI: 1.4.4 has a fix for aristocratos/btop#1155 , which I'd like (kinda) to have … B)

BR

@matthiasbeyer matthiasbeyer added the 4.workflow: backport This targets a stable branch label Aug 4, 2025
@matthiasbeyer matthiasbeyer added backport release-25.05 and removed 4.workflow: backport This targets a stable branch labels Aug 4, 2025
@nixpkgs-ci
Copy link
Contributor

nixpkgs-ci bot commented Aug 4, 2025

Successfully created backport PR for release-25.05:

@nixpkgs-ci nixpkgs-ci bot mentioned this pull request Aug 4, 2025
Merged
1 task
@github-actions github-actions bot added the 8.has: port to stable This PR already has a backport to the stable release. label Aug 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@matthiasbeyer matthiasbeyer matthiasbeyer approved these changes

@khaneliman khaneliman khaneliman approved these changes

@ryan4yin ryan4yin Awaiting requested review from ryan4yin

@rmcgibbo rmcgibbo Awaiting requested review from rmcgibbo

@Aleksanaa Aleksanaa Awaiting requested review from Aleksanaa

+1 more reviewer

@nadir-ishiguro nadir-ishiguro nadir-ishiguro approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

8.has: port to stable This PR already has a backport to the stable release. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 12.approvals: 2 This PR was reviewed and approved by two persons.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@ddogfoodd @nadir-ishiguro @khaneliman @matthiasbeyer @sokai @Aleksanaa