Repository navigation
Update Astro - #7300
Merged
Merged
Update Astro#7300
Conversation
|
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (2)
🚧 Files skipped from review as they are similar to previous changes (1)
Included review availability: Your plan provides up to 8 included reviews per hour; 6 remain after this review. 📝 WalkthroughSummary by CodeRabbit
WalkthroughThe app updates Astro-related dependencies and adds ChangesAstro app updates
Estimated code review effort: 1 (Trivial) | ~2 minutes Merge Risk: ⚪ Minimal · up to This PR updates aligned Astro packages and pre-optimizes the manifest import to prevent a cold-start SSR failure. No actionable merge-blocking risk remains after normal checks and review. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Full details: Docstring CoverageExplanation No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1 files. (1 skipped: 1 unsupported.) ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
PerformanceChromeNo significant performance changes detected. Full breakdown (27 tests)
Unflagged threshold-sized changes for combobox-perf > react > move across items: INP (rounds 2/3, raw 0/3, pairs 33%). collection-renderer-perf > react > rerender nested renderers
combobox-perf > react > open combobox
combobox-select-perf > react > restore filtered items
composite-perf > react > mount composite
composite-perf > react > move across items
dialog-perf > react > open dialog
menu-perf > react > open menu
tab-perf > react > mount tabs
tab-perf > react > move across tabs
tooltip-perf > react > move across items with independent tooltips
Compared tests used mixed interleaved round counts; a change is flagged only when the paired median delta exceeds the threshold, rounds agree on direction and raw samples support it. NodeNo significant performance changes detected. Full breakdown (33 benchmarks)packages/ariakit-components/benchmark/collection-store.bench.ts
packages/ariakit-components/benchmark/composite-store.bench.ts
packages/ariakit-components/benchmark/disclosure-store.bench.ts
packages/ariakit-components/benchmark/tab-store.bench.ts
packages/ariakit-store/benchmark/store.bench.ts
Aggregated across 2 interleaved rounds; a change is flagged only when the paired median delta exceeds the threshold, rounds agree on direction. |
Member
Author
|
Astro 7.2.6 exposed an update-induced cold-start regression in the OG-images job. The first The workaround adds the manifest to the existing pre-optimization list: optimizeDeps: {
include: ["astro/app/manifest"],
}This keeps the cold server program stable without disabling dependency discovery or changing the CI startup flow. The workaround can be revisited when the upstream cold SSR optimizer issue is fixed. Local verification changed the exact reproduction from a server crash to HTTP 200. This pull request needs review because it now includes an app configuration workaround beyond version and lockfile changes. Automerge remains disabled. |
ariakit-bot
approved these changes
Aug 27, 2026
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The app uses an Astro dependency group with three eligible patch updates under the repository Renovate policy. Updating the group keeps the Astro runtime, Cloudflare adapter, and MDX integration aligned after their stability-aged fixes.
Solution
Update the exact versions in
app/package.json, then regenerate and deduplicatepnpm-lock.yamlwith the repository declared pnpm 11.24.0.{ "@astrojs/cloudflare": "14.2.4", "@astrojs/mdx": "7.0.8", "astro": "7.2.6" }Astro PR #17812 makes the ambient manifest external during optimization. This leaves the bare
astro/app/manifestimport for Vite to discover in the normal server graph. On a cold start, that discovery during the first OG-image request reloads the server program and invalidates the already-requesteddeps_ssr/default-handler-*.jschunk. This is the cold SSR optimizer failure class tracked in Astro #17166 and Astro #16248.Pre-optimize the manifest through the existing app workaround list:
Dependencies
@astrojs/cloudflareapp14.2.314.2.4@astrojs/mdxapp7.0.77.0.8astroapp7.2.47.2.6Verification
pnpm install --frozen-lockfilepnpm dedupepnpm lint-fixpnpm tscpnpm build-app-litepnpm dev-appfrom a cold Vite cache, then confirmcurl -i http://localhost:4322/og-image/apireturns HTTP 200