Introduce blobbasefee by nikola-matic · Pull Request #14755 · argotorg/solidity

nikola-matic · 2023-12-25T12:51:27Z

Closes: #14742
~~Depends on: #14743~~

libyul/backends/evm/EVMDialect.cpp

libevmasm/Instruction.cpp

docs/cheatsheet.rst

test/EVMHost.cpp

test/libsolidity/syntaxTests/inlineAssembly/blobbasefee_reserved_cancun.sol

test/libsolidity/syntaxTests/types/magic_block_blobbasefee_error.sol

Changelog.md

test/tools/yulInterpreter/EVMInstructionInterpreter.cpp

docs/using-the-compiler.rst

test/libsolidity/semanticTests/inlineAssembly/blobbasefee_shanghai_function.sol

test/libyul/yulSyntaxTests/blobbasefee_reserved_identifier_post_cancun.sol

cameel

I'm approving since it's good enough, but there are a few small things we could still tweak. See review comments.

We're missing SMTChecker support, but that's not essential for the release. Please just create an issue for it. The implementation would be as for basefee in #11785.

Fuzzer support is also missing and adding it seems fairly trivial (just a change in ossfuzz/protoToYul.cpp), but it's better left to @bshastry since he can verify it's done properly.

docs/units-and-global-variables.rst

test/libsolidity/semanticTests/inlineAssembly/blobbasefee_shanghai_function.sol

nikola-matic · 2024-01-11T16:16:17Z

I'm approving since it's good enough, but there are a few small things we could still tweak. See review comments.

We're missing SMTChecker support, but that's not essential for the release. Please just create an issue for it. The implementation would be as for basefee in #11785.

Fuzzer support is also missing and adding it seems fairly trivial (just a change in ossfuzz/protoToYul.cpp), but it's better left to @bshastry since he can verify it's done properly.

Yeah, saw the missing SMT support when initially implementing this last year (was especially evident when greping basefee); I may have even asked (or was planning to and then didn't wanna ping people during Christmas) whose responsibility that is. But yeah, given that I have nothing more pressing to do, I can give it a go in another PR.

cameel · 2024-01-11T16:39:01Z

I mean, it's probably something that @pgebal would pick sooner or later. We just need an issue for it.

r0qs

LGTM as well, although I have one last comment.

test/libyul/yulSyntaxTests/blobbasefee_reserved_identifier_post_cancun.yul

cameel

Looks good to merge after squashing.

test/libsolidity/ViewPureChecker.cpp

scripts/error_codes.py

Saw-mon-and-Natalie · 2025-07-16T00:47:21Z

docs/yul.rst

+Opcodes marked with ``F``, ``H``, ``B``, ``C``, ``I``, ``L``, ``P`` and ``N`` are present since Frontier,
+Homestead, Byzantium, Constantinople, Istanbul, London, Paris or Cancun respectively.


why N for Cancun?

nikola-matic added has dependencies The PR depends on other PRs that must be merged first feature labels Dec 25, 2023

nikola-matic added this to the 0.8.24 milestone Dec 25, 2023

nikola-matic self-assigned this Dec 25, 2023

nikola-matic commented Dec 25, 2023

View reviewed changes

libyul/backends/evm/EVMDialect.cpp Show resolved Hide resolved

nikola-matic changed the base branch from develop to bump-evmone-and-evmc-to-11 December 26, 2023 07:35

nikola-matic force-pushed the introduce-blobbasefee branch from dd71e36 to 8fc4f2e Compare December 26, 2023 07:36

nikola-matic force-pushed the bump-evmone-and-evmc-to-11 branch from 498252a to 9160451 Compare December 27, 2023 10:57

nikola-matic force-pushed the introduce-blobbasefee branch from 8fc4f2e to 7146f4b Compare December 27, 2023 11:30

r0qs reviewed Dec 27, 2023

View reviewed changes

libyul/backends/evm/EVMDialect.cpp Show resolved Hide resolved

nikola-matic commented Dec 27, 2023

View reviewed changes

libevmasm/Instruction.cpp Outdated Show resolved Hide resolved

r0qs reviewed Dec 31, 2023

View reviewed changes

docs/cheatsheet.rst Show resolved Hide resolved

cameel reviewed Jan 5, 2024

View reviewed changes

test/EVMHost.cpp Outdated Show resolved Hide resolved

test/libsolidity/syntaxTests/inlineAssembly/blobbasefee_reserved_cancun.sol Outdated Show resolved Hide resolved

test/libsolidity/syntaxTests/types/magic_block_blobbasefee_error.sol Show resolved Hide resolved

cameel force-pushed the bump-evmone-and-evmc-to-11 branch 3 times, most recently from 93b8bfa to d5119f7 Compare January 6, 2024 16:29

Base automatically changed from bump-evmone-and-evmc-to-11 to develop January 6, 2024 18:34

cameel mentioned this pull request Jan 6, 2024

EIP 4844 - blobhash opcode (part 1) #14757

Merged

cameel force-pushed the introduce-blobbasefee branch from 7f52e23 to eddc074 Compare January 6, 2024 21:23

cameel reviewed Jan 8, 2024

View reviewed changes

Changelog.md Show resolved Hide resolved

cameel reviewed Jan 8, 2024

View reviewed changes

test/tools/yulInterpreter/EVMInstructionInterpreter.cpp Show resolved Hide resolved

cameel mentioned this pull request Jan 8, 2024

Introduce transient storage support for inline assembly #14737

Merged

nikola-matic removed the has dependencies The PR depends on other PRs that must be merged first label Jan 9, 2024

nikola-matic force-pushed the introduce-blobbasefee branch from eddc074 to 42da654 Compare January 10, 2024 10:25

nikola-matic marked this pull request as ready for review January 10, 2024 10:25

nikola-matic requested a review from cameel January 10, 2024 10:25

nikola-matic force-pushed the introduce-blobbasefee branch 3 times, most recently from 83c0194 to 984be22 Compare January 10, 2024 11:41

cameel reviewed Jan 10, 2024

View reviewed changes

docs/using-the-compiler.rst Outdated Show resolved Hide resolved

r0qs reviewed Jan 10, 2024

View reviewed changes

test/libsolidity/semanticTests/inlineAssembly/blobbasefee_shanghai_function.sol Outdated Show resolved Hide resolved

nikola-matic force-pushed the introduce-blobbasefee branch from 984be22 to c760bd8 Compare January 11, 2024 10:33

cameel reviewed Jan 11, 2024

View reviewed changes

test/libyul/yulSyntaxTests/blobbasefee_reserved_identifier_post_cancun.sol Show resolved Hide resolved

nikola-matic force-pushed the introduce-blobbasefee branch from c760bd8 to ddfb8fc Compare January 11, 2024 14:35

cameel previously approved these changes Jan 11, 2024

View reviewed changes

docs/units-and-global-variables.rst Show resolved Hide resolved

test/libsolidity/semanticTests/inlineAssembly/blobbasefee_shanghai_function.sol Show resolved Hide resolved

r0qs previously approved these changes Jan 11, 2024

View reviewed changes

test/libyul/yulSyntaxTests/blobbasefee_reserved_identifier_post_cancun.yul Show resolved Hide resolved

nikola-matic mentioned this pull request Jan 11, 2024

SMTChecker support for blobbasefee #14780

Closed

bshastry mentioned this pull request Jan 12, 2024

Yul fuzzer: Introduce basefee() and blobbasefee() builtins #14781

Merged

nikola-matic dismissed stale reviews from r0qs and cameel via f9cf691 January 12, 2024 08:57

cameel approved these changes Jan 12, 2024

View reviewed changes

nikola-matic force-pushed the introduce-blobbasefee branch from 3c8248e to 5dd11c0 Compare January 12, 2024 13:17

Introduce block.blobbasefee in Solidity and blobbasefee in Yul

bf59ff8

nikola-matic force-pushed the introduce-blobbasefee branch from 5dd11c0 to bf59ff8 Compare January 12, 2024 14:44

r0qs reviewed Jan 12, 2024

View reviewed changes

test/libsolidity/ViewPureChecker.cpp Show resolved Hide resolved

nikola-matic merged commit 1473ce2 into develop Jan 12, 2024

nikola-matic deleted the introduce-blobbasefee branch January 12, 2024 15:55

r0qs reviewed Jan 12, 2024

View reviewed changes

scripts/error_codes.py Show resolved Hide resolved

Saw-mon-and-Natalie reviewed Jul 16, 2025

View reviewed changes

		Opcodes marked with ``F``, ``H``, ``B``, ``C``, ``I``, ``L``, ``P`` and ``N`` are present since Frontier,
		Homestead, Byzantium, Constantinople, Istanbul, London, Paris or Cancun respectively.

Conversation

nikola-matic commented Dec 25, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

cameel left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

nikola-matic commented Jan 11, 2024

Uh oh!

cameel commented Jan 11, 2024

Uh oh!

r0qs left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

cameel left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Saw-mon-and-Natalie Jul 16, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

nikola-matic commented Dec 25, 2023 •

edited

Loading