Skip to content

Bump evmc and evmone to v11.0.0#14743

Merged
cameel merged 1 commit intodevelopfrom
bump-evmone-and-evmc-to-11
Jan 6, 2024
Merged

Bump evmc and evmone to v11.0.0#14743
cameel merged 1 commit intodevelopfrom
bump-evmone-and-evmc-to-11

Conversation

@nikola-matic
Copy link
Contributor

@nikola-matic nikola-matic commented Dec 20, 2023 •
edited
Loading

Closes #14744

@nikola-matic nikola-matic added the has dependencies The PR depends on other PRs that must be merged first label Dec 20, 2023
@nikola-matic nikola-matic added this to the 0.8.24 milestone Dec 20, 2023
ekpyron
ekpyron reviewed Dec 20, 2023
View reviewed changes
@ekpyron ekpyron mentioned this pull request Dec 20, 2023
Closed
@nikola-matic nikola-matic force-pushed the bump-evmone-and-evmc-to-11 branch from 02b55b1 to a9fe989 Compare December 22, 2023 09:22
@nikola-matic nikola-matic removed the has dependencies The PR depends on other PRs that must be merged first label Dec 22, 2023
@nikola-matic nikola-matic force-pushed the bump-evmone-and-evmc-to-11 branch from a9fe989 to 48a3a41 Compare December 22, 2023 09:28
@github-actions

This comment was marked as outdated.

Sign in to view
@github-actions

This comment was marked as outdated.

Sign in to view
@github-actions

This comment was marked as outdated.

Sign in to view
@github-actions

This comment was marked as outdated.

Sign in to view
@github-actions

This comment was marked as outdated.

Sign in to view
@github-actions

This comment was marked as outdated.

Sign in to view
@nikola-matic nikola-matic force-pushed the bump-evmone-and-evmc-to-11 branch from af20ce0 to 48a3a41 Compare December 22, 2023 14:25
@github-actions

This comment was marked as outdated.

Sign in to view
@github-actions

This comment was marked as outdated.

Sign in to view
@github-actions

This comment was marked as outdated.

Sign in to view
@nikola-matic nikola-matic force-pushed the bump-evmone-and-evmc-to-11 branch from 48a3a41 to 9160451 Compare December 23, 2023 08:39
@nikola-matic nikola-matic changed the title Bump evmc to v11.0.0 Bump evmc and evmone to v11.0.0 Dec 23, 2023
@argotorg argotorg deleted a comment from Rashann2471 Dec 23, 2023
@github-actions

This comment was marked as outdated.

Sign in to view
@github-actions

This comment was marked as outdated.

Sign in to view
@github-actions

This comment was marked as outdated.

Sign in to view
@github-actions

This comment was marked as outdated.

Sign in to view
@github-actions

This comment was marked as outdated.

Sign in to view
@github-actions

This comment was marked as outdated.

Sign in to view
This was referenced Dec 25, 2023
Merged
Merged
@r0qs r0qs mentioned this pull request Dec 26, 2023
Merged
r0qs
r0qs reviewed Dec 26, 2023
View reviewed changes
Copy link
Member

@r0qs r0qs left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just one comment.

@nikola-matic nikola-matic force-pushed the bump-evmone-and-evmc-to-11 branch from 498252a to 9160451 Compare December 27, 2023 10:57
@nikola-matic nikola-matic mentioned this pull request Dec 27, 2023
Merged
@nikola-matic nikola-matic marked this pull request as ready for review December 27, 2023 11:24
@github-actions

This comment was marked as outdated.

Sign in to view
@github-actions

This comment was marked as outdated.

Sign in to view
@github-actions

This comment was marked as outdated.

Sign in to view
@github-actions

This comment was marked as outdated.

Sign in to view
@github-actions

This comment was marked as outdated.

Sign in to view
@github-actions

This comment was marked as outdated.

Sign in to view
@nikola-matic nikola-matic marked this pull request as draft December 27, 2023 14:44
r0qs
r0qs previously approved these changes Dec 27, 2023
View reviewed changes
Copy link
Member

@r0qs r0qs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm approving this for now so we can keep the progress in the other PRs that depends on it. But we need to keep investigating the ossfuzz CI problem. See https://github.com/ethereum/solidity/pull/14743/files#r1437072163.

@cameel cameel force-pushed the bump-evmone-and-evmc-to-11 branch 2 times, most recently from 97851d8 to 93b8bfa Compare January 6, 2024 16:20
@cameel cameel force-pushed the bump-evmone-and-evmc-to-11 branch from 93b8bfa to d5119f7 Compare January 6, 2024 16:29
@github-actions
Copy link

github-actions bot commented Jan 6, 2024

solbuildpackpusher/solidity-buildpack-deps:ubuntu2204.clang-5 [solbuildpackpusher/solidity-buildpack-deps@sha256:e991421ce9f44d6476b29588fc355da1c3b3fedcc424fd12d844bbe310ad7851].

@github-actions
Copy link

github-actions bot commented Jan 6, 2024

solbuildpackpusher/solidity-buildpack-deps:ubuntu2204-6 [solbuildpackpusher/solidity-buildpack-deps@sha256:6eee10420382588b274374c6a18cb2e5d4f8a9fef5cf440b3a1acfc32bf52837].

@github-actions
Copy link

github-actions bot commented Jan 6, 2024

solbuildpackpusher/solidity-buildpack-deps:ubuntu.clang.ossfuzz-4 [solbuildpackpusher/solidity-buildpack-deps@sha256:b122ef9dca71a8f90b74f3ba13cda4453681506e4a4ff047e7bc2130c76b0d1e].

@github-actions
Copy link

github-actions bot commented Jan 6, 2024

solbuildpackpusher/solidity-buildpack-deps:ubuntu2004-21 [solbuildpackpusher/solidity-buildpack-deps@sha256:6f64c7b35aabddb416d28f621a3c4bbae768c257d6866f6a7f05f8225acc94f0].

@cameel
Copy link
Collaborator

cameel commented Jan 6, 2024

Looks like there's already evmc 11.0.1. The diff with 11.0.0 shows that the changes are limited to its build system. I copied over the relevant files locally and there were no changes so this PR technically covers 11.0.1 too.

@cameel cameel marked this pull request as ready for review January 6, 2024 18:33
@cameel cameel merged commit e08da86 into develop Jan 6, 2024
@cameel cameel deleted the bump-evmone-and-evmc-to-11 branch January 6, 2024 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ekpyron ekpyron ekpyron left review comments

@cameel cameel cameel approved these changes

@r0qs r0qs r0qs left review comments

Assignees

No one assigned

Labels

testing 🔨

Projects

None yet

Milestone

0.8.24

Development

Successfully merging this pull request may close these issues.

Bump evmone/evmc to version 11.0.0 for Cancun support

4 participants

@nikola-matic @cameel @r0qs @ekpyron