Conversation
axic
reviewed
May 10, 2023
| // test() -> 5, 10 | ||
| // gas irOptimized: 87337 | ||
| // gas legacy: 102637 | ||
| // gas legacy: 102651 |
Contributor
There was a problem hiding this comment.
Hm, why did the gas change in all these files?
Contributor
There was a problem hiding this comment.
But those costs dint change in shanghai.
Collaborator
Author
There was a problem hiding this comment.
Well, something must have changed in evmone regarding it - wouldn't see it as a cause for worrying.
Collaborator
Author
There was a problem hiding this comment.
For the record: isn't this probably just https://eips.ethereum.org/EIPS/eip-3860 that may not have been implemented in evmone before? To be honest, not entirely sure who does the accounting there, though, without checking.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Switches to the images built in #14199 and bumps the evmone version whereever else it's left for bumping.