Notification Self Service Namespaced Config#191
Merged
Conversation
At the time of making this commit, the package `github.com/ghodss/yaml` is no longer actively maintained. `sigs.k8s.io/yaml` is a permanent fork of `ghodss/yaml` and is actively maintained by Kubernetes SIG. Reference: argoproj/argo-cd#13292 (comment) Signed-off-by: Eng Zer Jun <engzerjun@gmail.com> Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
Signed-off-by: Eric Tendian <erictendian@gmail.com>
zachaller
changed the title
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #191 +/- ##
==========================================
+ Coverage 53.53% 53.57% +0.03%
==========================================
Files 34 34
Lines 3026 3091 +65
==========================================
+ Hits 1620 1656 +36
- Misses 1166 1188 +22
- Partials 240 247 +7
☔ View full report in Codecov by Sentry. |
Signed-off-by: zachaller <zachaller@users.noreply.github.com>
Signed-off-by: zachaller <zachaller@users.noreply.github.com>
Signed-off-by: zachaller <zachaller@users.noreply.github.com>
…gine into self-service-zaller
mayzhang2000
reviewed
Jul 6, 2023
Signed-off-by: zachaller <zachaller@users.noreply.github.com>
Signed-off-by: zachaller <zachaller@users.noreply.github.com>
Signed-off-by: zachaller <zachaller@users.noreply.github.com>
Signed-off-by: zachaller <zachaller@users.noreply.github.com>
Signed-off-by: zachaller <zachaller@users.noreply.github.com>
| } | ||
| return f.api, nil | ||
|
|
||
| if len(errors) > 0 { |
Contributor
There was a problem hiding this comment.
Reminder to myself: need to discuss this with you.
…gine into self-service-zaller
zachaller
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for notification engine to be able to pull it's config maps and secret information from multiple namespaces. The main driver is this is in argo rollouts we want to enable a self service model to notifications. This PR will allow argo rollouts to have notification configuration live both in the namespace of the rollouts object and the controller. It will run both notification configs.