chore: replace github.com/ghodss/yaml with sigs.k8s.io/yaml#175
Merged
zachaller merged 2 commits intoargoproj:masterfrom May 5, 2023
Juneezee:chore/yaml
Merged
chore: replace github.com/ghodss/yaml with sigs.k8s.io/yaml#175zachaller merged 2 commits intoargoproj:masterfrom Juneezee:chore/yaml
github.com/ghodss/yaml with sigs.k8s.io/yaml#175zachaller merged 2 commits intoargoproj:masterfrom
Juneezee:chore/yaml
Conversation
At the time of making this commit, the package `github.com/ghodss/yaml` is no longer actively maintained. `sigs.k8s.io/yaml` is a permanent fork of `ghodss/yaml` and is actively maintained by Kubernetes SIG. Reference: argoproj/argo-cd#13292 (comment) Signed-off-by: Eng Zer Jun <engzerjun@gmail.com>
13 tasks
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## master #175 +/- ##
=======================================
Coverage 52.90% 52.90%
=======================================
Files 33 33
Lines 2807 2807
=======================================
Hits 1485 1485
Misses 1101 1101
Partials 221 221
☔ View full report in Codecov by Sentry. |
Contributor
Author
|
Hi @zachaller, would you mind taking a few minutes to review this PR too? Thanks 😃 |
zachaller
approved these changes
May 5, 2023
mayzhang2000
pushed a commit
that referenced
this pull request
May 9, 2023
At the time of making this commit, the package `github.com/ghodss/yaml` is no longer actively maintained. `sigs.k8s.io/yaml` is a permanent fork of `ghodss/yaml` and is actively maintained by Kubernetes SIG. Reference: argoproj/argo-cd#13292 (comment) Signed-off-by: Eng Zer Jun <engzerjun@gmail.com> Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
zachaller
added a commit
that referenced
this pull request
Jul 12, 2023
* self-service from event * chore: replace github.com/ghodss/yaml with sigs.k8s.io/yaml (#175) At the time of making this commit, the package `github.com/ghodss/yaml` is no longer actively maintained. `sigs.k8s.io/yaml` is a permanent fork of `ghodss/yaml` and is actively maintained by Kubernetes SIG. Reference: argoproj/argo-cd#13292 (comment) Signed-off-by: Eng Zer Jun <engzerjun@gmail.com> Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> * feat: Adding new PagerDuty integration based on Events API v2 (#105) Signed-off-by: Eric Tendian <erictendian@gmail.com> * self-service from event * self-service from event * self-service from event * self-service from event * self-service from event * clean up factory.go * error handleing in factory.go * error handleing in factory.go * error handleing in factory.go * error handleing in factory.go * error handleing in factory.go * error handleing in factory.go * error handleing in factory.go * better caching * better caching * refactor Signed-off-by: zachaller <zachaller@users.noreply.github.com> * unused Signed-off-by: zachaller <zachaller@users.noreply.github.com> * lint Signed-off-by: zachaller <zachaller@users.noreply.github.com> * bump ci Signed-off-by: zachaller <zachaller@users.noreply.github.com> * small fixes Signed-off-by: zachaller <zachaller@users.noreply.github.com> * rename Signed-off-by: zachaller <zachaller@users.noreply.github.com> * rename Signed-off-by: zachaller <zachaller@users.noreply.github.com> * rename Signed-off-by: zachaller <zachaller@users.noreply.github.com> * change log line Signed-off-by: zachaller <zachaller@users.noreply.github.com> * update tests Signed-off-by: zachaller <zachaller@users.noreply.github.com> * continue on error Signed-off-by: zachaller <zachaller@users.noreply.github.com> * continue on errors Signed-off-by: zachaller <zachaller@users.noreply.github.com> * add godoc Signed-off-by: zachaller <zachaller@users.noreply.github.com> * continue on error Signed-off-by: zachaller <zachaller@users.noreply.github.com> * fix error by going back to non namespace support Signed-off-by: zachaller <zachaller@users.noreply.github.com> * fix log Signed-off-by: zachaller <zachaller@users.noreply.github.com> * improve log on error Signed-off-by: zachaller <zachaller@users.noreply.github.com> --------- Signed-off-by: Eng Zer Jun <engzerjun@gmail.com> Signed-off-by: Eric Tendian <erictendian@gmail.com> Signed-off-by: zachaller <zachaller@users.noreply.github.com> Co-authored-by: May Zhang <may_zhang@intuit.com> Co-authored-by: Eng Zer Jun <engzerjun@gmail.com> Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Co-authored-by: Eric Tendian <erictendian@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Originally posted by @blakepettersson in argoproj/argo-cd#13292 (comment)
This PR is part of argoproj/argo-cd#13292 to completely replace
github.com/ghodss.yamlwithsigs.k8s.io/yaml.