Conversation
blakepettersson
force-pushed
the
update-namespace-v2
branch
from
778b02f to
e08d550
Compare
Codecov ReportBase: 55.46% // Head: 55.66% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #465 +/- ##
==========================================
+ Coverage 55.46% 55.66% +0.19%
==========================================
Files 41 41
Lines 4504 4513 +9
==========================================
+ Hits 2498 2512 +14
+ Misses 1813 1807 -6
- Partials 193 194 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
@blakepettersson Tks for working on this feature! |
blakepettersson
force-pushed
the
update-namespace-v2
branch
from
13195b6 to
4d1224f
Compare
It's been well overdue for me to add the git hook, now I've done that 😄 |
…created … (argoproj#455)" This reverts commit ce2fb70. Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com>
blakepettersson
force-pushed
the
update-namespace-v2
branch
4 times, most recently
from
97ccb81 to
954df91
Compare
leoluz
left a comment
leoluz
left a comment
There was a problem hiding this comment.
Added a few more comments.
I think we are close to get this PR ready. Tks!
Rename `WithNamespaceCreation` to `WithNamespaceModifier`, since this method is also used for modifying existing namespaces. This method takes a single argument for the actual updating, and unless this method gets invoked by its caller no updating will take place (fulfilling what the `createNamespace` argument used to do). Within `autoCreateNamespace`, everywhere where we previously added tasks we'll now need to check whether the namespace should be created (or modified), which is now delegated to the `appendNsTask` and `appendFailedNsTask` methods. Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com>
blakepettersson
force-pushed
the
update-namespace-v2
branch
from
48f686d to
57f0dd2
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
leoluz
left a comment
leoluz
left a comment
There was a problem hiding this comment.
LGTM
Thank you for the hard work!
|
This PR introduces a breaking change in current Argo CD master. To avoid possible build issues this should be merged together with argoproj/argo-cd#10672 |
3 participants
Rename
WithNamespaceCreationtoWithNamespaceModifier, since thismethod is also used for modifying existing namespaces. This method
takes a single argument for the actual updating, and unless this method
gets invoked by its caller no updating will take place (fulfilling what
the
createNamespaceargument used to do).Within
autoCreateNamespace, everywhere where we previously added taskswe'll now need to check whether the namespace should be created (or
modified), which is now delegated to the
appendNsTaskandappendFailedNsTaskmethods.