This repository was archived by the owner on Dec 17, 2025. It is now read-only.
Revert "feat: Ability to create custom labels for namespaces created …#455
Merged
leoluz merged 4 commits intoargoproj:masterfrom Aug 23, 2022
Merged
Conversation
…with syncOptions CreateNamespace (argoproj#443)" This reverts commit a56a803.
Signed-off-by: pashavictorovich <pavel@codefresh.io>
|
Kudos, SonarCloud Quality Gate passed!
|
Codecov Report
@@ Coverage Diff @@
## master #455 +/- ##
==========================================
- Coverage 55.47% 55.42% -0.06%
==========================================
Files 41 41
Lines 4472 4469 -3
==========================================
- Hits 2481 2477 -4
- Misses 1802 1803 +1
Partials 189 189
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
leoluz
approved these changes
Aug 23, 2022
blakepettersson
added a commit
to blakepettersson/gitops-engine
that referenced
this pull request
Sep 20, 2022
…created … (argoproj#455)" This reverts commit ce2fb70.
blakepettersson
added a commit
to blakepettersson/gitops-engine
that referenced
this pull request
Sep 22, 2022
…created … (argoproj#455)" This reverts commit ce2fb70. Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com>
blakepettersson
added a commit
to blakepettersson/gitops-engine
that referenced
this pull request
Oct 4, 2022
…created … (argoproj#455)" This reverts commit ce2fb70. Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com>
leoluz
pushed a commit
that referenced
this pull request
Nov 3, 2022
* Revert "Revert "feat: Ability to create custom labels for namespaces created … (#455)" This reverts commit ce2fb70. Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com> * feat: enable namespace to be updated Rename `WithNamespaceCreation` to `WithNamespaceModifier`, since this method is also used for modifying existing namespaces. This method takes a single argument for the actual updating, and unless this method gets invoked by its caller no updating will take place (fulfilling what the `createNamespace` argument used to do). Within `autoCreateNamespace`, everywhere where we previously added tasks we'll now need to check whether the namespace should be created (or modified), which is now delegated to the `appendNsTask` and `appendFailedNsTask` methods. Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com> Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…with syncOptions CreateNamespace (#443)"
This reverts commit a56a803.