feature: add methods to get annotations#121
feature: add methods to get annotations#121darshanime wants to merge 2 commits intoargoproj:masterfrom
Conversation
Signed-off-by: darshanime <deathbullet@gmail.com>
1ee1bd7 to
d608b9c
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #121 +/- ##
==========================================
+ Coverage 55.91% 56.10% +0.19%
==========================================
Files 25 25
Lines 2722 2727 +5
==========================================
+ Hits 1522 1530 +8
+ Misses 1053 1050 -3
Partials 147 147 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: darshanime <deathbullet@gmail.com>
|
Kudos, SonarCloud Quality Gate passed!
|
| @@ -129,10 +129,21 @@ func MustToUnstructured(obj interface{}) *unstructured.Unstructured { | |||
|
|
|||
| // GetAppInstanceLabel returns the application instance name from labels | |||
| func GetAppInstanceLabel(un *unstructured.Unstructured, key string) string { | |||
There was a problem hiding this comment.
@darshanime , looks like GetAppInstanceLabel is not used in GitOps engine. Instead of making changes here please move GetAppInstanceIdentifier with dependencies to argoproj/argo-cd#4123 and then we can remove GetAppInstanceLabel from GitOps engine.
|
(closing as i wont be able to get back to it anytime soon) |
Signed-off-by: darshanime deathbullet@gmail.com
required for argoproj/argo-cd#4123