Skip to content
This repository was archived by the owner on Dec 17, 2025. It is now read-only.

feature: add methods to get annotations#121

Closed
darshanime wants to merge 2 commits intoargoproj:masterfrom
darshanime:annotations
Closed

feature: add methods to get annotations#121
darshanime wants to merge 2 commits intoargoproj:masterfrom
darshanime:annotations

Conversation

@darshanime
Copy link
Member

Signed-off-by: darshanime deathbullet@gmail.com

required for argoproj/argo-cd#4123

Signed-off-by: darshanime <deathbullet@gmail.com>
@codecov-commenter
Copy link

codecov-commenter commented Aug 19, 2020

Codecov Report

Attention: Patch coverage is 87.50000% with 1 line in your changes missing coverage. Please review.

Project coverage is 56.10%. Comparing base (90979fe) to head (37f583d).
Report is 228 commits behind head on master.

Files with missing lines Patch % Lines
pkg/utils/kube/kube.go 87.50% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #121      +/-   ##
==========================================
+ Coverage   55.91%   56.10%   +0.19%     
==========================================
  Files          25       25              
  Lines        2722     2727       +5     
==========================================
+ Hits         1522     1530       +8     
+ Misses       1053     1050       -3     
  Partials      147      147              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Signed-off-by: darshanime <deathbullet@gmail.com>
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@@ -129,10 +129,21 @@ func MustToUnstructured(obj interface{}) *unstructured.Unstructured {

// GetAppInstanceLabel returns the application instance name from labels
func GetAppInstanceLabel(un *unstructured.Unstructured, key string) string {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@darshanime , looks like GetAppInstanceLabel is not used in GitOps engine. Instead of making changes here please move GetAppInstanceIdentifier with dependencies to argoproj/argo-cd#4123 and then we can remove GetAppInstanceLabel from GitOps engine.

@darshanime
Copy link
Member Author

(closing as i wont be able to get back to it anytime soon)

@darshanime darshanime closed this Apr 16, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants