feature: use annotation for app name if longer than max len

[darshanime]

Signed-off-by: darshanime deathbullet@gmail.com

closes #4045
blocked on argoproj/gitops-engine#121

Checklist:

• Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
• The title of the PR states what changed and the related issues number (used for the release note).
• I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
• Optional. My organization is added to USERS.md.
• I've signed the CLA and my build is green (troubleshooting builds).

[sbose78]

@darshanime Could you update the PR description with the annotation you are proposing ?

[NargiT]

any update on this?

[mayzhang2000]

@darshanime, please let me know when this is ready to be reviewed. Thank you.

[alexmt]

Please see comment in argoproj/gitops-engine#121 (comment)

Instead of using GetAppInstanceIdentifier from gitops engine let's move it into Argo CD repo.

[alexmt]

Annotation is preferable in some other cases, not only when the application name is too long.

Instead of automatically switching to annotation let's introduce an application-level setting that allows switching from label to annotation. I would suggest using the argocd.argoproj.io/annotation-marker annotation . E.g. if application has argocd.argoproj.io/annotation-marker annotation then argocd should make resources with annotation:

apiVersion: argoproj.io/v1alpha1
kind: Application
metadata:
  name: guestbook
  annotations:
    # instruct argocd to use annotation instead of label
    argocd.argoproj.io/annotation-marker: 'true'

[alexmt]

Please make sure to check for annotation and label in

argo-cd/controller/cache/cache.go

Line 259 in 422a26e

appName := kube.GetAppInstanceLabel(un, cacheSettings.appInstanceLabelKey)

Controller should cache whole resource manifest if either annotation or label present.

[NargiT]

hello any updates for this ?

[alexmt]

The same changes were implemented by #7251