fix(controller): TestPodExists unit test#6763
Merged
alexec merged 1 commit intoargoproj:masterfrom Sep 20, 2021
Merged
Conversation
b59abf8 to
ab49095
Compare
Codecov Report
@@ Coverage Diff @@
## master #6763 +/- ##
==========================================
- Coverage 48.64% 48.60% -0.04%
==========================================
Files 264 264
Lines 19076 19076
==========================================
- Hits 9279 9272 -7
- Misses 8752 8762 +10
+ Partials 1045 1042 -3
Continue to review full report at Codecov.
|
Signed-off-by: Tianchu Zhao <evantczhao@gmail.com>
d1198d7 to
deba156
Compare
alexec
approved these changes
Sep 20, 2021
kriti-sc
pushed a commit
to kriti-sc/argo-workflows
that referenced
this pull request
Oct 24, 2021
Signed-off-by: Tianchu Zhao <evantczhao@gmail.com> Signed-off-by: kriti-sc <kathuriakriti1@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Recent PR #6712 Added TestPodExists
the code is fine, runs well in local machine but somehow in github ci, it fails very often
#6753 https://github.com/argoproj/argo-workflows/runs/3632323865?check_suite_focus=true
#6749 https://github.com/argoproj/argo-workflows/runs/3627112929?check_suite_focus=true
I tested using
They indeed show the same value in github CI
but using
woc.podExists(pod.Name)just failschanging to
woc.podExists(pod.ObjectMeta.Name)seems to solve the issueTips:
git commit --signoff.make pre-commit -Bto fix codegen or lint problems.