Skip to content

fix(controller): respect template archivelocation-archivelog behaviour#6753

Closed
tczhao wants to merge 0 commit intoargoproj:masterfrom
tczhao:feature/fix-template-archivelog
Closed

fix(controller): respect template archivelocation-archivelog behaviour#6753
tczhao wants to merge 0 commit intoargoproj:masterfrom
tczhao:feature/fix-template-archivelog

Conversation

@tczhao
Copy link
Member

@tczhao tczhao commented Sep 17, 2021

Tips:

  • Maybe add you organization to USERS.md.
  • Your PR needs to pass the required checks before it can be approved. If the check is not required (e.g. E2E tests) it does not need to pass
  • Sign-off your commits to pass the DCO check: git commit --signoff.
  • Run make pre-commit -B to fix codegen or lint problems.
  • Say how how you tested your changes. If you changed the UI, attach screenshots.
  • If changes were requested, and you've made them, then dismis the review to get it looked at again.
  • You can ask for help!

@codecov
Copy link

codecov bot commented Sep 17, 2021

Codecov Report

Merging #6753 (90967fb) into master (7684ef4) will increase coverage by 0.00%.
The diff coverage is 72.72%.

❗ Current head 90967fb differs from pull request most recent head bec713e. Consider uploading reports for the commit bec713e to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master    #6753   +/-   ##
=======================================
  Coverage   48.64%   48.65%           
=======================================
  Files         264      264           
  Lines       19076    19083    +7     
=======================================
+ Hits         9279     9284    +5     
- Misses       8752     8753    +1     
- Partials     1045     1046    +1     
Impacted Files Coverage Δ
workflow/controller/workflowpod.go 73.78% <25.00%> (-0.30%) ⬇️
...pis/workflow/v1alpha1/artifact_repository_types.go 98.14% <100.00%> (+0.14%) ⬆️
server/artifacts/artifact_server.go 64.66% <100.00%> (ø)
cmd/argoexec/commands/emissary.go 50.35% <0.00%> (-1.44%) ⬇️
workflow/controller/operator.go 71.11% <0.00%> (-0.10%) ⬇️
cmd/argo/commands/get.go 59.76% <0.00%> (+1.45%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7684ef4...bec713e. Read the comment docs.

@tczhao tczhao force-pushed the feature/fix-template-archivelog branch 4 times, most recently from 90967fb to bec713e Compare September 17, 2021 12:28
@tczhao tczhao closed this Sep 17, 2021
@tczhao tczhao force-pushed the feature/fix-template-archivelog branch from bec713e to 7684ef4 Compare September 17, 2021 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant