fix: Avoid resetting resourceVersion for watch. Fixes #15106#15107
Merged
Joibel merged 1 commit intoargoproj:mainfrom Jan 2, 2026
Merged
fix: Avoid resetting resourceVersion for watch. Fixes #15106#15107Joibel merged 1 commit intoargoproj:mainfrom
Joibel merged 1 commit intoargoproj:mainfrom
Conversation
Member
|
Interesting, and thank you. Could you sign the DCO so we can merge this? |
Member
|
@JackTroy, could you sign the DCO so we can merge this please? |
Contributor
Author
|
@Joibel Thank you for noticing. I've done cto and re-pushed my commit |
Member
|
/retest |
Member
|
@JackTroy your commit signature and author don't match, so DCO is not accepting it: |
Signed-off-by: jackcui <jackcui@tencent.com>
Contributor
Author
|
@eduardodbr Resign by running |
Joibel
approved these changes
Jan 2, 2026
Member
|
Thanks @JackTroy |
|
🍒 Cherry-pick PR created for 3.7: #15207 |
|
🍒 Cherry-pick PR created for 3.6: #15206 |
This was referenced Jan 7, 2026
MasonM
pushed a commit
to MasonM/argo-workflows
that referenced
this pull request
Jan 20, 2026
…(cherry-pick argoproj#15107 for 3.7) (argoproj#15207) Signed-off-by: jackcui <jackcui@tencent.com> Co-authored-by: Jack Cui <691729768@qq.com>
MasonM
pushed a commit
to MasonM/argo-workflows
that referenced
this pull request
Jan 20, 2026
…(cherry-pick argoproj#15107 for 3.6) (argoproj#15206) Signed-off-by: jackcui <jackcui@tencent.com> Co-authored-by: Jack Cui <691729768@qq.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes Avoid resetting resourceVersion for watch. Fixes #15106
Modifications
Check resourceVersion before resetting to avoid setting to "" for watch connection
Verification
No repeated error in #15106 after fix.