chore: upgrade golangci-lint to v1.46.2

[cippaciong]

Because:

• Installation of golangci-lint v1.45.2 is currently broken and fails
  silently due to a redacted dependency
  (Checksum mismatch in go sumdb blizzy78/varnamelen#13)

This commit:

• Upgrades golangci-lint to v1.46.2

Checklist:

• Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
• The title of the PR states what changed and the related issues number (used for the release note).
• I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
• I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
• Does this PR require documentation updates?
• I've updated documentation as required by this PR.
• Optional. My organization is added to USERS.md.
• I have signed off all my commits as required by DCO
• I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
• My build is green (troubleshooting builds).

[codecov]

Codecov Report

Merging #9448 (88609b6) into master (a809469) will increase coverage by 0.12%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #9448      +/-   ##
==========================================
+ Coverage   45.66%   45.79%   +0.12%     
==========================================
  Files         220      220              
  Lines       26232    26197      -35     
==========================================
+ Hits        11979    11996      +17     
+ Misses      12599    12547      -52     
  Partials     1654     1654              

Impacted Files	Coverage Δ
server/server.go	55.11% <ø> (ø)
pkg/apiclient/apiclient.go	0.68% <0.00%> (-0.13%)	⬇️
pkg/apiclient/grpcproxy.go	0.00% <0.00%> (ø)
server/badge/badge.go	84.28% <0.00%> (+2.28%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a809469...88609b6. Read the comment docs.

[crenshaw-dev]

@cippaciong cherry-picking this (#9444) should fix three of those issues. The other two might require additional attention.

[cippaciong]

@crenshaw-dev I cherry picked the commit from your fork and indeed three issues were fixed. Not sure how to address the other two though, any suggestion? Should I take care of that in this PR?

[crenshaw-dev]

@cippaciong yeah let's try to get it fixed in this PR if you have time. Just run make lint-local. The command will print the locations of the issues and give a short description. The fixes should be reasonably clear from the error messages.

[cippaciong]

@crenshaw-dev the two missing issues have been fixed. For S1023 I removed the superfluous return statement, while for SA1029 I added a // nolint:staticcheck comment because I found it multiple times in the rest code.

I also replaced go get with go install to install golangci-lint.

Let me know if it looks good or if there is anything else I should change 🙂

[crenshaw-dev]

@cippaciong thanks! Looks like the last commit needs to be signed. I'm going to kick off the integration tests again. Hopefully just a flaky test.

[cippaciong]

@crenshaw-dev woops, signed it :)

[Aym3nTN]

@cippaciong @crenshaw-dev I noticed that pipelines after this one are failing when performing race testing, is that the case or am I missing something?
Here's my failing PR #9462

[crenshaw-dev]

@Aym3nTN just merged a fix: #9469

[crenshaw-dev]

Cherry-picked onto 2.3.

[crenshaw-dev]

Cherry-picked onto 2.2.