chore: update golangci-lint by crenshaw-dev · Pull Request #8988 · argoproj/argo-cd

crenshaw-dev · 2022-04-04T16:05:22Z

Just a bit of cleanup/maintenance.

The linter revealed a bug, so I wrote unit tests.

Signed-off-by: Michael Crenshaw <michael@crenshaw.dev>

codecov · 2022-04-04T16:53:29Z

Codecov Report

Merging #8988 (abfdffb) into master (a5933db) will increase coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #8988      +/-   ##
==========================================
+ Coverage   45.00%   45.01%   +0.01%     
==========================================
  Files         212      212              
  Lines       25272    25272              
==========================================
+ Hits        11373    11377       +4     
+ Misses      12292    12291       -1     
+ Partials     1607     1604       -3

Impacted Files	Coverage Δ
util/io/bytereadseeker.go	`100.00% <ø> (+100.00%)`	⬆️
applicationset/services/scm_provider/github.go	`63.52% <0.00%> (-17.65%)`	⬇️
applicationset/services/scm_provider/utils.go	`88.50% <0.00%> (+4.59%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a5933db...abfdffb. Read the comment docs.

Signed-off-by: Michael Crenshaw <michael@crenshaw.dev>

util/io/bytereadseeker.go

Signed-off-by: Michael Crenshaw <michael@crenshaw.dev>

alexmt

LGTM

* chore: update golangci-lint Signed-off-by: Michael Crenshaw <michael@crenshaw.dev> Signed-off-by: asingh51 <Ashutosh_Singh@intuit.com>

* chore: update golangci-lint Signed-off-by: Michael Crenshaw <michael@crenshaw.dev> Signed-off-by: wojtekidd <wojtek.cichon@protonmail.com>

* chore: update golangci-lint Signed-off-by: Michael Crenshaw <michael@crenshaw.dev>

crenshaw-dev · 2022-06-13T20:55:57Z

Cherry-picked onto 2.3.

* chore: update golangci-lint Signed-off-by: Michael Crenshaw <michael@crenshaw.dev>

crenshaw-dev · 2022-06-13T21:59:26Z

Cherry-picked onto 2.2.

* chore: update golangci-lint Signed-off-by: Michael Crenshaw <michael@crenshaw.dev>

* fix(ui): Applications page incorrectly resets to tiles view. Fixes argoproj#8702 (argoproj#8718) Signed-off-by: Yuan Tang <terrytangyuan@gmail.com> * fix: correct jsonnet paths resolution (argoproj#8721) Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> * chore: Bump stable version of application set addon (argoproj#8744) Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> * fix: Retry checkbox unchecked unexpectedly; Sync up with YAML (argoproj#8682) (argoproj#8720) Signed-off-by: Keith Chong <kykchong@redhat.com> * Bump version to 2.3.1 * Bump version to 2.3.1 * Merge pull request from GHSA-2f5v-8r3f-8pww * fix: application resource APIs must enforce project restrictions Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> * Fix unit tests Signed-off-by: jannfis <jann@mistrust.net> Co-authored-by: jannfis <jann@mistrust.net> * chore: remove lint-docs CI task (argoproj#8722) (argoproj#8858) * chore: remove lint-docs CI task Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> * chore: remove not longer necessary url-allow-list Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> Co-authored-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> * chore: fix imports (argoproj#8859) Signed-off-by: Michael Crenshaw <michael@crenshaw.dev> * Bump version to 2.3.2 * Bump version to 2.3.2 * fix: Set QPS and burst rate for resource ops client (argoproj#8915) * fix: Set QPS and burst rate for resource ops client Signed-off-by: jannfis <jann@mistrust.net> * fix: prevent excessive repo-server disk usage for large repos (argoproj#8845) (argoproj#8897) fix: prevent excessive repo-server disk usage for large repos (argoproj#8845) (argoproj#8897) Signed-off-by: Michael Crenshaw <michael@crenshaw.dev> * fix: bump gitops engine version to v0.6.2 Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> * docs: update v2.4+ roadmap items (argoproj#8593) Signed-off-by: ishitasequeira <isequeir@redhat.com> * docs: reflect v2.3 release changes in roadmap.md (argoproj#8747) docs: reflect v2.3 release changes in roadmap.md (argoproj#8747) Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> * Bump version to 2.3.3 * Bump version to 2.3.3 * fix: Fix docs build error (argoproj#8895) * work with specific jinja version Signed-off-by: pashavictorovich <pavel@codefresh.io> * fix: fix broken monaco editor collapse icons (argoproj#8709) Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> * chore: upgrade to go 1.17.8 (argoproj#8866) (argoproj#9004) * chore: upgrade to go 1.17.8 Signed-off-by: Michael Crenshaw <michael@crenshaw.dev> * chore: use 1.17 so it's always latest in the series Signed-off-by: Michael Crenshaw <michael@crenshaw.dev> * fix: allow cli/ui to follow logs (argoproj#8987) (argoproj#9065) Signed-off-by: Daniel Helfand <helfand.4@gmail.com> * Merge pull request from GHSA-xmg8-99r8-jc2j Signed-off-by: Michael Crenshaw <michael@crenshaw.dev> Co-authored-by: Michael Crenshaw <michael@crenshaw.dev> * Merge pull request from GHSA-6gcg-hp2x-q54h * fix: do not allow symlinks from directory-type applications Signed-off-by: Michael Crenshaw <michael@crenshaw.dev> * chore: add new util file Signed-off-by: Michael Crenshaw <michael@crenshaw.dev> * chore: lint Signed-off-by: Michael Crenshaw <michael@crenshaw.dev> * chore: use t.TempDir for simpler tests Signed-off-by: Michael Crenshaw <michael@crenshaw.dev> * address comments Signed-off-by: Michael Crenshaw <michael@crenshaw.dev> * Merge pull request from GHSA-r642-gv9p-2wjj Signed-off-by: jannfis <jann@mistrust.net> Co-authored-by: Michael Crenshaw <michael@crenshaw.dev> Co-authored-by: Michael Crenshaw <michael@crenshaw.dev> * Bump version to 2.3.4 * Bump version to 2.3.4 * test: fix ErrorContains (argoproj#9445) Signed-off-by: Michael Crenshaw <michael@crenshaw.dev> * fix: missing Helm params (argoproj#9565) (argoproj#9566) * fix: missing Helm params Signed-off-by: Michael Crenshaw <michael@crenshaw.dev> * use absolute paths, fix tests Signed-off-by: Michael Crenshaw <michael@crenshaw.dev> * fix race in test Signed-off-by: Michael Crenshaw <michael@crenshaw.dev> * chore: upgrade golangci-lint to v1.46.2 (argoproj#9448) * chore: upgrade golangci-lint to v1.46.2 Because: * Installation of golangci-lint v1.45.2 is currently broken and fails silently due to a redacted dependency (blizzy78/varnamelen#13) This commit: * Upgrades golangci-lint to v1.46.2 Signed-off-by: Tommaso Sardelli <lacapannadelloziotom@gmail.com> * fix: lint Signed-off-by: Michael Crenshaw <michael@crenshaw.dev> * fix: lint Signed-off-by: Tommaso Sardelli <lacapannadelloziotom@gmail.com> Co-authored-by: Michael Crenshaw <michael@crenshaw.dev> Signed-off-by: Michael Crenshaw <michael@crenshaw.dev> * fix: test race (argoproj#9469) Signed-off-by: Michael Crenshaw <michael@crenshaw.dev> * chore: lint issues Signed-off-by: Michael Crenshaw <michael@crenshaw.dev> * chore: update golangci-lint (argoproj#8988) * chore: update golangci-lint Signed-off-by: Michael Crenshaw <michael@crenshaw.dev> * chore: remove obsolete repo-server unit test (argoproj#9559) Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> * chore: Make unit tests run on platforms other than amd64 (argoproj#8995) Signed-off-by: jannfis <jann@mistrust.net> Co-authored-by: Michael Crenshaw <michael@crenshaw.dev> Signed-off-by: Michael Crenshaw <michael@crenshaw.dev> * chore: eliminate go-mpatch dependency (argoproj#9045) * chore: eliminate go-mpatch dependency Signed-off-by: Michael Crenshaw <michael@crenshaw.dev> * chore: abstract out resource list function Signed-off-by: Michael Crenshaw <michael@crenshaw.dev> * chore: don't exit the program in anything but the main function Signed-off-by: Michael Crenshaw <michael@crenshaw.dev> * chore: better error messages Signed-off-by: Michael Crenshaw <michael@crenshaw.dev> * chore: better error messages Signed-off-by: Michael Crenshaw <michael@crenshaw.dev> * test: directory app manifest generation (argoproj#9503) * test: directory app manifest generation Signed-off-by: Michael Crenshaw <michael@crenshaw.dev> * git doesn't support empty dirs Signed-off-by: Michael Crenshaw <michael@crenshaw.dev> * Merge pull request from GHSA-h4w9-6x78-8vrj Signed-off-by: Michael Crenshaw <michael@crenshaw.dev> * Merge pull request from GHSA-2m7h-86qq-fp4v Signed-off-by: Michael Crenshaw <michael@crenshaw.dev> fix references Signed-off-by: Michael Crenshaw <michael@crenshaw.dev> use long enough state param for oauth2 Signed-off-by: Michael Crenshaw <michael@crenshaw.dev> typo Signed-off-by: Michael Crenshaw <michael@crenshaw.dev> more entropy Signed-off-by: Michael Crenshaw <michael@crenshaw.dev> fix test Signed-off-by: Michael Crenshaw <michael@crenshaw.dev> * Merge pull request from GHSA-q4w5-4gq2-98vm Signed-off-by: Michael Crenshaw <michael@crenshaw.dev> * Merge pull request from GHSA-jhqp-vf4w-rpwq Signed-off-by: Michael Crenshaw <michael@crenshaw.dev> defer instead of multiple close calls Signed-off-by: Michael Crenshaw <michael@crenshaw.dev> oops Signed-off-by: Michael Crenshaw <michael@crenshaw.dev> don't count jsonnet against max Signed-off-by: Michael Crenshaw <michael@crenshaw.dev> fix codegen Signed-off-by: Michael Crenshaw <michael@crenshaw.dev> add caveat about 300x ratio Signed-off-by: Michael Crenshaw <michael@crenshaw.dev> fix versions Signed-off-by: Michael Crenshaw <michael@crenshaw.dev> fix tests/lint Signed-off-by: Michael Crenshaw <michael@crenshaw.dev> * chore: fix docs gen Signed-off-by: Michael Crenshaw <michael@crenshaw.dev> * Bump version to 2.3.5 * Bump version to 2.3.5 * docs: Changes for v2.3.5 Documented key decision factors to use Argo CD v2.3.5. Contributes to: automation-saas/automation-saas/native-AWS#1972 Signed-off-by: Sujeily Fonseca <sujeily.fonseca@ibm.com> Co-authored-by: Yuan Tang <terrytangyuan@gmail.com> Co-authored-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> Co-authored-by: Keith Chong <kykchong@redhat.com> Co-authored-by: argo-bot <argoproj@gmail.com> Co-authored-by: jannfis <jann@mistrust.net> Co-authored-by: Michael Crenshaw <michael@crenshaw.dev> Co-authored-by: Ishita Sequeira <46771830+ishitasequeira@users.noreply.github.com> Co-authored-by: pasha-codefresh <pavel@codefresh.io> Co-authored-by: Daniel Helfand <helfand.4@gmail.com> Co-authored-by: Tommaso Sardelli <lacapannadelloziotom@gmail.com>

crenshaw-dev added 3 commits April 4, 2022 12:05

chore: update golangci-lint

c42134c

Signed-off-by: Michael Crenshaw <michael@crenshaw.dev>

chore: lint

d2cdbbc

Signed-off-by: Michael Crenshaw <michael@crenshaw.dev>

chore: use v3 action

7e21c25

Signed-off-by: Michael Crenshaw <michael@crenshaw.dev>

crenshaw-dev added 3 commits April 4, 2022 12:59

chore: delete old config, lint in verbose mode

382cf44

Signed-off-by: Michael Crenshaw <michael@crenshaw.dev>

chore: setup golang (required in v3)

0af43db

Signed-off-by: Michael Crenshaw <michael@crenshaw.dev>

Merge branch 'master' into update-golangci-lint

ac9438d

crenshaw-dev marked this pull request as ready for review April 4, 2022 20:11

alexmt requested changes Apr 4, 2022

View reviewed changes

util/io/bytereadseeker.go Show resolved Hide resolved

fix: incorrect byte seeker implementation; add tests

abfdffb

Signed-off-by: Michael Crenshaw <michael@crenshaw.dev>

crenshaw-dev requested a review from alexmt April 5, 2022 14:10

alexmt approved these changes Apr 5, 2022

View reviewed changes

alexmt merged commit b0cd653 into argoproj:master Apr 5, 2022

crenshaw-dev deleted the update-golangci-lint branch April 5, 2022 14:54

zachaller mentioned this pull request Apr 5, 2022

fix: build/lint is broken due to dependencies changes argoproj/argo-rollouts#1958

Merged

ashutosh16 pushed a commit to ashutosh16/argo-cd that referenced this pull request Apr 9, 2022

chore: update golangci-lint (argoproj#8988)

8840423

* chore: update golangci-lint Signed-off-by: Michael Crenshaw <michael@crenshaw.dev> Signed-off-by: asingh51 <Ashutosh_Singh@intuit.com>

wojtekidd pushed a commit to wojtekidd/argo-cd that referenced this pull request Apr 25, 2022

chore: update golangci-lint (argoproj#8988)

33ade1d

* chore: update golangci-lint Signed-off-by: Michael Crenshaw <michael@crenshaw.dev> Signed-off-by: wojtekidd <wojtek.cichon@protonmail.com>

crenshaw-dev added the cherry-pick/2.3 Candidate for cherry picking into the 2.3 release branch label Jun 13, 2022

crenshaw-dev added a commit that referenced this pull request Jun 13, 2022

chore: update golangci-lint (#8988)

909f94a

* chore: update golangci-lint Signed-off-by: Michael Crenshaw <michael@crenshaw.dev>

crenshaw-dev added the cherry-pick/2.2 Candidate for cherry picking into the 2.2 release branch label Jun 13, 2022

crenshaw-dev added a commit that referenced this pull request Jun 13, 2022

chore: update golangci-lint (#8988)

273bc30

* chore: update golangci-lint Signed-off-by: Michael Crenshaw <michael@crenshaw.dev>

crenshaw-dev added a commit that referenced this pull request Jun 14, 2022

chore: update golangci-lint (#8988)

e19c351

* chore: update golangci-lint Signed-off-by: Michael Crenshaw <michael@crenshaw.dev>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: update golangci-lint#8988

chore: update golangci-lint#8988
alexmt merged 7 commits intoargoproj:masterfrom
crenshaw-dev:update-golangci-lint

crenshaw-dev commented Apr 4, 2022 •

edited

Loading

Uh oh!

codecov bot commented Apr 4, 2022 •

edited

Loading

Uh oh!

Uh oh!

alexmt left a comment

Uh oh!

crenshaw-dev commented Jun 13, 2022

Uh oh!

crenshaw-dev commented Jun 13, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

crenshaw-dev commented Apr 4, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov bot commented Apr 4, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

alexmt left a comment

Choose a reason for hiding this comment

Uh oh!

crenshaw-dev commented Jun 13, 2022

Uh oh!

crenshaw-dev commented Jun 13, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

crenshaw-dev commented Apr 4, 2022 •

edited

Loading

codecov bot commented Apr 4, 2022 •

edited

Loading