Skip to content

docs: fill in docs page for managing clusters#5822

Merged
jannfis merged 1 commit intoargoproj:refresh-docsfrom
jemisonf:manage-cluster-docs
Mar 19, 2021
Merged

docs: fill in docs page for managing clusters#5822
jannfis merged 1 commit intoargoproj:refresh-docsfrom
jemisonf:manage-cluster-docs

Conversation

@jemisonf
Copy link

@jemisonf jemisonf commented Mar 19, 2021

Note on DCO:

If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • Optional. My organization is added to USERS.md.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).

Related to #5635

Fills in the managing cluster docs, trying to follow the example of the managing applications docs. Happy to adjust style/voice as appropriate. I noticed it looks like the other docs have a max line width that they're using -- I can adjust this to add that but I left it out for the time being since I didn't see a style guide around that.

Signed-off-by: Fischer Jemison <fjemison@newrelic.com>
@jemisonf jemisonf force-pushed the manage-cluster-docs branch from daabfb1 to c323828 Compare March 19, 2021 17:36
Copy link
Member

@jannfis jannfis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Thank you for this contribution, @jemisonf! Much appreciated.

LGTM.

@jannfis
Copy link
Member

jannfis commented Mar 19, 2021

Oh and btw, line length is not critical. I guess it's just me sticking to some 80 characters wrap because of old memories and stuff. But now that you mentioned a style guide, maybe that'd be a very good thing to have!

@jannfis jannfis merged commit 068a7a6 into argoproj:refresh-docs Mar 19, 2021
@jemisonf
Copy link
Author

But now that you mentioned a style guide, maybe that'd be a very good thing to have!

It might be nice, even if it's short and not very strict. I don't think it's super high priority but docs do feel a little bit left behind in the contributing section compared to development stuff

@jemisonf jemisonf deleted the manage-cluster-docs branch April 30, 2021 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants