Skip to content

feat: AppSet PR generator return 0 results upon repo not found instead of failing#23447

Merged
reggie-k merged 16 commits intoargoproj:masterfrom
reggie-k:appset-return-0-results-when-repo-not-found
Jul 2, 2025
Merged

feat: AppSet PR generator return 0 results upon repo not found instead of failing#23447
reggie-k merged 16 commits intoargoproj:masterfrom
reggie-k:appset-return-0-results-when-repo-not-found

Conversation

@reggie-k
Copy link
Copy Markdown
Member

@reggie-k reggie-k commented Jun 17, 2025

Closes #22550

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.
  • Optional. My organization is added to USERS.md.
  • Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

Signed-off-by: reggie-k <regina.voloshin@codefresh.io>
@bunnyshell
Copy link
Copy Markdown

bunnyshell bot commented Jun 17, 2025

❌ Preview Environment deleted from Bunnyshell

Available commands (reply to this comment):

  • 🚀 /bns:deploy to deploy the environment

@reggie-k reggie-k force-pushed the appset-return-0-results-when-repo-not-found branch from 1e98692 to 4593fbc Compare June 17, 2025 09:44
reggie-k added 3 commits June 17, 2025 12:49
Signed-off-by: reggie-k <regina.voloshin@codefresh.io>
…set-return-0-results-when-repo-not-found

Signed-off-by: reggie-k <regina.voloshin@codefresh.io>
Signed-off-by: reggie-k <regina.voloshin@codefresh.io>
@codecov
Copy link
Copy Markdown

codecov bot commented Jun 17, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 60.25%. Comparing base (0479433) to head (016a805).
⚠️ Report is 800 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #23447      +/-   ##
==========================================
+ Coverage   60.21%   60.25%   +0.04%     
==========================================
  Files         345      346       +1     
  Lines       59173    59212      +39     
==========================================
+ Hits        35629    35677      +48     
+ Misses      20660    20654       -6     
+ Partials     2884     2881       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@reggie-k
Copy link
Copy Markdown
Member Author

Thanks everyone for the review, the PR is still draft and I outlined some concerns and possible implementations on the issue.
The final version will analyze the http status code where applicable, and analyze the error only for providers that don't provide a standard http response code.

reggie-k added 2 commits June 25, 2025 17:45
… all providers

Signed-off-by: reggie-k <regina.voloshin@codefresh.io>
Signed-off-by: reggie-k <regina.voloshin@codefresh.io>
Signed-off-by: reggie-k <regina.voloshin@codefresh.io>
@reggie-k reggie-k marked this pull request as ready for review June 25, 2025 15:52
@reggie-k reggie-k requested review from a team as code owners June 25, 2025 15:52
Signed-off-by: reggie-k <regina.voloshin@codefresh.io>
@reggie-k
Copy link
Copy Markdown
Member Author

reggie-k commented Jun 25, 2025

The PR is now ready for review.
I took the approach of handling the HTTP status code for providers that return it in a standard way, and then string-analyzed the error only for those that don't return an http status.
In addition to unit tests, also tested manually for all providers except for BitBucket Server (more complex setup required, but will update in case I manage to manually test it as well).

Signed-off-by: reggie-k <regina.voloshin@codefresh.io>
Copy link
Copy Markdown
Member

@pasha-codefresh pasha-codefresh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, only small comment from my side

Signed-off-by: reggie-k <regina.voloshin@codefresh.io>
Copy link
Copy Markdown
Member

@nitishfy nitishfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a small comment, otherwise LGTM!

reggie-k and others added 3 commits July 1, 2025 14:53
Co-authored-by: Nitish Kumar <justnitish06@gmail.com>
Signed-off-by: Regina Voloshin <regina.voloshin@codefresh.io>
Signed-off-by: reggie-k <regina.voloshin@codefresh.io>
Signed-off-by: reggie-k <regina.voloshin@codefresh.io>
Signed-off-by: reggie-k <regina.voloshin@codefresh.io>
…set-return-0-results-when-repo-not-found

Signed-off-by: reggie-k <regina.voloshin@codefresh.io>
Co-authored-by: dudinea <dudinea@gmail.com>
Signed-off-by: Regina Voloshin <regina.voloshin@codefresh.io>
@reggie-k reggie-k merged commit be042c4 into argoproj:master Jul 2, 2025
28 checks passed
dsuhinin pushed a commit to dsuhinin/argo-cd that referenced this pull request Jul 9, 2025
…d of failing (argoproj#23447)

Signed-off-by: reggie-k <regina.voloshin@codefresh.io>
Signed-off-by: Regina Voloshin <regina.voloshin@codefresh.io>
Co-authored-by: Nitish Kumar <justnitish06@gmail.com>
Co-authored-by: dudinea <dudinea@gmail.com>
Signed-off-by: dsuhinin <suhinin.dmitriy@gmail.com>

# Conflicts:
#	pkg/apis/application/v1alpha1/generated.pb.go
enneitex pushed a commit to enneitex/argo-cd that referenced this pull request Aug 24, 2025
…d of failing (argoproj#23447)

Signed-off-by: reggie-k <regina.voloshin@codefresh.io>
Signed-off-by: Regina Voloshin <regina.voloshin@codefresh.io>
Co-authored-by: Nitish Kumar <justnitish06@gmail.com>
Co-authored-by: dudinea <dudinea@gmail.com>
Signed-off-by: enneitex <etienne.divet@gmail.com>
Mangaal pushed a commit to Mangaal/argo-cd that referenced this pull request Sep 10, 2025
…d of failing (argoproj#23447)

Signed-off-by: reggie-k <regina.voloshin@codefresh.io>
Signed-off-by: Regina Voloshin <regina.voloshin@codefresh.io>
Co-authored-by: Nitish Kumar <justnitish06@gmail.com>
Co-authored-by: dudinea <dudinea@gmail.com>
Signed-off-by: Mangaal <angommeeteimangaal@gmail.com>
@reggie-k reggie-k deleted the appset-return-0-results-when-repo-not-found branch November 24, 2025 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Ignore Second Generator Matrix Failures

5 participants