feat: AppSet PR generator return 0 results upon repo not found instead of failing#23447
Conversation
❌ Preview Environment deleted from BunnyshellAvailable commands (reply to this comment):
|
1e98692 to
4593fbc
Compare
…set-return-0-results-when-repo-not-found Signed-off-by: reggie-k <regina.voloshin@codefresh.io>
Signed-off-by: reggie-k <regina.voloshin@codefresh.io>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #23447 +/- ##
==========================================
+ Coverage 60.21% 60.25% +0.04%
==========================================
Files 345 346 +1
Lines 59173 59212 +39
==========================================
+ Hits 35629 35677 +48
+ Misses 20660 20654 -6
+ Partials 2884 2881 -3 ☔ View full report in Codecov by Sentry. |
|
Thanks everyone for the review, the PR is still draft and I outlined some concerns and possible implementations on the issue. |
… all providers Signed-off-by: reggie-k <regina.voloshin@codefresh.io>
Signed-off-by: reggie-k <regina.voloshin@codefresh.io>
Signed-off-by: reggie-k <regina.voloshin@codefresh.io>
Signed-off-by: reggie-k <regina.voloshin@codefresh.io>
|
The PR is now ready for review. |
Signed-off-by: reggie-k <regina.voloshin@codefresh.io>
pasha-codefresh
left a comment
There was a problem hiding this comment.
LGTM, only small comment from my side
Signed-off-by: reggie-k <regina.voloshin@codefresh.io>
nitishfy
left a comment
There was a problem hiding this comment.
Left a small comment, otherwise LGTM!
Co-authored-by: Nitish Kumar <justnitish06@gmail.com> Signed-off-by: Regina Voloshin <regina.voloshin@codefresh.io>
Signed-off-by: reggie-k <regina.voloshin@codefresh.io>
Signed-off-by: reggie-k <regina.voloshin@codefresh.io>
Signed-off-by: reggie-k <regina.voloshin@codefresh.io>
…set-return-0-results-when-repo-not-found Signed-off-by: reggie-k <regina.voloshin@codefresh.io>
Co-authored-by: dudinea <dudinea@gmail.com> Signed-off-by: Regina Voloshin <regina.voloshin@codefresh.io>
…d of failing (argoproj#23447) Signed-off-by: reggie-k <regina.voloshin@codefresh.io> Signed-off-by: Regina Voloshin <regina.voloshin@codefresh.io> Co-authored-by: Nitish Kumar <justnitish06@gmail.com> Co-authored-by: dudinea <dudinea@gmail.com> Signed-off-by: dsuhinin <suhinin.dmitriy@gmail.com> # Conflicts: # pkg/apis/application/v1alpha1/generated.pb.go
…d of failing (argoproj#23447) Signed-off-by: reggie-k <regina.voloshin@codefresh.io> Signed-off-by: Regina Voloshin <regina.voloshin@codefresh.io> Co-authored-by: Nitish Kumar <justnitish06@gmail.com> Co-authored-by: dudinea <dudinea@gmail.com> Signed-off-by: enneitex <etienne.divet@gmail.com>
…d of failing (argoproj#23447) Signed-off-by: reggie-k <regina.voloshin@codefresh.io> Signed-off-by: Regina Voloshin <regina.voloshin@codefresh.io> Co-authored-by: Nitish Kumar <justnitish06@gmail.com> Co-authored-by: dudinea <dudinea@gmail.com> Signed-off-by: Mangaal <angommeeteimangaal@gmail.com>
Closes #22550
Checklist: