chore: replace heptio-images with argocd-e2e-container (cherry-pick #23040)#23058
Conversation
|
Thanks @nitishfy! Any reason for using different container argoprojlabs/argocd-e2e-container tags? (0.2, 0.1 and unpinned) |
Signed-off-by: nitishfy <justnitish06@gmail.com> Signed-off-by: Nitish Kumar <justnitish06@gmail.com>
nitishfy
force-pushed
the
images-cherry-pick-3.0
branch
from
dc2ec57 to
509afb0
Compare
Signed-off-by: nitishfy <justnitish06@gmail.com>
Can you refer the line that you're refering to? |
reggie-k
left a comment
reggie-k
left a comment
There was a problem hiding this comment.
Pointed out some lines, but didn't go through every single one.
|
|
||
| image: | ||
| repository: gcr.io/heptio-images/ks-guestbook-demo | ||
| repository: quay.io/argoprojlabs/argocd-e2e-container |
There was a problem hiding this comment.
Here the argocd-e2e-container image is used without a tag
There was a problem hiding this comment.
the tag field is mentioned below. Please see this.
| iksm-version: '2.0' | ||
| kubectl.kubernetes.io/last-applied-configuration: > | ||
| {"apiVersion":"apps/v1","kind":"Deployment","metadata":{"annotations":{"argocd.argoproj.io/tracking-id":"guestbook:apps/Deployment:default/kustomize-guestbook-ui","iksm-version":"2.0"},"name":"kustomize-guestbook-ui","namespace":"default"},"spec":{"replicas":4,"revisionHistoryLimit":3,"selector":{"matchLabels":{"app":"guestbook-ui"}},"template":{"metadata":{"labels":{"app":"guestbook-ui"}},"spec":{"containers":[{"env":[{"name":"SOME_ENV_VAR","value":"some_value"}],"image":"gcr.io/heptio-images/ks-guestbook-demo:0.1","name":"guestbook-ui","ports":[{"containerPort":80}],"resources":{"requests":{"cpu":"50m","memory":"100Mi"}}}]}}}} | ||
| {"apiVersion":"apps/v1","kind":"Deployment","metadata":{"annotations":{"argocd.argoproj.io/tracking-id":"guestbook:apps/Deployment:default/kustomize-guestbook-ui","iksm-version":"2.0"},"name":"kustomize-guestbook-ui","namespace":"default"},"spec":{"replicas":4,"revisionHistoryLimit":3,"selector":{"matchLabels":{"app":"guestbook-ui"}},"template":{"metadata":{"labels":{"app":"guestbook-ui"}},"spec":{"containers":[{"env":[{"name":"SOME_ENV_VAR","value":"some_value"}],"image":"quay.io/argoprojlabs/argocd-e2e-container:0.1","name":"guestbook-ui","ports":[{"containerPort":80}],"resources":{"requests":{"cpu":"50m","memory":"100Mi"}}}]}}}} |
There was a problem hiding this comment.
Here the argocd-e2e-container image is used with a 0.1 tag
| - name: SOME_ENV_VAR | ||
| value: some_value | ||
| image: 'gcr.io/heptio-images/ks-guestbook-demo:0.1' | ||
| image: 'quay.io/argoprojlabs/argocd-e2e-container:0.1' |
There was a problem hiding this comment.
Here the argocd-e2e-container image is used with a 0.1 tag
| spec: | ||
| containers: | ||
| - image: gcr.io/heptio-images/ks-guestbook-demo:0.2 | ||
| - image: quay.io/argoprojlabs/argocd-e2e-container:0.2 |
There was a problem hiding this comment.
Here the argocd-e2e-container image is used with a 0.2 tag
There was a problem hiding this comment.
i dont think we should be changing the tag version. they were running a different tag before as part of the e2e. i would assume they were set intentionally?
Signed-off-by: nitishfy <justnitish06@gmail.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release-3.0 #23058 +/- ##
===============================================
- Coverage 55.93% 55.83% -0.11%
===============================================
Files 343 343
Lines 57387 57387
===============================================
- Hits 32102 32040 -62
- Misses 22643 22685 +42
- Partials 2642 2662 +20 ☔ View full report in Codecov by Sentry. |
3 participants
Cherry-pick #23040
Checklist: