fix: UI MultiSource - Helm Chart with values.yaml (#18188)#18200
Merged
ishitasequeira merged 1 commit intoargoproj:release-2.11from May 20, 2024
Merged
Conversation
9453dd1 to
3199039
Compare
Signed-off-by: Keith Chong <kykchong@redhat.com>
3199039 to
f97cd6b
Compare
14 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #18188
This will show the sync status info for single source apps as well as for the first source of the multiple source application. This will align with what is currently supported in the UI where only the first source is shown in the details panels of the application. The other option that is much simpler is to not show this panel at all for any multi-source app. This is to add
!hasMultipleSource &&on line 110 just beforeapplication.status &&However, the status info might still be helpful, so I opted for this fix instead.
We want to fix this against 2.11 because we don't want the UI to blow up like what the issue reporter has encountered.
More complete support of this will be part of the changes delivered by the enhancement proposal to support multi-source applications in the UI.
Specifically, this #14124 and my follow-on changes should cover this.
Checklist: