Skip to content

fix(appset): add debug logs around deleting ownerReferences and add warning docs about policy behavior#18006

Merged
ishitasequeira merged 8 commits intoargoproj:masterfrom
mikutas:12172-add-debug-logs
Apr 28, 2024
Merged

fix(appset): add debug logs around deleting ownerReferences and add warning docs about policy behavior#18006
ishitasequeira merged 8 commits intoargoproj:masterfrom
mikutas:12172-add-debug-logs

Conversation

@mikutas
Copy link
Contributor

@mikutas mikutas commented Apr 27, 2024 •
edited
Loading

recreated #17357 due to getting stuck

#12172

Previous PRs didn't fix policy behavior completely.
This PR is adding warning to doc about policy and some logs for debug.

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.
  • Optional. My organization is added to USERS.md.
  • Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

mikutas and others added 8 commits April 4, 2024 10:42
@mikutas
chore(appset): add logs for debug
aa4486d 
Signed-off-by: mikutas <23391543+mikutas@users.noreply.github.com>
@mikutas
fix(appset): remove finalizer regardless with deleteAllowed
a0ecbf5 
Signed-off-by: mikutas <23391543+mikutas@users.noreply.github.com>
@mikutas
docs: update about appset policy
878dac6 
Signed-off-by: mikutas <23391543+mikutas@users.noreply.github.com>
@mikutas
fix: wrong log message
3851fff 
Signed-off-by: mikutas <23391543+mikutas@users.noreply.github.com>
@mikutas
fix: log messages
d16c588 
Signed-off-by: mikutas <23391543+mikutas@users.noreply.github.com>
@mikutas @ishitasequeira
fix: log message
3113478 
Co-authored-by: Ishita Sequeira <46771830+ishitasequeira@users.noreply.github.com>
Signed-off-by: Takumi Sue <23391543+mikutas@users.noreply.github.com>
@mikutas
docs: add explanation
6ca223f 
Signed-off-by: mikutas <23391543+mikutas@users.noreply.github.com>
@ishitasequeira @mikutas
Merge branch 'master' into fix-12172-with-finalizer
350302f
@mikutas mikutas marked this pull request as ready for review April 27, 2024 12:18
@mikutas mikutas requested review from a team as code owners April 27, 2024 12:18
ishitasequeira
ishitasequeira approved these changes Apr 28, 2024
View reviewed changes
Copy link
Member

@ishitasequeira ishitasequeira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

@ishitasequeira ishitasequeira merged commit e6200ca into argoproj:master Apr 28, 2024
@mikutas mikutas deleted the 12172-add-debug-logs branch April 30, 2024 00:07
mkieweg pushed a commit to mkieweg/argo-cd that referenced this pull request Jun 11, 2024
@mikutas @ishitasequeira @mkieweg
fix(appset): add debug logs around deleting ownerReferences and add w…
7a6a24d 
…arning docs about policy behavior (argoproj#18006)

* chore(appset): add logs for debug

Signed-off-by: mikutas <23391543+mikutas@users.noreply.github.com>

* fix(appset): remove finalizer regardless with deleteAllowed

Signed-off-by: mikutas <23391543+mikutas@users.noreply.github.com>

* docs: update about appset policy

Signed-off-by: mikutas <23391543+mikutas@users.noreply.github.com>

* fix: wrong log message

Signed-off-by: mikutas <23391543+mikutas@users.noreply.github.com>

* fix: log messages

Signed-off-by: mikutas <23391543+mikutas@users.noreply.github.com>

* fix: log message

Co-authored-by: Ishita Sequeira <46771830+ishitasequeira@users.noreply.github.com>
Signed-off-by: Takumi Sue <23391543+mikutas@users.noreply.github.com>

* docs: add explanation

Signed-off-by: mikutas <23391543+mikutas@users.noreply.github.com>

---------

Signed-off-by: mikutas <23391543+mikutas@users.noreply.github.com>
Signed-off-by: Takumi Sue <23391543+mikutas@users.noreply.github.com>
Co-authored-by: Ishita Sequeira <46771830+ishitasequeira@users.noreply.github.com>
Hariharasuthan99 pushed a commit to AmadeusITGroup/argo-cd that referenced this pull request Jun 16, 2024
@mikutas @ishitasequeira @Hariharasuthan99
fix(appset): add debug logs around deleting ownerReferences and add w…
6d0a69f 
…arning docs about policy behavior (argoproj#18006)

* chore(appset): add logs for debug

Signed-off-by: mikutas <23391543+mikutas@users.noreply.github.com>

* fix(appset): remove finalizer regardless with deleteAllowed

Signed-off-by: mikutas <23391543+mikutas@users.noreply.github.com>

* docs: update about appset policy

Signed-off-by: mikutas <23391543+mikutas@users.noreply.github.com>

* fix: wrong log message

Signed-off-by: mikutas <23391543+mikutas@users.noreply.github.com>

* fix: log messages

Signed-off-by: mikutas <23391543+mikutas@users.noreply.github.com>

* fix: log message

Co-authored-by: Ishita Sequeira <46771830+ishitasequeira@users.noreply.github.com>
Signed-off-by: Takumi Sue <23391543+mikutas@users.noreply.github.com>

* docs: add explanation

Signed-off-by: mikutas <23391543+mikutas@users.noreply.github.com>

---------

Signed-off-by: mikutas <23391543+mikutas@users.noreply.github.com>
Signed-off-by: Takumi Sue <23391543+mikutas@users.noreply.github.com>
Co-authored-by: Ishita Sequeira <46771830+ishitasequeira@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ishitasequeira ishitasequeira ishitasequeira approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mikutas @ishitasequeira