Skip to content

fix(appset): add debug logs around deleting ownerReferences and add warning docs about policy behavior#17357

Closed
mikutas wants to merge 8 commits intoargoproj:masterfrom
mikutas:fix-12172-with-finalizer
Closed

fix(appset): add debug logs around deleting ownerReferences and add warning docs about policy behavior#17357
mikutas wants to merge 8 commits intoargoproj:masterfrom
mikutas:fix-12172-with-finalizer

Conversation

@mikutas
Copy link
Contributor

@mikutas mikutas commented Feb 29, 2024 •
edited
Loading

#12172

Previous PRs didn't fix policy behavior completely.
This PR is adding warning to doc about policy and some logs for debug.

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.
  • Optional. My organization is added to USERS.md.
  • Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

@mikutas mikutas force-pushed the fix-12172-with-finalizer branch 7 times, most recently from 56c93df to 6b4694c Compare March 6, 2024 12:46
@mikutas mikutas changed the title fix(appset): prevent app deletion according to policy if appset has the finalizer docs(appset): Mar 6, 2024
@mikutas mikutas changed the title docs(appset): docs(appset): add warning about policy behavior when deleting ApplicationSet Mar 6, 2024
@mikutas mikutas force-pushed the fix-12172-with-finalizer branch 4 times, most recently from 8a9e1f6 to 0d65b89 Compare March 8, 2024 02:40
@mikutas mikutas marked this pull request as ready for review March 8, 2024 02:40
@mikutas mikutas requested review from a team as code owners March 8, 2024 02:40
@mikutas mikutas marked this pull request as draft March 8, 2024 02:41
@mikutas mikutas force-pushed the fix-12172-with-finalizer branch from 0d65b89 to 3e36f8a Compare March 8, 2024 04:15
@mikutas mikutas marked this pull request as ready for review March 8, 2024 04:15
@mikutas mikutas force-pushed the fix-12172-with-finalizer branch from 3e36f8a to 1623169 Compare March 11, 2024 02:07
pasha-codefresh
pasha-codefresh requested changes Mar 11, 2024
View reviewed changes
@mikutas mikutas force-pushed the fix-12172-with-finalizer branch 3 times, most recently from 9a7194e to 67fc9b9 Compare March 12, 2024 01:17
@mikutas mikutas requested a review from pasha-codefresh March 12, 2024 02:04
@ishitasequeira ishitasequeira changed the title docs(appset): add warning about policy behavior when deleting ApplicationSet fix(appset): add warning about policy behavior when deleting ApplicationSet Mar 12, 2024
ishitasequeira
ishitasequeira reviewed Mar 12, 2024
View reviewed changes
@mikutas mikutas force-pushed the fix-12172-with-finalizer branch from 5060c14 to 19d3785 Compare March 13, 2024 09:57
@mikutas mikutas requested a review from ishitasequeira March 13, 2024 09:57
@mikutas mikutas force-pushed the fix-12172-with-finalizer branch from 19d3785 to eff0ade Compare March 13, 2024 10:21
@mikutas mikutas force-pushed the fix-12172-with-finalizer branch 3 times, most recently from 696f57f to e141ebe Compare March 23, 2024 01:32
@mikutas mikutas force-pushed the fix-12172-with-finalizer branch 2 times, most recently from c609347 to 83514fe Compare March 29, 2024 01:56
@mikutas mikutas changed the title fix(appset): add warning about policy behavior when deleting ApplicationSet fix(appset): add debug logs around deleting ownerReferences and add warning docs about policy behavior Mar 29, 2024
@mikutas

This comment was marked as outdated.

Sign in to view
@mikutas

This comment was marked as outdated.

Sign in to view
@mikutas mikutas force-pushed the fix-12172-with-finalizer branch from 83514fe to 2873564 Compare March 30, 2024 00:14
ishitasequeira
ishitasequeira reviewed Apr 1, 2024
View reviewed changes
Copy link
Member

@ishitasequeira ishitasequeira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mikutas , I had approved the PR earlier but I just realized some inconsistency in the documentation.

@ishitasequeira ishitasequeira self-requested a review April 1, 2024 01:36
@mikutas mikutas force-pushed the fix-12172-with-finalizer branch from 8e1d84c to f20dd5f Compare April 1, 2024 03:05
mikutas and others added 7 commits April 4, 2024 10:42
@mikutas
chore(appset): add logs for debug
aa4486d 
Signed-off-by: mikutas <23391543+mikutas@users.noreply.github.com>
@mikutas
fix(appset): remove finalizer regardless with deleteAllowed
a0ecbf5 
Signed-off-by: mikutas <23391543+mikutas@users.noreply.github.com>
@mikutas
docs: update about appset policy
878dac6 
Signed-off-by: mikutas <23391543+mikutas@users.noreply.github.com>
@mikutas
fix: wrong log message
3851fff 
Signed-off-by: mikutas <23391543+mikutas@users.noreply.github.com>
@mikutas
fix: log messages
d16c588 
Signed-off-by: mikutas <23391543+mikutas@users.noreply.github.com>
@mikutas @ishitasequeira
fix: log message
3113478 
Co-authored-by: Ishita Sequeira <46771830+ishitasequeira@users.noreply.github.com>
Signed-off-by: Takumi Sue <23391543+mikutas@users.noreply.github.com>
@mikutas
docs: add explanation
6ca223f 
Signed-off-by: mikutas <23391543+mikutas@users.noreply.github.com>
@mikutas mikutas force-pushed the fix-12172-with-finalizer branch from f20dd5f to 6ca223f Compare April 4, 2024 01:42
gdsoumya
gdsoumya approved these changes Apr 5, 2024
View reviewed changes
Copy link
Member

@gdsoumya gdsoumya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ishitasequeira ishitasequeira enabled auto-merge (squash) April 10, 2024 01:59
@mikutas
Copy link
Contributor Author

mikutas commented Apr 10, 2024

@pasha-codefresh please confirm that requested change is adressed.

@mikutas
Copy link
Contributor Author

mikutas commented Apr 27, 2024

closing PR because its' unable to progress

@mikutas mikutas closed this Apr 27, 2024
auto-merge was automatically disabled April 27, 2024 10:55

Pull request was closed

@mikutas mikutas deleted the fix-12172-with-finalizer branch April 27, 2024 10:55
@mikutas mikutas mentioned this pull request Apr 27, 2024
Merged
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gdsoumya gdsoumya gdsoumya approved these changes

@pasha-codefresh pasha-codefresh Awaiting requested review from pasha-codefresh

@ishitasequeira ishitasequeira Awaiting requested review from ishitasequeira

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@mikutas @pasha-codefresh @gdsoumya @ishitasequeira