feat: Add Sources tab to show all sources of a multi-source app (#17274)#17275
Merged
ishitasequeira merged 7 commits intoargoproj:masterfrom Apr 16, 2024
Merged
feat: Add Sources tab to show all sources of a multi-source app (#17274)#17275ishitasequeira merged 7 commits intoargoproj:masterfrom
ishitasequeira merged 7 commits intoargoproj:masterfrom
Conversation
b85bd62 to
f2db50e
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #17275 +/- ##
==========================================
- Coverage 49.73% 49.55% -0.18%
==========================================
Files 274 273 -1
Lines 48948 48288 -660
==========================================
- Hits 24343 23928 -415
+ Misses 22230 21998 -232
+ Partials 2375 2362 -13 ☔ View full report in Codecov by Sentry. |
…proj#17274) Signed-off-by: Keith Chong <kykchong@redhat.com>
f2db50e to
95246c5
Compare
14 tasks
This was referenced Mar 21, 2024
agaudreault
reviewed
Mar 26, 2024
ui/src/app/applications/components/resource-details/resource-details.tsx
Outdated
Show resolved
Hide resolved
agaudreault
reviewed
Mar 26, 2024
…etails.tsx Co-authored-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com> Signed-off-by: Keith Chong <kykchong@redhat.com>
Signed-off-by: Keith Chong <kykchong@redhat.com>
Signed-off-by: Keith Chong <kykchong@redhat.com>
agaudreault
approved these changes
Apr 8, 2024
Member
agaudreault
left a comment
There was a problem hiding this comment.
LGTM. but a review from a "UI" folk/maintainer would be good to have!
Member
ishitasequeira
left a comment
There was a problem hiding this comment.
Thanks @keithchong. The PR looks great!! I just have a few comments.
ui/src/app/applications/components/resource-details/resource-details.tsx
Show resolved
Hide resolved
Signed-off-by: Keith Chong <kykchong@redhat.com>
…git into 17274-SourcesTab
Signed-off-by: Keith Chong <kykchong@redhat.com>
ishitasequeira
approved these changes
Apr 16, 2024
Member
ishitasequeira
left a comment
There was a problem hiding this comment.
Thanks @keithchong! The PR LGTM 🚀
This was referenced Apr 18, 2024
6 tasks
mkieweg
pushed a commit
to mkieweg/argo-cd
that referenced
this pull request
Jun 11, 2024
…proj#17274) (argoproj#17275) * feat: Add Sources tab to show all sources of a multi-source app (argoproj#17274) Signed-off-by: Keith Chong <kykchong@redhat.com> * Update ui/src/app/applications/components/resource-details/resource-details.tsx Co-authored-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com> Signed-off-by: Keith Chong <kykchong@redhat.com> * Remove getAppSources Signed-off-by: Keith Chong <kykchong@redhat.com> * Add address Ishita's comments. Add missing Ref field Signed-off-by: Keith Chong <kykchong@redhat.com> * Use single quotes Signed-off-by: Keith Chong <kykchong@redhat.com> --------- Signed-off-by: Keith Chong <kykchong@redhat.com> Co-authored-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com>
Hariharasuthan99
pushed a commit
to AmadeusITGroup/argo-cd
that referenced
this pull request
Jun 16, 2024
…proj#17274) (argoproj#17275) * feat: Add Sources tab to show all sources of a multi-source app (argoproj#17274) Signed-off-by: Keith Chong <kykchong@redhat.com> * Update ui/src/app/applications/components/resource-details/resource-details.tsx Co-authored-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com> Signed-off-by: Keith Chong <kykchong@redhat.com> * Remove getAppSources Signed-off-by: Keith Chong <kykchong@redhat.com> * Add address Ishita's comments. Add missing Ref field Signed-off-by: Keith Chong <kykchong@redhat.com> * Use single quotes Signed-off-by: Keith Chong <kykchong@redhat.com> --------- Signed-off-by: Keith Chong <kykchong@redhat.com> Co-authored-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com>
14 tasks
14 tasks
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #17274
The original Multi-Source enhancement PR supported viewing only the first source of a multi-source application. The parameters were not editable either.
This PR adds a bit more support in that it will show all the sources of the multi-source application under a new Sources tab (which replaces the Parameters tab). Arguably, these changes could have been part of the original PR. The parameters are still read-only. (Making the input/parameters editable will be part of another PR.)
Note: There is effectively no change in behaviour for applications that still use the single
source. The repo URL, path and related inputs are still shown in the Summary tab. When thesourcefield is deprecated and removed, the corresponding code should be updated.This is just the first stage from the design proposal.
Checklist: