Skip to content

fix: set max for max cookie number to math.MaxInt #16388

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gdsoumya merged 3 commits into from
Nov 20, 2023
Merged

fix: set max for max cookie number to math.MaxInt #16388

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
cdf3a10
fix: set max for max cookie number to `math.MaxInt32`
onematchfox Nov 19, 2023
91cab0f
refactor: set max for max cookie number to `math.MaxInt`
onematchfox Nov 20, 2023
11c7890
Merge branch 'master' into fix/max-cookie-number-default
gdsoumya Nov 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion util/http/http.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ const (

// max number of chunks a cookie can be broken into. To be compatible with
// widest range of browsers, you shouldn't create more than 30 cookies per domain
var maxCookieNumber = env.ParseNumFromEnv(common.EnvMaxCookieNumber, 20, 0, math.MaxInt64)
var maxCookieNumber = env.ParseNumFromEnv(common.EnvMaxCookieNumber, 20, 0, math.MaxInt)

// MakeCookieMetadata generates a string representing a Web cookie. Yum!
func MakeCookieMetadata(key, value string, flags ...string) ([]string, error) {
Expand Down