fix: set max for max cookie number to math.MaxInt

[onematchfox]

The goreleaser-based release build for terraform-provider-argocd is currently failing with the following error:

  ⨯ release failed after 3m53s               error=failed to build for freebsd_arm_6: exit status 1: # github.com/argoproj/argo-cd/v2/util/http
../../../go/pkg/mod/github.com/argoproj/argo-cd/v2@v2.8.3/util/http/http.go:22:77: cannot use math.MaxInt64 (untyped int constant 9223372036854775807) as int value in argument to env.ParseNumFromEnv (overflows)

The affected code in this project was introduced in #14979, which, set the max value of common.EnvMaxCookieNumber to math.MaxInt64. This, as goreleaser correctly identifies, results in an overflow since the max parameter in ParseNumFromEnv is an int (not int64). See

argo-cd/util/env/env.go

Line 20 in 6fa9b17

func ParseNumFromEnv(env string, defaultValue, min, max int) int {

Why goreleaser is failing because of an issue initialising code in this project is a bit of a mystery to me, but regardless, this PR addresses the issue (assuming, of course, that int is big enough and the code should not be updated to use env.ParseInt64FromEnv).

Related: argoproj-labs/terraform-provider-argocd#354

Checklist:

• Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
• The title of the PR states what changed and the related issues number (used for the release note).
• The title of the PR conforms to the Toolchain Guide
• I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
• I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
• Does this PR require documentation updates?
• I've updated documentation as required by this PR.
• Optional. My organization is added to USERS.md.
• I have signed off all my commits as required by DCO
• I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
• My build is green (troubleshooting builds).
• My new feature complies with the feature status guidelines.
• I have added a brief description of why this PR is necessary and/or what this PR solves.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (841339d) 49.55% compared to head (11c7890) 49.55%.

Additional details and impacted files

@@           Coverage Diff           @@
##           master   #16388   +/-   ##
=======================================
  Coverage   49.55%   49.55%           
=======================================
  Files         269      269           
  Lines       47046    47046           
=======================================
  Hits        23313    23313           
  Misses      21445    21445           
  Partials     2288     2288           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[ishitasequeira]

LGTM!

[onematchfox]

Thanks for the quick review folks. @gdsoumya are you able to cherry pick this across to the 2.8 and 2.9 release branches?

[gdsoumya]

@onematchfox I think we can do that but I'll still check with other maintainers and see before doing that.

[gdsoumya]

/cherry-pick release-2.9

[gdsoumya]

/cherry-pick release-2.8

[gdsoumya]

@onematchfox the commit has been cherry picked to release branches.

[onematchfox]

Thanks!