Skip to content

fix(controller): cache deadlock on delete and re-add cluster (cherry-pick #14780)#14814

Merged
alexmt merged 1 commit intoargoproj:release-2.6from
alexmt:cluster-cache-deadlock-fix-cherry-pick-release-2.6
Aug 1, 2023
Merged

fix(controller): cache deadlock on delete and re-add cluster (cherry-pick #14780)#14814
alexmt merged 1 commit intoargoproj:release-2.6from
alexmt:cluster-cache-deadlock-fix-cherry-pick-release-2.6

Conversation

@alexmt
Copy link
Copy Markdown
Collaborator

@alexmt alexmt commented Aug 1, 2023

cherry-pick #14780 into release-2.6 branch

…pick argoproj#14780)

Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>
@codecov
Copy link
Copy Markdown

codecov bot commented Aug 1, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.02% 🎉

Comparison is base (4261d08) 48.48% compared to head (0ffa39e) 48.51%.

Additional details and impacted files
@@               Coverage Diff               @@
##           release-2.6   #14814      +/-   ##
===============================================
+ Coverage        48.48%   48.51%   +0.02%     
===============================================
  Files              247      247              
  Lines            42061    42063       +2     
===============================================
+ Hits             20395    20405      +10     
+ Misses           19599    19591       -8     
  Partials          2067     2067              
Files Changed Coverage Δ
controller/cache/cache.go 21.02% <100.00%> (+2.15%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Copy Markdown
Member

@terrytangyuan terrytangyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alexmt alexmt merged commit 1f6174e into argoproj:release-2.6 Aug 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants