chore: Print in-cluster svr addr disabled warning when server starts#14683
Merged
crenshaw-dev merged 3 commits intoargoproj:release-2.5from Jul 24, 2023
Merged
chore: Print in-cluster svr addr disabled warning when server starts#14683crenshaw-dev merged 3 commits intoargoproj:release-2.5from
crenshaw-dev merged 3 commits intoargoproj:release-2.5from
Conversation
…but internal addr is used (argoproj#14520) Signed-off-by: Yuan Tang <terrytangyuan@gmail.com>
…alization (argoproj#14539) * chore: Print in-cluster svr addr disabled warning during ArgoDB initialization Signed-off-by: Yuan Tang <terrytangyuan@gmail.com> * fix: undo a change Signed-off-by: Yuan Tang <terrytangyuan@gmail.com> * chore: move to a function Signed-off-by: Yuan Tang <terrytangyuan@gmail.com> * chore: rename Signed-off-by: Yuan Tang <terrytangyuan@gmail.com> --------- Signed-off-by: Yuan Tang <terrytangyuan@gmail.com>
…rgoproj#14553) * chore: Print in-cluster svr addr disabled warning when server starts Signed-off-by: Yuan Tang <terrytangyuan@gmail.com> * fix: mock Signed-off-by: Yuan Tang <terrytangyuan@gmail.com> * no interface change Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> --------- Signed-off-by: Yuan Tang <terrytangyuan@gmail.com> Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## release-2.5 #14683 +/- ##
===============================================
- Coverage 47.64% 47.62% -0.03%
===============================================
Files 240 240
Lines 39886 39928 +42
===============================================
+ Hits 19005 19016 +11
- Misses 18927 18952 +25
- Partials 1954 1960 +6
☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note on DCO:
If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.
Checklist:
Please see Contribution FAQs if you have questions about your pull-request.