chore: Update log level to warn when in-cluster svr addr is disabled but internal addr is used#14520
Merged
crenshaw-dev merged 1 commit intoargoproj:masterfrom Jul 14, 2023
Merged
Conversation
…but internal addr is used Signed-off-by: Yuan Tang <terrytangyuan@gmail.com>
rbreeze
approved these changes
Jul 14, 2023
|
Thank you @terrytangyuan |
crenshaw-dev
approved these changes
Jul 14, 2023
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #14520 +/- ##
=======================================
Coverage 49.78% 49.79%
=======================================
Files 261 261
Lines 44751 44751
=======================================
+ Hits 22279 22283 +4
+ Misses 20277 20274 -3
+ Partials 2195 2194 -1
☔ View full report in Codecov by Sentry. |
Collaborator
|
/cherry-pick 2.5 |
Collaborator
|
/cherry-pick release-2.5 |
gcp-cherry-pick-bot bot
pushed a commit
that referenced
this pull request
Jul 15, 2023
…but internal addr is used (#14520) Signed-off-by: Yuan Tang <terrytangyuan@gmail.com>
Collaborator
|
/cherry-pick release-2.6 |
Collaborator
|
/cherry-pick release-2.7 |
gcp-cherry-pick-bot bot
pushed a commit
that referenced
this pull request
Jul 15, 2023
…but internal addr is used (#14520) Signed-off-by: Yuan Tang <terrytangyuan@gmail.com>
gcp-cherry-pick-bot bot
pushed a commit
that referenced
this pull request
Jul 15, 2023
…but internal addr is used (#14520) Signed-off-by: Yuan Tang <terrytangyuan@gmail.com>
Collaborator
|
/cherry-pick release-2.8 |
gcp-cherry-pick-bot bot
pushed a commit
that referenced
this pull request
Jul 15, 2023
…but internal addr is used (#14520) Signed-off-by: Yuan Tang <terrytangyuan@gmail.com>
Collaborator
|
Closed cherry-pick PRs because changing for error to warning does not really solve the problem. By default Argo CD log level is info, so it will keep polluting everyone logs. |
Jneville0815
pushed a commit
to radiusmethod/argo-cd
that referenced
this pull request
Jul 18, 2023
…but internal addr is used (argoproj#14520) Signed-off-by: Yuan Tang <terrytangyuan@gmail.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>
terrytangyuan
added a commit
to terrytangyuan/argo-cd
that referenced
this pull request
Jul 24, 2023
…but internal addr is used (argoproj#14520) Signed-off-by: Yuan Tang <terrytangyuan@gmail.com>
terrytangyuan
added a commit
to terrytangyuan/argo-cd
that referenced
this pull request
Jul 24, 2023
…but internal addr is used (argoproj#14520) Signed-off-by: Yuan Tang <terrytangyuan@gmail.com>
terrytangyuan
added a commit
to terrytangyuan/argo-cd
that referenced
this pull request
Jul 24, 2023
…but internal addr is used (argoproj#14520) Signed-off-by: Yuan Tang <terrytangyuan@gmail.com>
terrytangyuan
added a commit
to terrytangyuan/argo-cd
that referenced
this pull request
Jul 24, 2023
…but internal addr is used (argoproj#14520) Signed-off-by: Yuan Tang <terrytangyuan@gmail.com>
crenshaw-dev
added a commit
that referenced
this pull request
Jul 24, 2023
…14683) * chore: Update log level to warn when in-cluster svr addr is disabled but internal addr is used (#14520) Signed-off-by: Yuan Tang <terrytangyuan@gmail.com> * chore: Print in-cluster svr addr disabled warning during ArgoDB initialization (#14539) * chore: Print in-cluster svr addr disabled warning during ArgoDB initialization Signed-off-by: Yuan Tang <terrytangyuan@gmail.com> * fix: undo a change Signed-off-by: Yuan Tang <terrytangyuan@gmail.com> * chore: move to a function Signed-off-by: Yuan Tang <terrytangyuan@gmail.com> * chore: rename Signed-off-by: Yuan Tang <terrytangyuan@gmail.com> --------- Signed-off-by: Yuan Tang <terrytangyuan@gmail.com> * chore: Print in-cluster svr addr disabled warning when server starts (#14553) * chore: Print in-cluster svr addr disabled warning when server starts Signed-off-by: Yuan Tang <terrytangyuan@gmail.com> * fix: mock Signed-off-by: Yuan Tang <terrytangyuan@gmail.com> * no interface change Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> --------- Signed-off-by: Yuan Tang <terrytangyuan@gmail.com> Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> --------- Signed-off-by: Yuan Tang <terrytangyuan@gmail.com> Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
crenshaw-dev
added a commit
that referenced
this pull request
Jul 24, 2023
…14684) * chore: Update log level to warn when in-cluster svr addr is disabled but internal addr is used (#14520) Signed-off-by: Yuan Tang <terrytangyuan@gmail.com> * chore: Print in-cluster svr addr disabled warning during ArgoDB initialization (#14539) * chore: Print in-cluster svr addr disabled warning during ArgoDB initialization Signed-off-by: Yuan Tang <terrytangyuan@gmail.com> * fix: undo a change Signed-off-by: Yuan Tang <terrytangyuan@gmail.com> * chore: move to a function Signed-off-by: Yuan Tang <terrytangyuan@gmail.com> * chore: rename Signed-off-by: Yuan Tang <terrytangyuan@gmail.com> --------- Signed-off-by: Yuan Tang <terrytangyuan@gmail.com> * chore: Print in-cluster svr addr disabled warning when server starts (#14553) * chore: Print in-cluster svr addr disabled warning when server starts Signed-off-by: Yuan Tang <terrytangyuan@gmail.com> * fix: mock Signed-off-by: Yuan Tang <terrytangyuan@gmail.com> * no interface change Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> --------- Signed-off-by: Yuan Tang <terrytangyuan@gmail.com> Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> --------- Signed-off-by: Yuan Tang <terrytangyuan@gmail.com> Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
crenshaw-dev
added a commit
that referenced
this pull request
Jul 24, 2023
…14685) * chore: Update log level to warn when in-cluster svr addr is disabled but internal addr is used (#14520) Signed-off-by: Yuan Tang <terrytangyuan@gmail.com> * chore: Print in-cluster svr addr disabled warning during ArgoDB initialization (#14539) * chore: Print in-cluster svr addr disabled warning during ArgoDB initialization Signed-off-by: Yuan Tang <terrytangyuan@gmail.com> * fix: undo a change Signed-off-by: Yuan Tang <terrytangyuan@gmail.com> * chore: move to a function Signed-off-by: Yuan Tang <terrytangyuan@gmail.com> * chore: rename Signed-off-by: Yuan Tang <terrytangyuan@gmail.com> --------- Signed-off-by: Yuan Tang <terrytangyuan@gmail.com> * chore: Print in-cluster svr addr disabled warning when server starts (#14553) * chore: Print in-cluster svr addr disabled warning when server starts Signed-off-by: Yuan Tang <terrytangyuan@gmail.com> * fix: mock Signed-off-by: Yuan Tang <terrytangyuan@gmail.com> * no interface change Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> --------- Signed-off-by: Yuan Tang <terrytangyuan@gmail.com> Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> --------- Signed-off-by: Yuan Tang <terrytangyuan@gmail.com> Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
crenshaw-dev
added a commit
that referenced
this pull request
Jul 24, 2023
…14686) * chore: Update log level to warn when in-cluster svr addr is disabled but internal addr is used (#14520) Signed-off-by: Yuan Tang <terrytangyuan@gmail.com> * chore: Print in-cluster svr addr disabled warning during ArgoDB initialization (#14539) * chore: Print in-cluster svr addr disabled warning during ArgoDB initialization Signed-off-by: Yuan Tang <terrytangyuan@gmail.com> * fix: undo a change Signed-off-by: Yuan Tang <terrytangyuan@gmail.com> * chore: move to a function Signed-off-by: Yuan Tang <terrytangyuan@gmail.com> * chore: rename Signed-off-by: Yuan Tang <terrytangyuan@gmail.com> --------- Signed-off-by: Yuan Tang <terrytangyuan@gmail.com> * chore: Print in-cluster svr addr disabled warning when server starts (#14553) * chore: Print in-cluster svr addr disabled warning when server starts Signed-off-by: Yuan Tang <terrytangyuan@gmail.com> * fix: mock Signed-off-by: Yuan Tang <terrytangyuan@gmail.com> * no interface change Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> --------- Signed-off-by: Yuan Tang <terrytangyuan@gmail.com> Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> --------- Signed-off-by: Yuan Tang <terrytangyuan@gmail.com> Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
yyzxw
pushed a commit
to yyzxw/argo-cd
that referenced
this pull request
Aug 9, 2023
…but internal addr is used (argoproj#14520) Signed-off-by: Yuan Tang <terrytangyuan@gmail.com>
Closed
tesla59
pushed a commit
to tesla59/argo-cd
that referenced
this pull request
Dec 16, 2023
…but internal addr is used (argoproj#14520) Signed-off-by: Yuan Tang <terrytangyuan@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These are sometimes intentional and should not be treated as errors.