Skip to content

chore: fixing 13398 by enhancing: RunCliWithRetry func #14439

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
zhaque44 wants to merge 1 commit into from
Closed

chore: fixing 13398 by enhancing: RunCliWithRetry func #14439

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion test/e2e/app_management_ns_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2298,7 +2298,6 @@ definitions:
}

func TestNamespacedAppLogs(t *testing.T) {
SkipOnEnv(t, "OPENSHIFT")
Given(t).
SetAppNamespace(AppNamespace()).
SetTrackingMethod("annotation").
Expand Down
1 change: 0 additions & 1 deletion test/e2e/app_management_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2333,7 +2333,6 @@ definitions:
}

func TestAppLogs(t *testing.T) {
SkipOnEnv(t, "OPENSHIFT")
Given(t).
Path("guestbook-logs").
When().
Expand Down
11 changes: 9 additions & 2 deletions test/e2e/fixture/fixture.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -672,13 +672,20 @@ func EnsureCleanState(t *testing.T, opts ...TestOption) {
func RunCliWithRetry(maxRetries int, args ...string) (string, error) {
var out string
var err error

out, err = RunCli(args...)
if err == nil {
return out, nil
}

for i := 0; i < maxRetries; i++ {
time.Sleep(time.Second)
out, err = RunCli(args...)
if err == nil {
break
return out, nil
}
time.Sleep(time.Second)
}

return out, err
}

Expand Down