chore: fixing 13398 by enhancing: RunCliWithRetry func#14439
Closed
zhaque44 wants to merge 1 commit intoargoproj:masterfrom
Closed
chore: fixing 13398 by enhancing: RunCliWithRetry func#14439zhaque44 wants to merge 1 commit intoargoproj:masterfrom
zhaque44 wants to merge 1 commit intoargoproj:masterfrom
Conversation
Signed-off-by: zhaque44 <haque.zubair@gmail.com>
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## master #14439 +/- ##
==========================================
- Coverage 49.73% 49.72% -0.01%
==========================================
Files 261 261
Lines 44705 44705
==========================================
- Hits 22234 22231 -3
- Misses 20284 20286 +2
- Partials 2187 2188 +1 ☔ View full report in Codecov by Sentry. |
Contributor
Author
|
this is not the best solution to resolve our issue, closing this for now |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The modified version of the
RunCliWithRetryfunc is going to be reducing flakiness of the e2e test suite in the following ways:Ticket: #13398
Reduced Retries:The func is initially called without any retries, ensuring that the command is executed at least once. This eliminates unnecessary retries when the command succeeds on the first attempt, reducing the likelihood of encountering transient failures.Delay between Retries:A delay of one second is introduced between each retry. This delay allows for potential issues, such as temporary network glitches or resource unavailability, to be resolved before reattempting the command.The new func will avoid excessive retries while still providing an opportunity for transient issues to be resolved. This results in improved reliability and reduced flakiness in end-to-end tests and CI pipelines.
Note on DCO:
If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.
Checklist:
Please see Contribution FAQs if you have questions about your pull-request.