Skip to content

chore: fixing 13398 by enhancing: RunCliWithRetry func#14439

Closed
zhaque44 wants to merge 1 commit intoargoproj:masterfrom
zhaque44:retrywithcli-function
Closed

chore: fixing 13398 by enhancing: RunCliWithRetry func#14439
zhaque44 wants to merge 1 commit intoargoproj:masterfrom
zhaque44:retrywithcli-function

Conversation

@zhaque44
Copy link
Contributor

The modified version of the RunCliWithRetry func is going to be reducing flakiness of the e2e test suite in the following ways:

Ticket: #13398

Reduced Retries: The func is initially called without any retries, ensuring that the command is executed at least once. This eliminates unnecessary retries when the command succeeds on the first attempt, reducing the likelihood of encountering transient failures.

Delay between Retries: A delay of one second is introduced between each retry. This delay allows for potential issues, such as temporary network glitches or resource unavailability, to be resolved before reattempting the command.

The new func will avoid excessive retries while still providing an opportunity for transient issues to be resolved. This results in improved reliability and reduced flakiness in end-to-end tests and CI pipelines.

Note on DCO:

If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • Optional. My organization is added to USERS.md.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.

Please see Contribution FAQs if you have questions about your pull-request.

Signed-off-by: zhaque44 <haque.zubair@gmail.com>
@codecov
Copy link

codecov bot commented Jul 10, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.01 ⚠️

Comparison is base (0cf31fb) 49.73% compared to head (3f3081e) 49.72%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #14439      +/-   ##
==========================================
- Coverage   49.73%   49.72%   -0.01%     
==========================================
  Files         261      261              
  Lines       44705    44705              
==========================================
- Hits        22234    22231       -3     
- Misses      20284    20286       +2     
- Partials     2187     2188       +1     

see 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@zhaque44
Copy link
Contributor Author

this is not the best solution to resolve our issue, closing this for now

@zhaque44 zhaque44 closed this Jul 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant