chore: add more logging for failures to get label metadata#14275
Merged
jannfis merged 5 commits intoargoproj:masterfrom Jul 1, 2023
Merged
chore: add more logging for failures to get label metadata#14275jannfis merged 5 commits intoargoproj:masterfrom
jannfis merged 5 commits intoargoproj:masterfrom
Conversation
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
jsoref
reviewed
Jun 29, 2023
Signed-off-by: jannfis <jann@mistrust.net>
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #14275 +/- ##
==========================================
- Coverage 49.76% 49.75% -0.01%
==========================================
Files 261 261
Lines 44659 44676 +17
==========================================
+ Hits 22225 22229 +4
- Misses 20249 20259 +10
- Partials 2185 2188 +3
☔ View full report in Codecov by Sentry. |
Member
Author
|
/cherry-pick release-2.8 |
Member
Author
|
Cherry picking because I think there might be a regression in 2.8 related to handling of null labels and annotations in manifests. Hoping the additional logs will help us debug. |
|
Cherry-pick failed with |
yyzxw
pushed a commit
to yyzxw/argo-cd
that referenced
this pull request
Aug 9, 2023
…14275) * chore: add more logging for failures to get label metadata Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> * context Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> * fix test Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> * fix test Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> --------- Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: jannfis <jann@mistrust.net> Co-authored-by: jannfis <jann@mistrust.net>
Closed
tesla59
pushed a commit
to tesla59/argo-cd
that referenced
this pull request
Dec 16, 2023
…14275) * chore: add more logging for failures to get label metadata Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> * context Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> * fix test Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> * fix test Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> --------- Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: jannfis <jann@mistrust.net> Co-authored-by: jannfis <jann@mistrust.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Need better error messages. https://cloud-native.slack.com/archives/C01TSERG0KZ/p1687308760074909