Skip to content

chore: [util/dex|glob] Add security logging#10455

Merged
crenshaw-dev merged 1 commit intoargoproj:masterfrom
my-git9:dexglob2
Oct 1, 2022
Merged

chore: [util/dex|glob] Add security logging#10455
crenshaw-dev merged 1 commit intoargoproj:masterfrom
my-git9:dexglob2

Conversation

@my-git9
Copy link
Member

@my-git9 my-git9 commented Aug 25, 2022

[util/dex|glob] Add security logging

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • Optional. My organization is added to USERS.md.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).

@codecov
Copy link

codecov bot commented Aug 25, 2022

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.68%. Comparing base (a23bfc3) to head (862349f).
Report is 2599 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #10455      +/-   ##
==========================================
- Coverage   45.76%   45.68%   -0.08%     
==========================================
  Files         233      236       +3     
  Lines       28401    28670     +269     
==========================================
+ Hits        12998    13099     +101     
- Misses      13629    13779     +150     
- Partials     1774     1792      +18     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@my-git9 my-git9 changed the title [util/dex|glob] Add security logging chore: [util/dex|glob] Add security logging Aug 27, 2022
@jannfis
Copy link
Member

jannfis commented Aug 29, 2022

Thanks @my-git9

Can you please elaborate a little on the security impact of these errors, i.e. why should they emit a security log event? Thanks!

@my-git9
Copy link
Member Author

my-git9 commented Aug 29, 2022

Thanks @my-git9

Can you please elaborate a little on the security impact of these errors, i.e. why should they emit a security log event? Thanks!
Discussions and PRs about security logs are here, please see
#10361 (comment)
#10256

@jannfis
Copy link
Member

jannfis commented Aug 29, 2022

Yes, thanks, I'm aware of this. I was just wondering how the parts of the code you are adding it to are relevant to emit security logging?

Just trying to understand the reasoning behind this particular change.

@notfromstatefarm
Copy link
Contributor

The dex error I can see being useful for security logging - dex is a wholly security-related service. However, logging any time a glob fails to compile anywhere in our codebase doesn't seem security-related.

@my-git9
Copy link
Member Author

my-git9 commented Aug 29, 2022

I see, I'll tweak the code a bit

@my-git9
Copy link
Member Author

my-git9 commented Aug 29, 2022

@notfromstatefarm @jannfis I'm sorry, I don't know enough about security logs. Can you think of this?

Signed-off-by: xin.li <xin.li@daocloud.io>
Copy link
Member

@crenshaw-dev crenshaw-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @my-git9!

@crenshaw-dev crenshaw-dev merged commit eb1bed0 into argoproj:master Oct 1, 2022
ashutosh16 pushed a commit to ashutosh16/argo-cd that referenced this pull request Oct 7, 2022
Signed-off-by: xin.li <xin.li@daocloud.io>

Signed-off-by: xin.li <xin.li@daocloud.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants