chore: [util/dex|glob] Add security logging#10455
chore: [util/dex|glob] Add security logging#10455crenshaw-dev merged 1 commit intoargoproj:masterfrom
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #10455 +/- ##
==========================================
- Coverage 45.76% 45.68% -0.08%
==========================================
Files 233 236 +3
Lines 28401 28670 +269
==========================================
+ Hits 12998 13099 +101
- Misses 13629 13779 +150
- Partials 1774 1792 +18 ☔ View full report in Codecov by Sentry. |
|
Thanks @my-git9 Can you please elaborate a little on the security impact of these errors, i.e. why should they emit a security log event? Thanks! |
|
|
Yes, thanks, I'm aware of this. I was just wondering how the parts of the code you are adding it to are relevant to emit security logging? Just trying to understand the reasoning behind this particular change. |
|
The dex error I can see being useful for security logging - dex is a wholly security-related service. However, logging any time a glob fails to compile anywhere in our codebase doesn't seem security-related. |
|
I see, I'll tweak the code a bit |
|
@notfromstatefarm @jannfis I'm sorry, I don't know enough about security logs. Can you think of this? |
Signed-off-by: xin.li <xin.li@daocloud.io>
Signed-off-by: xin.li <xin.li@daocloud.io> Signed-off-by: xin.li <xin.li@daocloud.io>
[util/dex|glob] Add security logging
Checklist: