chore: add security logging and cwe fields#10256
Merged
crenshaw-dev merged 3 commits intoargoproj:masterfrom Aug 17, 2022
Merged
chore: add security logging and cwe fields#10256crenshaw-dev merged 3 commits intoargoproj:masterfrom
crenshaw-dev merged 3 commits intoargoproj:masterfrom
Conversation
Signed-off-by: notfromstatefarm <86763948+notfromstatefarm@users.noreply.github.com>
Signed-off-by: notfromstatefarm <86763948+notfromstatefarm@users.noreply.github.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #10256 +/- ##
==========================================
- Coverage 46.18% 46.16% -0.02%
==========================================
Files 226 226
Lines 27581 27595 +14
==========================================
+ Hits 12737 12739 +2
- Misses 13124 13136 +12
Partials 1720 1720 ☔ View full report in Codecov by Sentry. |
5 tasks
crenshaw-dev
requested changes
Aug 9, 2022
Signed-off-by: notfromstatefarm <86763948+notfromstatefarm@users.noreply.github.com>
crenshaw-dev
approved these changes
Aug 11, 2022
Member
crenshaw-dev
left a comment
There was a problem hiding this comment.
I'm in favor of the changes as presented. Thanks @notfromstatefarm!
Contributor
Author
|
Here's a flowchart on how to decide which level to use. Do you think we should include this in the docs @crenshaw-dev ? |
Member
|
@notfromstatefarm I like that! The phrase "has a vulnerability been exposed" seems slightly ambiguous to me though. I'm not sure whether there's a succinct way to clarify. |
Member
10 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


As discussed with the security SIG, this PR implements a
securityandcwefield to be used in logs and standardizes which level should be used. Obviously there is much more work to be done as I have only added this to a couple of logs, but this lays the foundations so that hopefully we can cover a good amount of ground in separate PRs by the v2.5 release.This will be 'good first issue' heaven.
Proposed levels:
credit to @crenshaw-dev for the idea!
cc @crenshaw-dev @jessesuen @todaywasawesome