Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Upgrade argocd version to 2.13.1 #1606

Closed
wants to merge 7 commits into from

Conversation

Mangaal
Copy link
Contributor

@Mangaal Mangaal commented Nov 21, 2024

What type of PR is this?
Upgrade ArgoCD version to 2.13.1

/kind chore

What does this PR do / why we need it:

Have you updated the necessary documentation?

  • Documentation update is required by this PR.
  • Documentation has been updated.

Which issue(s) this PR fixes:

Fixes #?

How to test changes / Special notes to the reviewer:

Mangaal and others added 5 commits November 21, 2024 11:22
@svghadi svghadi marked this pull request as ready for review November 21, 2024 07:19
Signed-off-by: Siddhesh Ghadi <[email protected]>
Copy link
Collaborator

@anandf anandf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Siddhesh Ghadi <[email protected]>
@svghadi
Copy link
Collaborator

svghadi commented Nov 21, 2024

make install failure

The CustomResourceDefinition "argocds.argoproj.io" is invalid: 
* spec.versions[0].schema.openAPIV3Schema.properties[spec].properties[repo].properties[initContainers].items.properties[ports].items.properties[protocol].allOf[0].default: Forbidden: must be undefined to be structural
* spec.versions[0].schema.openAPIV3Schema.properties[spec].properties[repo].properties[initContainers].items.properties[ports].items.properties[protocol].allOf[1].default: Forbidden: must be undefined to be structural
* spec.versions[0].schema.openAPIV3Schema.properties[spec].properties[repo].properties[sidecarContainers].items.properties[ports].items.properties[protocol].allOf[0].default: Forbidden: must be undefined to be structural
* spec.versions[0].schema.openAPIV3Schema.properties[spec].properties[repo].properties[sidecarContainers].items.properties[ports].items.properties[protocol].allOf[1].default: Forbidden: must be undefined to be structural
* spec.versions[0].schema.openAPIV3Schema.properties[spec].properties[repo].properties[initContainers].items.properties[ports].items.properties[protocol].default: Required value: this property is in x-kubernetes-list-map-keys, so it must have a default or be a required property
* spec.versions[0].schema.openAPIV3Schema.properties[spec].properties[repo].properties[sidecarContainers].items.properties[ports].items.properties[protocol].default: Required value: this property is in x-kubernetes-list-map-keys, so it must have a default or be a required property
* spec.versions[1].schema.openAPIV3Schema.properties[spec].properties[controller].properties[initContainers].items.properties[ports].items.properties[protocol].allOf[0].default: Forbidden: must be undefined to be structural
* spec.versions[1].schema.openAPIV3Schema.properties[spec].properties[controller].properties[initContainers].items.properties[ports].items.properties[protocol].allOf[1].default: Forbidden: must be undefined to be structural
* spec.versions[1].schema.openAPIV3Schema.properties[spec].properties[controller].properties[sidecarContainers].items.properties[ports].items.properties[protocol].allOf[0].default: Forbidden: must be undefined to be structural
* spec.versions[1].schema.openAPIV3Schema.properties[spec].properties[controller].properties[sidecarContainers].items.properties[ports].items.properties[protocol].allOf[1].default: Forbidden: must be undefined to be structural
* spec.versions[1].schema.openAPIV3Schema.properties[spec].properties[repo].properties[initContainers].items.properties[ports].items.properties[protocol].allOf[0].default: Forbidden: must be undefined to be structural
* spec.versions[1].schema.openAPIV3Schema.properties[spec].properties[repo].properties[initContainers].items.properties[ports].items.properties[protocol].allOf[1].default: Forbidden: must be undefined to be structural
* spec.versions[1].schema.openAPIV3Schema.properties[spec].properties[repo].properties[sidecarContainers].items.properties[ports].items.properties[protocol].allOf[0].default: Forbidden: must be undefined to be structural
* spec.versions[1].schema.openAPIV3Schema.properties[spec].properties[repo].properties[sidecarContainers].items.properties[ports].items.properties[protocol].allOf[1].default: Forbidden: must be undefined to be structural
* spec.versions[1].schema.openAPIV3Schema.properties[spec].properties[server].properties[initContainers].items.properties[ports].items.properties[protocol].allOf[0].default: Forbidden: must be undefined to be structural
* spec.versions[1].schema.openAPIV3Schema.properties[spec].properties[server].properties[initContainers].items.properties[ports].items.properties[protocol].allOf[1].default: Forbidden: must be undefined to be structural
* spec.versions[1].schema.openAPIV3Schema.properties[spec].properties[server].properties[sidecarContainers].items.properties[ports].items.properties[protocol].allOf[0].default: Forbidden: must be undefined to be structural
* spec.versions[1].schema.openAPIV3Schema.properties[spec].properties[server].properties[sidecarContainers].items.properties[ports].items.properties[protocol].allOf[1].default: Forbidden: must be undefined to be structural
* spec.versions[1].schema.openAPIV3Schema.properties[spec].properties[controller].properties[initContainers].items.properties[ports].items.properties[protocol].default: Required value: this property is in x-kubernetes-list-map-keys, so it must have a default or be a required property
* spec.versions[1].schema.openAPIV3Schema.properties[spec].properties[controller].properties[sidecarContainers].items.properties[ports].items.properties[protocol].default: Required value: this property is in x-kubernetes-list-map-keys, so it must have a default or be a required property
* spec.versions[1].schema.openAPIV3Schema.properties[spec].properties[repo].properties[sidecarContainers].items.properties[ports].items.properties[protocol].default: Required value: this property is in x-kubernetes-list-map-keys, so it must have a default or be a required property
* spec.versions[1].schema.openAPIV3Schema.properties[spec].properties[repo].properties[initContainers].items.properties[ports].items.properties[protocol].default: Required value: this property is in x-kubernetes-list-map-keys, so it must have a default or be a required property
* spec.versions[1].schema.openAPIV3Schema.properties[spec].properties[server].properties[sidecarContainers].items.properties[ports].items.properties[protocol].default: Required value: this property is in x-kubernetes-list-map-keys, so it must have a default or be a required property
* spec.versions[1].schema.openAPIV3Schema.properties[spec].properties[server].properties[initContainers].items.properties[ports].items.properties[protocol].default: Required value: this property is in x-kubernetes-list-map-keys, so it must have a default or be a required property
make: *** [install] Error 1

@svghadi
Copy link
Collaborator

svghadi commented Nov 21, 2024

The k8s upgrade didn't go as planned. There are validation errors on CRD. We will revisit the upgrade for next release as we are already in code-freeze and don't want to make any major changes.
Pinning the github.com/argoproj/argo-cd/v2dep to v2.12.3 for now which is causing failures. The operator code base doesn't use any core funcs from this library and imports it only for some util funcs so it's shouldn't be a problem to pin is for few releases.

@svghadi svghadi closed this Nov 21, 2024
@svghadi svghadi mentioned this pull request Nov 21, 2024
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants