Feat: Automated release to GitHub and GHCR#193
Conversation
Codecov Report
@@ Coverage Diff @@
## master #193 +/- ##
=======================================
Coverage 51.53% 51.53%
=======================================
Files 34 34
Lines 1690 1690
=======================================
Hits 871 871
Misses 647 647
Partials 172 172 Continue to review full report at Codecov.
|
| push: true | ||
| tags: | | ||
| argoproj-labs/argocd-notifications:${{ env.IMAGE_TAG }} | ||
| argoproj-labs/argocd-notifications:latest |
There was a problem hiding this comment.
Ops, I just realized that I incorrectly asked to avoid pushing the latest tag as part of CI workflow #190 . Sorry
Typically latest tag has latest code. @mylesagray , do you mind to move ghcr.io/argoproj-labs/argocd-notifications:latest and argoproj-labs/argocd-notifications:latest tags to https://github.com/argoproj-labs/argocd-notifications/blob/master/.github/workflows/ci.yaml#L69 ?
There was a problem hiding this comment.
@alexmt I've made those changes to the PR - So I can understand the desired outcome:
- CI builds on every push to master and always tags latest (no discrete commit based hash tags desired here?)
- Release builds are manual only - and will derive their tag appending
vto the output of$(cat ./VERSION)
Is that what you're after?
Thoughts on adding a tag for commit hash to the CI images too in addition to latest tag so commits can be easier tested?
There was a problem hiding this comment.
Is that what you're after?
Yes, thank you for making the change!
Thoughts on adding a tag for commit hash to the CI images too in addition to latest tag so commits can be easier tested?
I think it is a good idea but only for ghcr.io/argoproj-labs/argocd-notifications . We are trying to have only officially released images in dockerhub.com/argoproj-labs and dockerhub.com/argoproj .
alexmt
left a comment
alexmt
left a comment
There was a problem hiding this comment.
PR is still "draft" looks ready for review, is not it? Can you "move" it to ready for review state?
|
Made ready for review |
2 participants
As per discussion in #190 - this adds support for automatic releases to DockerHub and GHCR.
This workflow can only be invoked via the "Run workflow" in the GitHub Actions UI.
It will publish images with tags reflecting what is in
Makefile- the output of "v" +VERSIONfile and will tag whatever image that is with thelatesttag as well.I have noted on DockerHub that the image tags are of format
v1.0.0and this PR reflects that - would we rather a different tagging scheme or is this okay? /cc @alexmt for 👀