Migrated from deprecated to GitHub Packages to GHCR#190
Migrated from deprecated to GitHub Packages to GHCR#190alexmt merged 2 commits intoargoproj-labs:masterfrom mylesagray:master
Conversation
Codecov Report
@@ Coverage Diff @@
## master #190 +/- ##
==========================================
- Coverage 52.69% 51.53% -1.16%
==========================================
Files 33 34 +1
Lines 1577 1690 +113
==========================================
+ Hits 831 871 +40
- Misses 586 647 +61
- Partials 160 172 +12
Continue to review full report at Codecov.
|
alexmt
left a comment
alexmt
left a comment
There was a problem hiding this comment.
Thank you @mylesagray . Added one comment
| push: true | ||
| tags: docker.pkg.github.com/argoproj-labs/argocd-notifications/argocd-notifications:${{ env.IMAGE_TAG }} | ||
| tags: | | ||
| argoproj-labs/argocd-notifications:${{ env.IMAGE_TAG }} |
There was a problem hiding this comment.
Can we avoid pushing non latest tag to argoproj-labs ?
We are trying to use dockerhub/argoproj-labs only for official releases. I was hoping to automate it using separate GH action workflow that is triggered manually (similar to https://github.com/argoproj/argo-cd/blob/master/.github/workflows/release.yaml)
There was a problem hiding this comment.
@alexmt Would a model similar to this work: https://github.com/argoproj/argo-cd/blob/master/.github/workflows/release.yaml#L2-L12 were only pushes with specific tags cause a push to DockerHub? or do you want it totally manual "click a UI button"?
Additionally, when pushing to DH if we choose the above model where it pushed actual tagged releases and the latest tag - is that acceptable, or are you asking for it to only ever push one image tagged latest and ignore all of the v1.x.x tags?
I can set up two actions workflows then, one for CI for general PRs and merges like we currently have, and another for tagged branches that are actual "releases" if that's what you're after.
There was a problem hiding this comment.
I was thinking about Argo CD model - it uses tag with a special name as trigger. After I've learned about workflow_dispatch from your previous PR and now hoping to use Github UI instead. I'm asking to push only to 'latest' on every push to master.
I can set up two actions workflows then, one for CI for general PRs and merges like we currently have, and another for tagged branches that are actual "releases" if that's what you're after.
Very appreciate your help here!
If you don't mind can you remove vx.x.x tag pushes in this PR ( just want to get CI green ) and work on release workflow in next PR?
There was a problem hiding this comment.
Works for me, let me open another PR for that!
There was a problem hiding this comment.
Fixed @alexmt, will now only push latest :)
There was a problem hiding this comment.
@alexmt on the failure - you need to provide the repo secrets:
GH_USERNAME - a user with ownership over the argoproj-labs GH Org
GH_PAT - a personal access token with package:read, package:write and package:delete permissions. more here: https://docs.github.com/en/packages/guides/migrating-to-github-container-registry-for-docker-images#authenticating-with-the-container-registry
There was a problem hiding this comment.
mylesagray
changed the title
2 participants
Per comments in #184 I have migrated the CI workflow from the deprecated GitHub Packages to the new GitHub Container Registry.
Note that images will be tagged the same way they are today - and an additional
:latesttag will be added to each push as well.This PR will need a few things done before it is merged:
package:read,package:writeandpackage:deletepermissions. more here: https://docs.github.com/en/packages/guides/migrating-to-github-container-registry-for-docker-images#authenticating-with-the-container-registryOnce those pre-reqs are met this is safe to merge and should auto build and push fresh multi-arch images to both repos!
/cc @alexmt