Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix MQTT Reconnection Bug #3558

Merged
merged 2 commits into from
Aug 23, 2018
Merged

Fix MQTT Reconnection Bug #3558

merged 2 commits into from
Aug 23, 2018

Conversation

ascillato
Copy link
Contributor

If you restart your wifi router, and you have Tasmota_MQTT Library with wificonfig 5, Tasmota don't realize of this MQTT disconnection.

This solves issue #3314

If you restart your wifi router, and you have Tasmota_MQTT Library with wificonfig 5, Tasmota don't realize of this MQTT disconnection.
@ascillato2 ascillato2 changed the title Fixed MQTT Reconnection Bug Fix MQTT Reconnection Bug Aug 23, 2018
@ascillato
Copy link
Contributor Author

After several tests of this Tasmota_MQTT Library I found it very reliable. Please, consider adding this library as default. Thanks.

@uberflyx
Copy link

Thank you so much! This bug has been destroying my life for ages! ;)

@arendst arendst merged commit 640e346 into arendst:development Aug 23, 2018
@wongnam
Copy link

wongnam commented Aug 23, 2018

Good jobs! Thank you so much!

arendst added a commit that referenced this pull request Aug 23, 2018
6.1.1.8
 * Fix MQTT reconnection detection when using TasmotaMqtt library (#3558)
 * Add build time setting of ButtonTopic and SwitchTopic (#3414)
 * Add display features and dynamic buffering
@ascillato ascillato deleted the patch-1 branch August 25, 2018 13:16
curzon01 pushed a commit to curzon01/Tasmota that referenced this pull request Sep 7, 2018
curzon01 pushed a commit to curzon01/Tasmota that referenced this pull request Sep 7, 2018
6.1.1.8
 * Fix MQTT reconnection detection when using TasmotaMqtt library (arendst#3558)
 * Add build time setting of ButtonTopic and SwitchTopic (arendst#3414)
 * Add display features and dynamic buffering
@meingraham
Copy link
Collaborator

Trying to confirm that the newest development branches now default to using PubsClient again, resolve this issue as well. That, as of now, the recommendation is, if we're compiling our own firmware images, to switch back to using PubsClient over TASMOTA_MQTT because it addresses this problem and also has a smaller memory footprint. Is this an accurate statement?

@ascillato
Copy link
Contributor Author

yes, thanks 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants