Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build time setting of button and switch topic #3414

Merged

Conversation

emontnemery
Copy link
Contributor

Add build time setting of button and switch topic.

Update ButtonTopic and SwitchTopic commands with option 2 to revert back to build time topic:

ButtonTopic   Show current MQTT button topic
ButtonTopic 0 / off Disable use of MQTT button topic
ButtonTopic 1 Set MQTT button topic to Topic
ButtonTopic 2 Set MQTT button topic to user_config.h(MQTT_BUTTON_TOPIC)
ButtonTopic Set MQTT button topic (32 chars max)

Note: This is an improved version of similar change in #2277 which was reverted in 914c292

@arendst
Copy link
Owner

arendst commented Aug 11, 2018

Will investigate.

@arendst arendst added the enhancement Type - Enhancement that will be worked on label Aug 11, 2018
@andrethomas
Copy link
Contributor

@emontnemery Are you planning on building individual binaries for your sonoff devices?

@emontnemery
Copy link
Contributor Author

emontnemery commented Aug 13, 2018

@andrethomas Not really, I want to be able to build a binary which can be auto detected by domoticz with 0 additional configuration in sonoff console/webui.

By doing:
#define MQTT_BUTTON_TOPIC PROJECT "_BTN_%06X"
the buttons on the devices will be discovered by Domoticz with a unique topic.

The reason is using Sonoff T1 devices as light switches, it's a lot of additional manual steps if each device has to be manually configured.

@andrethomas
Copy link
Contributor

Ok, that makes sense... was a bit confused by the initial information in the PR, my bad :)

@arendst arendst merged commit 1e3a897 into arendst:development Aug 23, 2018
arendst added a commit that referenced this pull request Aug 23, 2018
6.1.1.8
 * Fix MQTT reconnection detection when using TasmotaMqtt library (#3558)
 * Add build time setting of ButtonTopic and SwitchTopic (#3414)
 * Add display features and dynamic buffering
curzon01 pushed a commit to curzon01/Tasmota that referenced this pull request Sep 7, 2018
…itch_topic

Build time setting of button and switch topic
curzon01 pushed a commit to curzon01/Tasmota that referenced this pull request Sep 7, 2018
6.1.1.8
 * Fix MQTT reconnection detection when using TasmotaMqtt library (arendst#3558)
 * Add build time setting of ButtonTopic and SwitchTopic (arendst#3414)
 * Add display features and dynamic buffering
@emontnemery emontnemery deleted the build_time_button_switch_topic branch December 8, 2018 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Type - Enhancement that will be worked on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants