Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed a couple of bugs and many warnings #1774

Closed
wants to merge 1 commit into from
Closed

Fixed a couple of bugs and many warnings #1774

wants to merge 1 commit into from

Conversation

projectkk2glider
Copy link

that were found with -Wextra compiler flags

projectkk2glider
projectkk2glider commented Feb 3, 2018
View reviewed changes
sonoff/xsns_08_htu21.ino
@@ -206,6 +206,7 @@ float HtuCompensatedHumidity(float humidity, float temperature)
if(temperature > 0.00 && temperature < 80.00) {
return (-0.15)*(25-temperature)+humidity;
}
return humidity; // TODO is this correct?
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure about the correctness of the return value, but the return statement was missing.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes humidity is fine.

@arendst
Copy link
Owner

arendst commented Feb 3, 2018

In next pre-release

arendst added a commit that referenced this pull request Feb 3, 2018
@arendst
v5.11.1i - Add S31 support and some fixes
12f13a3 
5.11.1i
 * Update TasmotaSerial library to 1.1.0
 * Rename commands
HlwPCal, HlwUCal and HlwICal to PowerCal, VoltageCal and CurrentCal to
be used for both Pow and S31 calibration
 * Rename commands HlwPSet,
HlwUSet and HlwISet to PowerSet, VoltageSet and CurrentSet to be used
for both Pow and S31 calibration
 * Add support for Sonoff S31 Smart
Socket with Power Consumption Detection (#1626)
 * Fix IRReceive Data
value (#1663)
 * Fix compiler warnings (#1774)
@arendst arendst closed this Feb 3, 2018
arendst added a commit that referenced this pull request Feb 9, 2018
@arendst
v5.12.0
600c4b1 
5.12.0 20180209
* Change library PubSubClient.h define MQTT_MAX_PACKET_SIZE from 512 to
1000 for Home Assistant  support
* Change relation of define MESSZ being dependent on PubSubClient.h
define MQTT_MAX_PACKET_SIZE
* Change command color parameter input checks to less strict for Home
Assistant support
* Change command Ina219Mode into command Sensor13
* Change commands HlwPCal, HlwUCal and HlwICal to PowerCal, VoltageCal
and CurrentCal to be used for both Pow and S31 calibration
* Change commands HlwPSet, HlwUSet and HlwISet to PowerSet, VoltageSet
and CurrentSet to be used for both Pow and S31 calibration
* Change uptime from hour to second resulting in a display of
123T13:45:21 where 123 is days
* Change module name Wemos D1 mini into Generic (#1220)
* Change HTML from width=100% to style=width:100% supporting HTML5
(#1358)
* Change OSWATCH_RESET_TIME (Blocked loop) from 30 to 120 seconds to
allow slow networks (#1556)
* Change WIFI_MANAGER_SEC into WIFI_CONFIG_SEC (#1616)
* Change function pointers code to save code space and memory (#1683)
* Change webserver argument processing gaining 5k code space (#1705)
* Change weblog memory usage (#1730, #1793, #1819)
* Update TasmotaSerial library to 1.1.0
* Update language files Italian (#1594), Dutch (#1723) and Spanish
(#1722)
* Fix Non-English JSON temperature unit attachement
* Fix Arilux RF induced exception by moving interrupt handler to iram on
non ESP8266/Arduino lib v2.3.0
* Fix truncated command names and wrong response for DomoticzSwitchIdx
(#1571)
* Fix %-sign issue as printf escape character in Humidity and Sonoff SC
(#1579)
* Fix DS18B20 temperature JSON decimal dot (#1561)
* Fix Energy JSON message (#1621)
* Fix IRSend parameter translation (#1636)
* Fix TSL2561 device detection (#1644, #1825)
* Fix BME680 teleperiod resistance measuring (#1647)
* Fix Energy Monitoring Energy Today and Energy Total reading after
restart (#1648)
* Fix IRReceive Data value (#1663)
* Fix Energy Monitoring Energy Period roll-over (#1688)
* Fix compiler warnings (#1774)
* Fix command PWM response if no PWM channel is configured (#1783)
* Add locale Decimal Separator to Web sensor page
* Add ColorTemperature to light status message
* Add command PowerOnState option 5 which inverts PulseTime and allows
for delayed always on after power on
* Add OtaMagic two step Web server OTA upgrade using filename-minimal
image if OTA free space is too small
* Add support for PMS5003 and PMS7003 particle concentration sensor
* Add command SetOption21 1 to allow Energy Monitoring when power is off
on Sonoff Pow and Sonoff S31 (#1420)
* Add Chinese language file (#1551)
* Add French language file (#1561)
* Add Spanish language file (#1589)
* Add HTTP Allow Cross Origin removed from ESP8266/Arduino lib v2.4.0
(#1572)
* Add Home Assistant MQTT Discovery for switch and light to be enabled
by command SetOption19 1 (#1534) or define
HOME_ASSISTANT_DISCOVERY_ENABLE in user_config.h (#1685)
* Add command State to retrieve device state information (same data as
teleperiod state and status 11 in slightly different JSON format)
* Add optional login to Webserver AP mode (#1587, #1635)
* Add command Sensor15 2 to start MHZ19(B) Zero Point Calibration
(#1643)
* Add support for Sonoff S31 Smart Socket with Power Consumption
Detection (#1626)
* Add command SetOption20 to allow update of Dimmer/Color/Ct without
turning power on (#1719, #1741)
* Add NTP sync time slot based on chip id (#1773)
* Add cursor pointer to web button (#1836)
curzon01 pushed a commit to curzon01/Tasmota that referenced this pull request Sep 6, 2018
@arendst
v5.11.1i - Add S31 support and some fixes
1f4e3fb 
5.11.1i
 * Update TasmotaSerial library to 1.1.0
 * Rename commands
HlwPCal, HlwUCal and HlwICal to PowerCal, VoltageCal and CurrentCal to
be used for both Pow and S31 calibration
 * Rename commands HlwPSet,
HlwUSet and HlwISet to PowerSet, VoltageSet and CurrentSet to be used
for both Pow and S31 calibration
 * Add support for Sonoff S31 Smart
Socket with Power Consumption Detection (arendst#1626)
 * Fix IRReceive Data
value (arendst#1663)
 * Fix compiler warnings (arendst#1774)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arendst arendst arendst left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@projectkk2glider @arendst