Skip to content

gov: add maintainer and refine commit convention #1227

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
garrett4wade merged 1 commit into from
Apr 22, 2026
Merged

gov: add maintainer and refine commit convention #1227

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 27 additions & 9 deletions .agents/skills/commit-conventions/SKILL.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,15 +33,20 @@ Refs: #123, #456

## Type Selection

| Type | When to Use |
| ---------- | ------------------------------- |
| `feat` | New feature or capability |
| `fix` | Bug fix |
| `docs` | Documentation only |
| `refactor` | Code change without feature/fix |
| `test` | Adding or fixing tests |
| `chore` | Build, deps, config changes |
| `perf` | Performance improvement |
| Type | When to Use |
| ---------- | -------------------------------- |
| `feat` | New feature or capability |
| `fix` | Bug fix |
| `docs` | Documentation only |
| `gov` | Governance or maintainer changes |
| `style` | Formatting/style-only changes |
| `refactor` | Code change without feature/fix |
| `perf` | Performance improvement |
| `test` | Adding or fixing tests |
| `build` | Build system or dependencies |
| `ci` | CI pipeline or workflow changes |
| `chore` | Build, deps, config changes |
| `revert` | Revert a previous commit |

## Scope Inference

Expand Down Expand Up @@ -119,6 +124,19 @@ Key changes:
- Add expert subagent consultation patterns
```

**Governance/maintainer changes:**

```
gov(agents): add maintainer ownership for service modules

Update CODEOWNERS and maintainer references to reflect
current governance responsibilities.

Key changes:
- Add maintainers for agent_service and infra ownership
- Align governance docs with updated reviewer responsibilities
```

______________________________________________________________________

<!--
Expand Down
23 changes: 14 additions & 9 deletions .claude/commands/create-pr.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -221,15 +221,20 @@ git log --oneline origin/main..HEAD

Follow same categorization as the `commit-conventions` skill:

| Type | When to Use |
| ---------- | ------------------------------- |
| `feat` | New feature or capability |
| `fix` | Bug fix |
| `docs` | Documentation only |
| `refactor` | Code change without feature/fix |
| `test` | Adding or fixing tests |
| `chore` | Build, deps, config changes |
| `perf` | Performance improvement |
| Type | When to Use |
| ---------- | -------------------------------- |
| `feat` | New feature or capability |
| `fix` | Bug fix |
| `docs` | Documentation only |
| `gov` | Governance or maintainer changes |
| `style` | Formatting/style-only changes |
| `refactor` | Code change without feature/fix |
| `perf` | Performance improvement |
| `test` | Adding or fixing tests |
| `build` | Build system or dependencies |
| `ci` | CI pipeline or workflow changes |
| `chore` | Build, deps, config changes |
| `revert` | Revert a previous commit |

**Determine Scope:**

Expand Down
23 changes: 14 additions & 9 deletions .claude/commands/gen-commit-msg.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,15 +35,20 @@ git log --oneline -5

### Step 2: Categorize Changes

| Type | When to Use |
| ---------- | ------------------------------- |
| `feat` | New feature or capability |
| `fix` | Bug fix |
| `docs` | Documentation only |
| `refactor` | Code change without feature/fix |
| `test` | Adding or fixing tests |
| `chore` | Build, deps, config changes |
| `perf` | Performance improvement |
| Type | When to Use |
| ---------- | -------------------------------- |
| `feat` | New feature or capability |
| `fix` | Bug fix |
| `docs` | Documentation only |
| `gov` | Governance or maintainer changes |
| `style` | Formatting/style-only changes |
| `refactor` | Code change without feature/fix |
| `perf` | Performance improvement |
| `test` | Adding or fixing tests |
| `build` | Build system or dependencies |
| `ci` | CI pipeline or workflow changes |
| `chore` | Build, deps, config changes |
| `revert` | Revert a previous commit |

### Step 3: Determine Scope

Expand Down
36 changes: 27 additions & 9 deletions .claude/skills/commit-conventions/SKILL.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,15 +33,20 @@ Refs: #123, #456

## Type Selection

| Type | When to Use |
| ---------- | ------------------------------- |
| `feat` | New feature or capability |
| `fix` | Bug fix |
| `docs` | Documentation only |
| `refactor` | Code change without feature/fix |
| `test` | Adding or fixing tests |
| `chore` | Build, deps, config changes |
| `perf` | Performance improvement |
| Type | When to Use |
| ---------- | -------------------------------- |
| `feat` | New feature or capability |
| `fix` | Bug fix |
| `docs` | Documentation only |
| `gov` | Governance or maintainer changes |
| `style` | Formatting/style-only changes |
| `refactor` | Code change without feature/fix |
| `perf` | Performance improvement |
| `test` | Adding or fixing tests |
| `build` | Build system or dependencies |
| `ci` | CI pipeline or workflow changes |
| `chore` | Build, deps, config changes |
| `revert` | Revert a previous commit |

## Scope Inference

Expand Down Expand Up @@ -119,6 +124,19 @@ Key changes:
- Add expert subagent consultation patterns
```

**Governance/maintainer changes:**

```
gov(agents): add maintainer ownership for service modules

Update CODEOWNERS and maintainer references to reflect
current governance responsibilities.

Key changes:
- Add maintainers for agent_service and infra ownership
- Align governance docs with updated reviewer responsibilities
```

______________________________________________________________________

<!--
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/pre-commit.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ jobs:
FAILED=0
for SHA in $(git log --no-merges --format=%H origin/${{ github.base_ref }}..HEAD); do
git log --format=%B -1 "$SHA" > /tmp/commit_msg
if ! conventional-pre-commit feat fix docs style refactor perf test build ci chore revert /tmp/commit_msg; then
if ! conventional-pre-commit feat fix docs gov style refactor perf test build ci chore revert /tmp/commit_msg; then
echo "❌ Bad commit: $(git log --format=%s -1 "$SHA")"
FAILED=1
fi
Expand Down
23 changes: 14 additions & 9 deletions .opencode/command/create-pr.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -162,15 +162,20 @@ git log --oneline origin/main..HEAD

Follow same categorization as the `commit-conventions` skill:

| Type | When to Use |
| ---------- | ------------------------------- |
| `feat` | New feature or capability |
| `fix` | Bug fix |
| `docs` | Documentation only |
| `refactor` | Code change without feature/fix |
| `test` | Adding or fixing tests |
| `chore` | Build, deps, config changes |
| `perf` | Performance improvement |
| Type | When to Use |
| ---------- | -------------------------------- |
| `feat` | New feature or capability |
| `fix` | Bug fix |
| `docs` | Documentation only |
| `gov` | Governance or maintainer changes |
| `style` | Formatting/style-only changes |
| `refactor` | Code change without feature/fix |
| `perf` | Performance improvement |
| `test` | Adding or fixing tests |
| `build` | Build system or dependencies |
| `ci` | CI pipeline or workflow changes |
| `chore` | Build, deps, config changes |
| `revert` | Revert a previous commit |

**Determine Scope:**

Expand Down
36 changes: 27 additions & 9 deletions .opencode/skills/commit-conventions/SKILL.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,15 +33,20 @@ Refs: #123, #456

## Type Selection

| Type | When to Use |
| ---------- | ------------------------------- |
| `feat` | New feature or capability |
| `fix` | Bug fix |
| `docs` | Documentation only |
| `refactor` | Code change without feature/fix |
| `test` | Adding or fixing tests |
| `chore` | Build, deps, config changes |
| `perf` | Performance improvement |
| Type | When to Use |
| ---------- | -------------------------------- |
| `feat` | New feature or capability |
| `fix` | Bug fix |
| `docs` | Documentation only |
| `gov` | Governance or maintainer changes |
| `style` | Formatting/style-only changes |
| `refactor` | Code change without feature/fix |
| `perf` | Performance improvement |
| `test` | Adding or fixing tests |
| `build` | Build system or dependencies |
| `ci` | CI pipeline or workflow changes |
| `chore` | Build, deps, config changes |
| `revert` | Revert a previous commit |

## Scope Inference

Expand Down Expand Up @@ -119,6 +124,19 @@ Key changes:
- Add expert subagent consultation patterns
```

**Governance/maintainer changes:**

```
gov(agents): add maintainer ownership for service modules

Update CODEOWNERS and maintainer references to reflect
current governance responsibilities.

Key changes:
- Add maintainers for agent_service and infra ownership
- Align governance docs with updated reviewer responsibilities
```

______________________________________________________________________

<!--
Expand Down
1 change: 1 addition & 0 deletions .pre-commit-config.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,6 +108,7 @@ repos:
- feat
- fix
- docs
- gov
- style
- refactor
- perf
Expand Down
4 changes: 2 additions & 2 deletions AGENTS.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -232,8 +232,8 @@ ______________________________________________________________________
## Collaboration & review

- **Branches**: kebab-case (`feature/multi-turn-metrics`, `bugfix/fsdp-weight-sync`).
- **Commits**: Conventional Commits (`feat:`, `fix:`, `docs:`), ~72 char subject,
imperative voice. Squash WIP before PR.
- **Commits**: Conventional Commits (e.g., `feat:`, `fix:`, `docs:`, `gov:`), ~72 char
subject, imperative voice. Squash WIP before PR.
- **Pre-merge**: full pre-commit stack; doc-only edits need at least `mdformat --check`.
- **PRs**: tie to issue, highlight risk areas, list test commands executed, note skipped
suites with reasons.
Expand Down
4 changes: 2 additions & 2 deletions CLAUDE.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,8 +108,8 @@ uv run python docs/generate_cli_docs.py

## Git Workflow

- **Commits**: Conventional Commits (`feat:`, `fix:`, `docs:`), ~72 chars subject,
imperative voice, reasoning in body
- **Commits**: Conventional Commits (e.g., `feat:`, `fix:`, `docs:`, `gov:`), ~72 chars
subject, imperative voice, reasoning in body
- **Squash**: Squash WIP commits before opening PR
- **PR requirements**: Run pre-commit, document test coverage, note hardware limitations

Expand Down
2 changes: 1 addition & 1 deletion CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,7 @@ Pre-commit checks run automatically on every PR. CI executes
`pre-commit run --all-files` to verify formatting (Ruff, clang-format, mdformat) and
linting. Commit messages are also validated against
[Conventional Commits](https://www.conventionalcommits.org/) format (e.g., `feat: ...`,
`fix: ...`, `docs: ...`).
`fix: ...`, `docs: ...`, `gov: ...`).

As long as you have `pre-commit install --install-hooks` set up locally, your code will
be checked before each commit and your commit messages will be validated automatically.
Expand Down
1 change: 1 addition & 0 deletions GOVERNANCE.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@ project.
| Zhenan Fan | Huawei | @zhenanf |
| Ge Shi | Huawei | @geshi001 |
| Xiaojie Xu | Huawei | @PrometheusComing |
| Bingye Chen | ByteDance | @TaoZex |

**NOTE**: Maintainers from Huawei are the code owners of the `ascend*` branches.

Expand Down
Loading