Skip to content

Conversation

@theguild-bot
Copy link
Collaborator

This PR was opened by the Changesets release GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to master, this PR will be updated.

Releases

@whatwg-node/[email protected]

Patch Changes

@benchmarks/[email protected]

Patch Changes

@e2e/[email protected]

Patch Changes

@e2e/[email protected]

Patch Changes

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 6, 2025

📝 Walkthrough

Summary by CodeRabbit

  • Chores
    • Updated dependency versions across multiple packages for improved stability.
    • Replaced an outdated instrumentation dependency with a newer alternative.
    • Incremented package release numbers across key modules to reflect the latest patches.

Walkthrough

This pull request makes changes across several packages by updating version numbers and dependency configurations. In the @whatwg-node/server package, a dependency change is applied by adding @envelop/instrumentation@^1.0.0 and removing @envelop/[email protected]. Similar version bumps and dependency updates are reflected in changelogs and package manifests for the benchmarks, e2e shared-server, and e2e vercel packages.

Changes

File(s) Change Summary
.changeset/@whatwg-node_server-2145-dependencies.md, packages/server/CHANGELOG.md, packages/server/package.json For @whatwg-node/server: Added dependency @envelop/instrumentation@^1.0.0, removed @envelop/[email protected], and updated version from 0.10.0 to 0.10.1.
benchmarks/server/CHANGELOG.md, benchmarks/server/package.json For @benchmarks/server: Bumped version from 0.0.47 to 0.0.48 and updated dependency on @whatwg-node/server from 0.10.0 to 0.10.1.
e2e/shared-server/CHANGELOG.md, e2e/shared-server/package.json For @e2e/shared-server: Bumped version from 0.0.135 to 0.0.136 and updated dependency on @whatwg-node/server from 0.10.0 to 0.10.1.
e2e/vercel/CHANGELOG.md, e2e/vercel/package.json For @e2e/vercel: Bumped version from 0.0.135 to 0.0.136 and updated dependency on @e2e/shared-server from 0.0.135 to 0.0.136.

Possibly related PRs

Poem

I'm a nimble rabbit, hopping through code so light,
Skipping over outdated deps in the twilight.
With @envelop/instrumentation now in sight,
And old dependencies gone out of the fight.
My paws dance on versions, all tidy and bright! 🐇✨


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 6, 2025

🚀 Snapshot Release (rc)

The latest changes of this PR are available as rc on npm (based on the declared changesets):

Package Version Info
@whatwg-node/server 0.10.1-rc-20250306153928-e50def2030e4dd84245a6e49b70cfdd667806106 npm ↗︎ unpkg ↗︎

@github-actions
Copy link
Contributor

github-actions bot commented Mar 6, 2025

@benchmarks/node-fetch results (consumeBody)

   ✓ active_handles.................: avg=140.281653 min=25      med=141     max=197     p(90)=162     p(95)=168    
     data_received..................: 20 MB  667 kB/s
     data_sent......................: 13 MB  428 kB/s
     http_req_blocked...............: avg=3.27µs     min=652ns   med=1.31µs  max=4.34ms  p(90)=2.09µs  p(95)=2.33µs 
     http_req_connecting............: avg=1.46µs     min=0s      med=0s      max=4.31ms  p(90)=0s      p(95)=0s     
     http_req_duration..............: avg=22.85ms    min=6.42ms  med=22.21ms max=1.19s   p(90)=28.73ms p(95)=30.34ms
       { expected_response:true }...: avg=22.85ms    min=6.42ms  med=22.21ms max=1.19s   p(90)=28.73ms p(95)=30.34ms
     http_req_failed................: 0.00%  ✓ 0           ✗ 130834
     http_req_receiving.............: avg=33.02µs    min=9.06µs  med=24.09µs max=16.89ms p(90)=38.12µs p(95)=44.6µs 
     http_req_sending...............: avg=10.36µs    min=3.31µs  med=6.09µs  max=4.21ms  p(90)=9.92µs  p(95)=13.46µs
     http_req_tls_handshaking.......: avg=0s         min=0s      med=0s      max=0s      p(90)=0s      p(95)=0s     
     http_req_waiting...............: avg=22.81ms    min=6.2ms   med=22.17ms max=1.19s   p(90)=28.69ms p(95)=30.29ms
     http_reqs......................: 130834 4360.634026/s
     iteration_duration.............: avg=45.82ms    min=19.81ms med=44.32ms max=1.21s   p(90)=49.09ms p(95)=54.77ms
     iterations.....................: 65389  2179.383787/s
     vus............................: 100    min=100       max=100 
     vus_max........................: 100    min=100       max=100 

@github-actions
Copy link
Contributor

github-actions bot commented Mar 6, 2025

@benchmarks/node-fetch results (noConsumeBody)

   ✓ active_handles.................: avg=140.937604 min=44     med=140     max=179     p(90)=161     p(95)=164    
     data_received..................: 20 MB  677 kB/s
     data_sent......................: 13 MB  438 kB/s
     http_req_blocked...............: avg=4.43µs     min=652ns  med=1.3µs   max=8.24ms  p(90)=2.01µs  p(95)=2.27µs 
     http_req_connecting............: avg=2.62µs     min=0s     med=0s      max=7.55ms  p(90)=0s      p(95)=0s     
     http_req_duration..............: avg=22.52ms    min=5.38ms med=21.89ms max=1.09s   p(90)=28.37ms p(95)=30ms   
       { expected_response:true }...: avg=22.52ms    min=5.38ms med=21.89ms max=1.09s   p(90)=28.37ms p(95)=30ms   
     http_req_failed................: 0.00%  ✓ 0           ✗ 132770
     http_req_receiving.............: avg=34.15µs    min=9.16µs med=24.32µs max=17.3ms  p(90)=38.84µs p(95)=45.1µs 
     http_req_sending...............: avg=10.92µs    min=3.22µs med=6.35µs  max=11.66ms p(90)=9.89µs  p(95)=13.81µs
     http_req_tls_handshaking.......: avg=0s         min=0s     med=0s      max=0s      p(90)=0s      p(95)=0s     
     http_req_waiting...............: avg=22.47ms    min=5.35ms med=21.85ms max=1.09s   p(90)=28.32ms p(95)=29.94ms
     http_reqs......................: 132770 4425.255512/s
     iteration_duration.............: avg=45.15ms    min=23.7ms med=43.48ms max=1.12s   p(90)=49.24ms p(95)=55.46ms
     iterations.....................: 66366  2211.994482/s
     vus............................: 100    min=100       max=100 
     vus_max........................: 100    min=100       max=100 

@github-actions
Copy link
Contributor

github-actions bot commented Mar 6, 2025

@benchmarks/server results (undici)

     ✓ no-errors
     ✓ expected-result

   ✓ checks.........................: 100.00% ✓ 217682      ✗ 0     
     data_received..................: 22 MB   729 kB/s
     data_sent......................: 8.7 MB  290 kB/s
     http_req_blocked...............: avg=1.41µs   min=882ns    med=1.2µs    max=180.48µs p(90)=1.9µs    p(95)=2.07µs  
     http_req_connecting............: avg=1ns      min=0s       med=0s       max=114.91µs p(90)=0s       p(95)=0s      
     http_req_duration..............: avg=212.84µs min=154.74µs med=200.76µs max=56.49ms  p(90)=226.64µs p(95)=236.24µs
       { expected_response:true }...: avg=212.84µs min=154.74µs med=200.76µs max=56.49ms  p(90)=226.64µs p(95)=236.24µs
     http_req_failed................: 0.00%   ✓ 0           ✗ 108841
     http_req_receiving.............: avg=25.47µs  min=13.78µs  med=23.77µs  max=2.48ms   p(90)=31.07µs  p(95)=33.59µs 
     http_req_sending...............: avg=6.44µs   min=4.15µs   med=5.63µs   max=134.04µs p(90)=8.23µs   p(95)=8.99µs  
     http_req_tls_handshaking.......: avg=0s       min=0s       med=0s       max=0s       p(90)=0s       p(95)=0s      
     http_req_waiting...............: avg=180.92µs min=132.99µs med=168.94µs max=56.41ms  p(90)=191.62µs p(95)=200.29µs
     http_reqs......................: 108841  3627.865866/s
     iteration_duration.............: avg=271.14µs min=195.12µs med=257.93µs max=56.63ms  p(90)=287.5µs  p(95)=299.7µs 
     iterations.....................: 108841  3627.865866/s
     vus............................: 1       min=1         max=1   
     vus_max........................: 1       min=1         max=1   

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
packages/server/CHANGELOG.md (1)

64-66: Improve Documentation Wording

The documentation for multiple instrumentation plugins would benefit from clearer phrasing. In particular, consider replacing “in the same order than the plugin array (first is outermost, last is inner most)” with “in the same order as the plugin array (first is outermost, last is innermost)” to read more naturally and correct the compound word.

Suggested diff:

- it is possible to have multiple instrumentation plugins (Prometheus and Sentry for example), they
- will be automatically composed by envelop in the same order than the plugin array (first is
- outermost, last is inner most).
+ it is possible to have multiple instrumentation plugins (Prometheus and Sentry for example), they
+ will be automatically composed by envelop in the same order as the plugin array (first is
+ outermost, last is innermost).
🧰 Tools
🪛 LanguageTool

[grammar] ~65-~65: Comparison is written ‘the same … as’.
Context: ...y composed by envelop in the same order than the plugin array (first is outermost,...

(THE_SAME_AS)


[misspelling] ~66-~66: This word is normally spelled as one.
Context: ...in array (first is outermost, last is inner most). ```ts import { createServerAdapt...

(EN_COMPOUNDS_INNER_MOST)

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between dac036c and e50def2.

📒 Files selected for processing (9)
  • .changeset/@whatwg-node_server-2145-dependencies.md (0 hunks)
  • benchmarks/server/CHANGELOG.md (1 hunks)
  • benchmarks/server/package.json (2 hunks)
  • e2e/shared-server/CHANGELOG.md (1 hunks)
  • e2e/shared-server/package.json (1 hunks)
  • e2e/vercel/CHANGELOG.md (1 hunks)
  • e2e/vercel/package.json (2 hunks)
  • packages/server/CHANGELOG.md (4 hunks)
  • packages/server/package.json (1 hunks)
💤 Files with no reviewable changes (1)
  • .changeset/@whatwg-node_server-2145-dependencies.md
✅ Files skipped from review due to trivial changes (7)
  • packages/server/package.json
  • benchmarks/server/CHANGELOG.md
  • e2e/shared-server/package.json
  • benchmarks/server/package.json
  • e2e/vercel/package.json
  • e2e/vercel/CHANGELOG.md
  • e2e/shared-server/CHANGELOG.md
🧰 Additional context used
🪛 LanguageTool
packages/server/CHANGELOG.md

[grammar] ~65-~65: Comparison is written ‘the same … as’.
Context: ...y composed by envelop in the same order than the plugin array (first is outermost,...

(THE_SAME_AS)


[misspelling] ~66-~66: This word is normally spelled as one.
Context: ...in array (first is outermost, last is inner most). ```ts import { createServerAdapt...

(EN_COMPOUNDS_INNER_MOST)

⏰ Context from checks skipped due to timeout of 90000ms (14)
  • GitHub Check: unit / deno
  • GitHub Check: unit / node 23
  • GitHub Check: unit / node 22
  • GitHub Check: unit / node 20
  • GitHub Check: unit / bun
  • GitHub Check: server (undici)
  • GitHub Check: release-candidate / snapshot
  • GitHub Check: unit / node 18
  • GitHub Check: node-fetch (consumeBody)
  • GitHub Check: type check
  • GitHub Check: server (ponyfill)
  • GitHub Check: prettier
  • GitHub Check: node-fetch (noConsumeBody)
  • GitHub Check: server (native)
🔇 Additional comments (1)
packages/server/CHANGELOG.md (1)

3-16: New Release Entry for Version 0.10.1

The new changelog entry clearly documents the patch changes for version 0.10.1 with the dependency updates—adding @envelop/instrumentation@^1.0.0 and removing @envelop/[email protected]. Please verify that the PR number referenced (i.e. [#2145]) correctly aligns with your intended release documentation.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 6, 2025

@benchmarks/server results (ponyfill)

     ✓ no-errors
     ✓ expected-result

   ✓ checks.........................: 100.00% ✓ 291532      ✗ 0     
     data_received..................: 29 MB   957 kB/s
     data_sent......................: 12 MB   389 kB/s
     http_req_blocked...............: avg=1.38µs   min=872ns    med=1.18µs   max=221.55µs p(90)=1.85µs   p(95)=2.03µs  
     http_req_connecting............: avg=0ns      min=0s       med=0s       max=124.89µs p(90)=0s       p(95)=0s      
     http_req_duration..............: avg=142.53µs min=95.26µs  med=137.35µs max=6.37ms   p(90)=160.27µs p(95)=167.65µs
       { expected_response:true }...: avg=142.53µs min=95.26µs  med=137.35µs max=6.37ms   p(90)=160.27µs p(95)=167.65µs
     http_req_failed................: 0.00%   ✓ 0           ✗ 145766
     http_req_receiving.............: avg=24.67µs  min=12.03µs  med=22.94µs  max=2.98ms   p(90)=30.59µs  p(95)=33.41µs 
     http_req_sending...............: avg=6.37µs   min=4.05µs   med=5.53µs   max=863.95µs p(90)=8.1µs    p(95)=8.84µs  
     http_req_tls_handshaking.......: avg=0s       min=0s       med=0s       max=0s       p(90)=0s       p(95)=0s      
     http_req_waiting...............: avg=111.48µs min=68.4µs   med=106.08µs max=6.07ms   p(90)=125.62µs p(95)=131.66µs
     http_reqs......................: 145766  4858.695776/s
     iteration_duration.............: avg=201.26µs min=143.64µs med=195.3µs  max=6.45ms   p(90)=221.6µs  p(95)=231.43µs
     iterations.....................: 145766  4858.695776/s
     vus............................: 1       min=1         max=1   
     vus_max........................: 1       min=1         max=1   

@github-actions
Copy link
Contributor

github-actions bot commented Mar 6, 2025

@benchmarks/server results (native)

     ✓ no-errors
     ✓ expected-result

   ✓ checks.........................: 100.00% ✓ 223372      ✗ 0     
     data_received..................: 22 MB   748 kB/s
     data_sent......................: 8.9 MB  298 kB/s
     http_req_blocked...............: avg=1.51µs   min=902ns    med=1.23µs   max=638.58µs p(90)=1.94µs   p(95)=2.11µs  
     http_req_connecting............: avg=5ns      min=0s       med=0s       max=563.37µs p(90)=0s       p(95)=0s      
     http_req_duration..............: avg=202.42µs min=141.54µs med=191.6µs  max=22.46ms  p(90)=223.75µs p(95)=235.77µs
       { expected_response:true }...: avg=202.42µs min=141.54µs med=191.6µs  max=22.46ms  p(90)=223.75µs p(95)=235.77µs
     http_req_failed................: 0.00%   ✓ 0           ✗ 111686
     http_req_receiving.............: avg=26.53µs  min=13.18µs  med=23.93µs  max=4.48ms   p(90)=33.47µs  p(95)=41.37µs 
     http_req_sending...............: avg=6.83µs   min=4.05µs   med=5.94µs   max=316.83µs p(90)=8.38µs   p(95)=9.71µs  
     http_req_tls_handshaking.......: avg=0s       min=0s       med=0s       max=0s       p(90)=0s       p(95)=0s      
     http_req_waiting...............: avg=169.05µs min=120.31µs med=158.37µs max=22.37ms  p(90)=188.04µs p(95)=199.13µs
     http_reqs......................: 111686  3722.560691/s
     iteration_duration.............: avg=263.89µs min=184.12µs med=251.5µs  max=22.6ms   p(90)=289.54µs p(95)=306.55µs
     iterations.....................: 111686  3722.560691/s
     vus............................: 1       min=1         max=1   
     vus_max........................: 1       min=1         max=1   

@ardatan ardatan merged commit 382c7e1 into master Mar 6, 2025
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants