-
-
Notifications
You must be signed in to change notification settings - Fork 36
Upcoming Release Changes #2146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upcoming Release Changes #2146
Conversation
📝 WalkthroughSummary by CodeRabbit
WalkthroughThis pull request makes changes across several packages by updating version numbers and dependency configurations. In the Changes
Possibly related PRs
Poem
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
✅
|
✅
|
✅
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
packages/server/CHANGELOG.md (1)
64-66: Improve Documentation WordingThe documentation for multiple instrumentation plugins would benefit from clearer phrasing. In particular, consider replacing “in the same order than the plugin array (first is outermost, last is inner most)” with “in the same order as the plugin array (first is outermost, last is innermost)” to read more naturally and correct the compound word.
Suggested diff:
- it is possible to have multiple instrumentation plugins (Prometheus and Sentry for example), they - will be automatically composed by envelop in the same order than the plugin array (first is - outermost, last is inner most). + it is possible to have multiple instrumentation plugins (Prometheus and Sentry for example), they + will be automatically composed by envelop in the same order as the plugin array (first is + outermost, last is innermost).🧰 Tools
🪛 LanguageTool
[grammar] ~65-~65: Comparison is written ‘the same … as’.
Context: ...y composed by envelop in the same order than the plugin array (first is outermost,...(THE_SAME_AS)
[misspelling] ~66-~66: This word is normally spelled as one.
Context: ...in array (first is outermost, last is inner most). ```ts import { createServerAdapt...(EN_COMPOUNDS_INNER_MOST)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (9)
.changeset/@whatwg-node_server-2145-dependencies.md(0 hunks)benchmarks/server/CHANGELOG.md(1 hunks)benchmarks/server/package.json(2 hunks)e2e/shared-server/CHANGELOG.md(1 hunks)e2e/shared-server/package.json(1 hunks)e2e/vercel/CHANGELOG.md(1 hunks)e2e/vercel/package.json(2 hunks)packages/server/CHANGELOG.md(4 hunks)packages/server/package.json(1 hunks)
💤 Files with no reviewable changes (1)
- .changeset/@whatwg-node_server-2145-dependencies.md
✅ Files skipped from review due to trivial changes (7)
- packages/server/package.json
- benchmarks/server/CHANGELOG.md
- e2e/shared-server/package.json
- benchmarks/server/package.json
- e2e/vercel/package.json
- e2e/vercel/CHANGELOG.md
- e2e/shared-server/CHANGELOG.md
🧰 Additional context used
🪛 LanguageTool
packages/server/CHANGELOG.md
[grammar] ~65-~65: Comparison is written ‘the same … as’.
Context: ...y composed by envelop in the same order than the plugin array (first is outermost,...
(THE_SAME_AS)
[misspelling] ~66-~66: This word is normally spelled as one.
Context: ...in array (first is outermost, last is inner most). ```ts import { createServerAdapt...
(EN_COMPOUNDS_INNER_MOST)
⏰ Context from checks skipped due to timeout of 90000ms (14)
- GitHub Check: unit / deno
- GitHub Check: unit / node 23
- GitHub Check: unit / node 22
- GitHub Check: unit / node 20
- GitHub Check: unit / bun
- GitHub Check: server (undici)
- GitHub Check: release-candidate / snapshot
- GitHub Check: unit / node 18
- GitHub Check: node-fetch (consumeBody)
- GitHub Check: type check
- GitHub Check: server (ponyfill)
- GitHub Check: prettier
- GitHub Check: node-fetch (noConsumeBody)
- GitHub Check: server (native)
🔇 Additional comments (1)
packages/server/CHANGELOG.md (1)
3-16: New Release Entry for Version 0.10.1The new changelog entry clearly documents the patch changes for version 0.10.1 with the dependency updates—adding
@envelop/instrumentation@^1.0.0and removing@envelop/[email protected]. Please verify that the PR number referenced (i.e. [#2145]) correctly aligns with your intended release documentation.
✅
|
✅
|
This PR was opened by the Changesets release GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to master, this PR will be updated.
Releases
@whatwg-node/[email protected]
Patch Changes
dac036cThanks @ardatan! - dependencies updates:
@envelop/instrumentation@^1.0.0↗︎(to
dependencies)@envelop/[email protected]↗︎(from
dependencies)@benchmarks/[email protected]
Patch Changes
[
dac036c]:@e2e/[email protected]
Patch Changes
[
dac036c]:@e2e/[email protected]
Patch Changes