Skip to content

Conversation

@theguild-bot
Copy link
Collaborator

@theguild-bot theguild-bot commented Mar 2, 2025

This PR was opened by the Changesets release GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to master, this PR will be updated.

Releases

@whatwg-node/[email protected]

Patch Changes

  • #2123
    2ca563a
    Thanks @ardatan! - Use Node 16 at least to prevent breaking change
    on dependent Tools packages

@whatwg-node/[email protected]

Patch Changes

@benchmarks/[email protected]

Patch Changes

@e2e/[email protected]

Patch Changes

@e2e/[email protected]

Patch Changes

@theguild-bot theguild-bot force-pushed the changeset-release/master branch from 7bbd1bb to 9be5c9f Compare March 2, 2025 11:02
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 2, 2025

Warning

Rate limit exceeded

@theguild-bot has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 26 minutes and 33 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📥 Commits

Reviewing files that changed from the base of the PR and between 708ad8a and c7269e2.

📒 Files selected for processing (11)
  • .changeset/three-shirts-make.md (0 hunks)
  • benchmarks/server/CHANGELOG.md (1 hunks)
  • benchmarks/server/package.json (2 hunks)
  • e2e/shared-server/CHANGELOG.md (1 hunks)
  • e2e/shared-server/package.json (1 hunks)
  • e2e/vercel/CHANGELOG.md (1 hunks)
  • e2e/vercel/package.json (2 hunks)
  • packages/promise-helpers/CHANGELOG.md (1 hunks)
  • packages/promise-helpers/package.json (1 hunks)
  • packages/server/CHANGELOG.md (1 hunks)
  • packages/server/package.json (2 hunks)

Walkthrough

This pull request removes a changeset file that contained a patch for the @whatwg-node/server package to fix an error with the Request.url getter when used with Express on the Bun runtime. It updates version numbers and changelog entries across several packages—@benchmarks/server, @e2e/shared-server, @e2e/vercel, and @whatwg-node/server—reflecting dependency updates from version 0.9.70 to 0.9.71. No modifications were made to exported public entities.

Changes

File(s) Change Summary
.changeset/three-shirts-make.md Deleted changeset file containing a patch for @whatwg-node/server fixing the Request.url getter error when used with Express on Bun.
benchmarks/server/CHANGELOG.md
benchmarks/server/package.json
Updated @benchmarks/server version from 0.0.45 to 0.0.46 and dependency on @whatwg-node/server from 0.9.70 to 0.9.71.
e2e/shared-server/CHANGELOG.md
e2e/shared-server/package.json
Added new version entry (0.0.134) for @e2e/shared-server with dependency update for @whatwg-node/server from 0.9.70 to 0.9.71.
e2e/vercel/CHANGELOG.md
e2e/vercel/package.json
Updated @e2e/vercel version from 0.0.133 to 0.0.134 and dependency on @e2e/shared-server accordingly.
packages/server/CHANGELOG.md
packages/server/package.json
Added new version entry (0.9.71) for @whatwg-node/server with a patch for the Request.url getter error and updated the package version from 0.9.70 to 0.9.71.

Possibly related PRs

Suggested reviewers

  • dotansimha

Poem

I'm a hopping rabbit,
Cheering as I code away,
Nibbling patches like crunchy carrots,
Updates and fixes lead my day,
With every hop, the bugs all stray!
🥕🐇


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 2, 2025

@benchmarks/node-fetch results (consumeBody)

   ✓ active_handles.................: avg=140.62153 min=37      med=140     max=174     p(90)=161     p(95)=165    
     data_received..................: 20 MB  665 kB/s
     data_sent......................: 13 MB  426 kB/s
     http_req_blocked...............: avg=2.65µs    min=651ns   med=1.35µs  max=3.94ms  p(90)=2.09µs  p(95)=2.37µs 
     http_req_connecting............: avg=781ns     min=0s      med=0s      max=3.77ms  p(90)=0s      p(95)=0s     
     http_req_duration..............: avg=22.92ms   min=8.08ms  med=22.31ms max=1.15s   p(90)=28.79ms p(95)=30.62ms
       { expected_response:true }...: avg=22.92ms   min=8.08ms  med=22.31ms max=1.15s   p(90)=28.79ms p(95)=30.62ms
     http_req_failed................: 0.00%  ✓ 0           ✗ 130453
     http_req_receiving.............: avg=34.68µs   min=9.71µs  med=25.16µs max=14.63ms p(90)=39.34µs p(95)=45.89µs
     http_req_sending...............: avg=10.6µs    min=3.31µs  med=6.58µs  max=10.46ms p(90)=10.16µs p(95)=13.96µs
     http_req_tls_handshaking.......: avg=0s        min=0s      med=0s      max=0s      p(90)=0s      p(95)=0s     
     http_req_waiting...............: avg=22.87ms   min=8.03ms  med=22.27ms max=1.15s   p(90)=28.75ms p(95)=30.55ms
     http_reqs......................: 130453 4347.986378/s
     iteration_duration.............: avg=45.95ms   min=21.78ms med=44.32ms max=1.17s   p(90)=50.79ms p(95)=55.86ms
     iterations.....................: 65194  2172.909967/s
     vus............................: 99     min=99        max=100 
     vus_max........................: 100    min=100       max=100 

@github-actions
Copy link
Contributor

github-actions bot commented Mar 2, 2025

@benchmarks/node-fetch results (noConsumeBody)

   ✓ active_handles.................: avg=140.348091 min=12     med=141     max=177     p(90)=161     p(95)=164    
     data_received..................: 21 MB  683 kB/s
     data_sent......................: 13 MB  442 kB/s
     http_req_blocked...............: avg=2.58µs     min=672ns  med=1.37µs  max=6.15ms  p(90)=2.07µs  p(95)=2.35µs 
     http_req_connecting............: avg=627ns      min=0s     med=0s      max=3.15ms  p(90)=0s      p(95)=0s     
     http_req_duration..............: avg=22.33ms    min=3.47ms med=21.65ms max=1.27s   p(90)=28.31ms p(95)=29.82ms
       { expected_response:true }...: avg=22.33ms    min=3.47ms med=21.65ms max=1.27s   p(90)=28.31ms p(95)=29.82ms
     http_req_failed................: 0.00%  ✓ 0           ✗ 133941
     http_req_receiving.............: avg=33.87µs    min=9.22µs med=24.62µs max=13.59ms p(90)=39.63µs p(95)=46.32µs
     http_req_sending...............: avg=11.64µs    min=3.28µs med=6.65µs  max=11.75ms p(90)=10.25µs p(95)=14.43µs
     http_req_tls_handshaking.......: avg=0s         min=0s     med=0s      max=0s      p(90)=0s      p(95)=0s     
     http_req_waiting...............: avg=22.28ms    min=3.44ms med=21.61ms max=1.27s   p(90)=28.26ms p(95)=29.76ms
     http_reqs......................: 133941 4464.285873/s
     iteration_duration.............: avg=44.76ms    min=10.7ms med=43.13ms max=1.29s   p(90)=48.09ms p(95)=55.74ms
     iterations.....................: 66948  2231.393006/s
     vus............................: 100    min=100       max=100 
     vus_max........................: 100    min=100       max=100 

@github-actions
Copy link
Contributor

github-actions bot commented Mar 2, 2025

@benchmarks/server results (native)

     ✓ no-errors
     ✓ expected-result

   ✓ checks.........................: 100.00% ✓ 237210     ✗ 0     
     data_received..................: 24 MB   795 kB/s
     data_sent......................: 9.5 MB  316 kB/s
     http_req_blocked...............: avg=1.36µs   min=892ns    med=1.16µs   max=260.87µs p(90)=1.84µs   p(95)=2µs     
     http_req_connecting............: avg=1ns      min=0s       med=0s       max=121.72µs p(90)=0s       p(95)=0s      
     http_req_duration..............: avg=191.61µs min=138.25µs med=181.04µs max=10.2ms   p(90)=207.34µs p(95)=216.35µs
       { expected_response:true }...: avg=191.61µs min=138.25µs med=181.04µs max=10.2ms   p(90)=207.34µs p(95)=216.35µs
     http_req_failed................: 0.00%   ✓ 0          ✗ 118605
     http_req_receiving.............: avg=24.81µs  min=12.92µs  med=23.04µs  max=2.76ms   p(90)=30.14µs  p(95)=33µs    
     http_req_sending...............: avg=6.08µs   min=3.94µs   med=5.21µs   max=308.93µs p(90)=7.95µs   p(95)=8.45µs  
     http_req_tls_handshaking.......: avg=0s       min=0s       med=0s       max=0s       p(90)=0s       p(95)=0s      
     http_req_waiting...............: avg=160.72µs min=117.67µs med=149.58µs max=10.12ms  p(90)=173.2µs  p(95)=181.47µs
     http_reqs......................: 118605  3953.35445/s
     iteration_duration.............: avg=248.55µs min=182.65µs med=237.23µs max=10.34ms  p(90)=266.41µs p(95)=277.84µs
     iterations.....................: 118605  3953.35445/s
     vus............................: 1       min=1        max=1   
     vus_max........................: 1       min=1        max=1   

@github-actions
Copy link
Contributor

github-actions bot commented Mar 2, 2025

@benchmarks/server results (undici)

     ✓ no-errors
     ✓ expected-result

   ✓ checks.........................: 100.00% ✓ 219372      ✗ 0     
     data_received..................: 22 MB   735 kB/s
     data_sent......................: 8.8 MB  293 kB/s
     http_req_blocked...............: avg=1.38µs   min=932ns    med=1.18µs   max=710.42µs p(90)=1.88µs   p(95)=2.04µs  
     http_req_connecting............: avg=1ns      min=0s       med=0s       max=118.99µs p(90)=0s       p(95)=0s      
     http_req_duration..............: avg=212.21µs min=155.83µs med=198.74µs max=51.15ms  p(90)=226.26µs p(95)=237.04µs
       { expected_response:true }...: avg=212.21µs min=155.83µs med=198.74µs max=51.15ms  p(90)=226.26µs p(95)=237.04µs
     http_req_failed................: 0.00%   ✓ 0           ✗ 109686
     http_req_receiving.............: avg=24.84µs  min=13.49µs  med=23.1µs   max=2.57ms   p(90)=29.9µs   p(95)=32.62µs 
     http_req_sending...............: avg=6.09µs   min=4.01µs   med=5.23µs   max=291.54µs p(90)=7.97µs   p(95)=8.45µs  
     http_req_tls_handshaking.......: avg=0s       min=0s       med=0s       max=0s       p(90)=0s       p(95)=0s      
     http_req_waiting...............: avg=181.27µs min=134.32µs med=167.79µs max=51.07ms  p(90)=191.87µs p(95)=201.42µs
     http_reqs......................: 109686  3656.073471/s
     iteration_duration.............: avg=269.17µs min=199.2µs  med=254.76µs max=51.27ms  p(90)=285.62µs p(95)=299.43µs
     iterations.....................: 109686  3656.073471/s
     vus............................: 1       min=1         max=1   
     vus_max........................: 1       min=1         max=1   

@github-actions
Copy link
Contributor

github-actions bot commented Mar 2, 2025

@benchmarks/server results (ponyfill)

     ✓ no-errors
     ✓ expected-result

   ✓ checks.........................: 100.00% ✓ 296008      ✗ 0     
     data_received..................: 29 MB   972 kB/s
     data_sent......................: 12 MB   395 kB/s
     http_req_blocked...............: avg=1.32µs   min=831ns    med=1.14µs   max=271.1µs  p(90)=1.8µs    p(95)=1.96µs  
     http_req_connecting............: avg=0ns      min=0s       med=0s       max=142.78µs p(90)=0s       p(95)=0s      
     http_req_duration..............: avg=140.86µs min=96.26µs  med=136.02µs max=6.07ms   p(90)=158.3µs  p(95)=165.22µs
       { expected_response:true }...: avg=140.86µs min=96.26µs  med=136.02µs max=6.07ms   p(90)=158.3µs  p(95)=165.22µs
     http_req_failed................: 0.00%   ✓ 0           ✗ 148004
     http_req_receiving.............: avg=24.28µs  min=11.95µs  med=22.75µs  max=2.19ms   p(90)=30.14µs  p(95)=32.64µs 
     http_req_sending...............: avg=6.13µs   min=3.97µs   med=5.29µs   max=282.24µs p(90)=7.98µs   p(95)=8.61µs  
     http_req_tls_handshaking.......: avg=0s       min=0s       med=0s       max=0s       p(90)=0s       p(95)=0s      
     http_req_waiting...............: avg=110.43µs min=71.36µs  med=105.35µs max=6.03ms   p(90)=124.34µs p(95)=129.97µs
     http_reqs......................: 148004  4933.289237/s
     iteration_duration.............: avg=198.33µs min=142.13µs med=192.89µs max=6.17ms   p(90)=218.03µs p(95)=226.59µs
     iterations.....................: 148004  4933.289237/s
     vus............................: 1       min=1         max=1   
     vus_max........................: 1       min=1         max=1   

@github-actions
Copy link
Contributor

github-actions bot commented Mar 2, 2025

🚀 Snapshot Release (rc)

The latest changes of this PR are available as rc on npm (based on the declared changesets):

Package Version Info
@whatwg-node/promise-helpers 1.2.2-rc-20250303011016-c7269e2e84c01d60daa0afe83149838d6c8f6ffe npm ↗︎ unpkg ↗︎
@whatwg-node/server 0.9.71-rc-20250303011016-c7269e2e84c01d60daa0afe83149838d6c8f6ffe npm ↗︎ unpkg ↗︎

@theguild-bot theguild-bot force-pushed the changeset-release/master branch 3 times, most recently from 9cb6059 to c842af1 Compare March 3, 2025 01:07
@theguild-bot theguild-bot force-pushed the changeset-release/master branch from c842af1 to c7269e2 Compare March 3, 2025 01:08
@ardatan ardatan merged commit 70b4590 into master Mar 3, 2025
15 checks passed
@coderabbitai coderabbitai bot mentioned this pull request Mar 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants