retry get mode until success #191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sanglevinh
reviewed
Nov 27, 2023
frontend/src/App.tsx
Outdated
Comment on lines
36
to
38
| new Promise((resolve) => | ||
| setTimeout(resolve, 1000 * 2 ** attempts), | ||
| ).then(() => { |
There was a problem hiding this comment.
@ReiHashimoto I think if we do it like this, when the server fails, it will take a very long time to make api calls
There was a problem hiding this comment.
@sanglevinh Thank you for your review.
I replaced it to use constant waiting time.
Does it look fine?
There was a problem hiding this comment.
@ReiHashimoto Yes, I feel like this is quite reasonable
There was a problem hiding this comment.
@sanglevinh Thank you.
Can I merge this PR to your feature/mode_standalone branch?
There was a problem hiding this comment.
@ReiHashimoto yes, I removed the
if (res.data === undefined) {
return getModeStandaloneApi()
}
you can merge it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've added retry calling api to get mode.
Please give me your opinion on any potential problems or better ways to implement this.