Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

integrate api mode standalone #159

Merged
merged 16 commits into from
Nov 28, 2023
Merged

integrate api mode standalone #159

merged 16 commits into from
Nov 28, 2023

Conversation

sanglevinh
Copy link
Collaborator

No description provided.

@sanglevinh sanglevinh linked an issue Nov 16, 2023 that may be closed by this pull request
FE-BEの動作モードの連動 #116
Closed
@sanglevinh sanglevinh marked this pull request as ready for review November 20, 2023 10:29
ReiHashimoto
ReiHashimoto suggested changes Nov 21, 2023
View reviewed changes
Copy link

@ReiHashimoto ReiHashimoto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pls update frontend/.env.example, too.

frontend/src/store/slice/Standalone/StandaloneSlice.ts Outdated Show resolved Hide resolved
itutu-tienday
itutu-tienday requested changes Nov 28, 2023
View reviewed changes
studio/__main_unit__.py Outdated Show resolved Hide resolved
studio/__main_unit__.py Outdated Show resolved Hide resolved
@itutu-tienday
Copy link
Collaborator

@ReiHashimoto
当件、動作確認を実施済です。

Test case

  1. 基本的な動作確認（standalone mode, multiuser mode, の動作）
  2. 任意の箇所でFEリロード、BE mode が維持されているかどうか
  3. 異常系
    1. BEがダウンした状態での挙動確認
      • → BEが起動するまでFE利用不可（loding iconを継続）を確認
    2. FE動作時にBEのモードが変化（設定変更&再起動）した場合の挙動確認
      • ログイン画面 … FE/BEのモードが不整合であれば、ログイン不可を確認

@ReiHashimoto ReiHashimoto merged commit 0810c18 into develop-main Nov 28, 2023
5 checks passed
@ReiHashimoto ReiHashimoto deleted the feature/mode_standalone branch November 28, 2023 08:24
@ReiHashimoto ReiHashimoto mentioned this pull request Dec 19, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@itutu-tienday itutu-tienday itutu-tienday approved these changes

@ReiHashimoto ReiHashimoto ReiHashimoto approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

FE-BEの動作モードの連動
4 participants
@sanglevinh @itutu-tienday @ReiHashimoto @quanpython