-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
new: adbdgl refactor #30
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall lgtm.
a) would this PR require a new major version release given backwards compatibility? Do we need a migration guide?
b) what are the resulting doc changes? Do we need to sync with the doc team?
a) No need for a migration guide since the API convention/usability remains the same, but this will warrant a major version release (from b) Right, the doc team would have to replace the contents of https://www.arangodb.com/docs/stable/data-science-dgl-adapter.html#quickstart with https://github.com/arangoml/dgl-adapter/tree/feature/adapter-refactor#quickstart comments have been addressed via a40896b |
@geenen124 @joerg84 any other thoughts on moving forward with this PR? |
3.7 has reached eol
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like the colab link is out of date w.r.t. the notebook on this branch?
* initial commit * bump * cleanup workflows * Update build.yml * Update build.yml * parameter renaming, new `use_async` param * update release action
re-requesting review after having merged #31 |
Sorry @geenen124 had to make another readme update, one last review when you get the chance |
Warrants a
3.0.0
release (the large diff is mostly due to the notebook updates)See the new README
Closes #29
Note: For notebook testing purposes:
!pip install git+https://github.com/arangoml/dgl-adapter.git@feature/adapter-refactor
!git clone -b feature/adapter-refactor --single-branch https://github.com/arangoml/dgl-adapter.git
What's new
preserve_adb_keys
logic (DGL does not support lists of strings as a property)strict
parameter of Arangodb to PyG (for now)